mirror of
https://github.com/hanzo-apps/dataroom.git
synced 2026-10-30 14:47:36 +00:00
zeekayandHanzo Dev
42425d6bcd
QStash was already gone — `lib/cron/index.ts` shipped a stub whose publishJSON
logged a warning, returned `{ messageId: "noop" }` and DISCARDED the event. Every
customer webhook has been silently dropped since. Its sibling stub, `receiver`,
returned `true` for any signature.
Deliveries now go to a KV list (lib/kv-queue/webhooks.ts): rpush to enqueue, lpop
to take, failures returned with a raised attempt count until MAX_ATTEMPTS so a
customer endpoint that is briefly down keeps its event and one that is gone does
not spin. The signature is computed at enqueue and carried with the item, so a
retry re-sends identical bytes rather than re-signing a payload whose shape may
have moved. Enqueue never throws: a KV outage must not fail the caller's write.
/api/cron/webhooks drains it.
The cron guard was worse than the stub. It read
if (process.env.VERCEL === "1") { ...verify Upstash-Signature... }
and this app runs on Kubernetes, so the branch was ALWAYS false — every
/api/cron/* route was reachable by anyone with the path, and the verifier behind
it asserted nothing anyway. Replaced with a shared secret that FAILS CLOSED: no
CRON_SECRET, no cron. Nothing schedules these today, so a missing secret costs
nothing where the old behaviour cost everything. It is a secret, not an identity —
user-facing auth stays with Hanzo IAM.
Also drops the QStash env block, the dead Upstash locker vars, and the vendor
vocabulary in lib/kv.ts, where the shims describe a SHAPE (options object,
{ score, member }) rather than whoever shipped it.
Verified with npx tsc --noEmit: 100 errors before and after, 0 introduced,
compared set-wise by file:line:code.
Co-authored-by: Hanzo Dev <[email protected]>
60 lines
1.4 KiB
TypeScript
60 lines
1.4 KiB
TypeScript
import { verifyCron } from "@/lib/cron/verify";
|
|
import { sendWelcomeEmail } from "@/lib/emails/send-welcome";
|
|
import prisma from "@/lib/prisma";
|
|
import { subscribe } from "@/lib/resend";
|
|
|
|
export const dynamic = "force-dynamic";
|
|
|
|
export async function POST(req: Request) {
|
|
try {
|
|
const rawBody = await req.text();
|
|
const auth = verifyCron(req);
|
|
if (!auth.ok) {
|
|
return new Response("Unauthorized", { status: auth.status });
|
|
}
|
|
|
|
const { userId } = JSON.parse(rawBody);
|
|
|
|
const user = await prisma.user.findUnique({
|
|
where: {
|
|
id: userId,
|
|
},
|
|
select: {
|
|
name: true,
|
|
email: true,
|
|
},
|
|
});
|
|
|
|
if (!user) {
|
|
return new Response("User not found. Skipping...", { status: 200 });
|
|
}
|
|
|
|
// this shouldn't happen but just in case
|
|
if (!user.email) {
|
|
return new Response("User email not found. Skipping...", { status: 200 });
|
|
}
|
|
|
|
await Promise.allSettled([
|
|
// send welcome email
|
|
sendWelcomeEmail({
|
|
user: {
|
|
email: user.email,
|
|
name: user.name,
|
|
},
|
|
}),
|
|
// subscribe user to the mailing list
|
|
subscribe(user.email),
|
|
]);
|
|
|
|
return new Response("Welcome email sent and user subscribed.", {
|
|
status: 200,
|
|
});
|
|
} catch (error) {
|
|
console.error(error);
|
|
return new Response(
|
|
"Error sending welcome email and subscribing user to mailing list.",
|
|
{ status: 500 },
|
|
);
|
|
}
|
|
}
|