mirror of
https://github.com/hanzo-fi/payments.git
synced 2026-10-30 20:31:20 +00:00
CrimsonandGitHub
4d62f5b2dc
* Use validation library in account creation endpoint * Exclude testserver code from code coverage analysis * Update e2e test asset values to align with stricter validation * Use validation library in bank account creation endpoint * Add AccountType test and use external testing package for models tests * Add additional tests for bank account creation endpoint * Use validation library in bank account forward endpoint * Use validation library in payments creation endpoint * Update e2e test asset values to align with stricter validation * Add unit tests for payment related custom validation types
79 lines
2.4 KiB
Go
79 lines
2.4 KiB
Go
package v2
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
|
|
"github.com/formancehq/payments/internal/api/backend"
|
|
"github.com/formancehq/payments/internal/api/validation"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
"go.uber.org/mock/gomock"
|
|
)
|
|
|
|
var _ = Describe("API v2 Bank Accounts Create", func() {
|
|
var (
|
|
handlerFn http.HandlerFunc
|
|
accountNumber string
|
|
iban string
|
|
)
|
|
BeforeEach(func() {
|
|
accountNumber = "1232434"
|
|
iban = "DE89370400440532013000"
|
|
})
|
|
|
|
Context("create bank accounts", func() {
|
|
var (
|
|
w *httptest.ResponseRecorder
|
|
m *backend.MockBackend
|
|
bac BankAccountsCreateRequest
|
|
)
|
|
BeforeEach(func() {
|
|
w = httptest.NewRecorder()
|
|
ctrl := gomock.NewController(GinkgoT())
|
|
m = backend.NewMockBackend(ctrl)
|
|
handlerFn = bankAccountsCreate(m, validation.NewValidator())
|
|
})
|
|
|
|
It("should return a bad request error when body is missing", func(ctx SpecContext) {
|
|
req := httptest.NewRequest(http.MethodPost, "/", nil)
|
|
handlerFn(w, req)
|
|
|
|
assertExpectedResponse(w.Result(), http.StatusBadRequest, ErrMissingOrInvalidBody)
|
|
})
|
|
|
|
DescribeTable("validation errors",
|
|
func(bac BankAccountsCreateRequest) {
|
|
handlerFn(w, prepareJSONRequest(http.MethodPost, &bac))
|
|
assertExpectedResponse(w.Result(), http.StatusBadRequest, ErrValidation)
|
|
},
|
|
Entry("account number missing", BankAccountsCreateRequest{}),
|
|
Entry("iban missing", BankAccountsCreateRequest{AccountNumber: &accountNumber}),
|
|
Entry("name missing", BankAccountsCreateRequest{AccountNumber: &accountNumber, IBAN: &iban}),
|
|
)
|
|
|
|
It("should return an internal server error when backend returns error", func(ctx SpecContext) {
|
|
expectedErr := errors.New("bank account create err")
|
|
m.EXPECT().BankAccountsCreate(gomock.Any(), gomock.Any()).Return(expectedErr)
|
|
bac = BankAccountsCreateRequest{
|
|
Name: "reference",
|
|
IBAN: &iban,
|
|
AccountNumber: &accountNumber,
|
|
}
|
|
handlerFn(w, prepareJSONRequest(http.MethodPost, &bac))
|
|
assertExpectedResponse(w.Result(), http.StatusInternalServerError, "INTERNAL")
|
|
})
|
|
|
|
It("should return status ok on success", func(ctx SpecContext) {
|
|
m.EXPECT().BankAccountsCreate(gomock.Any(), gomock.Any()).Return(nil)
|
|
bac = BankAccountsCreateRequest{
|
|
Name: "reference",
|
|
IBAN: &iban,
|
|
AccountNumber: &accountNumber,
|
|
}
|
|
handlerFn(w, prepareJSONRequest(http.MethodPost, &bac))
|
|
assertExpectedResponse(w.Result(), http.StatusOK, "data")
|
|
})
|
|
})
|
|
})
|