mirror of
https://github.com/hanzo-fi/payments.git
synced 2026-10-30 20:31:20 +00:00
fgueryandGitHub
58271b3544
* doc(conn-92): fix doc link * doc(CONN-92): clarify the new connector creation instructions * feat(CONN-92): qonto plugin, account retrieval * feat(CONN-92): implement pagination and fix timezone * feat(CONN-92): add metadata * feat(CONN-92): fetchBalance implemented * feat(CONN-92): remove unsupported capabilities * feat(CONN-92): bank account type differ from different endpoint * feat(CONN-92): added external account + beneficiaries endpoint * feat(CONN-92): invalid beneficiary's accounts actually happen all the time * feat(CONN-92): allow multiple currencies for external accounts * feat(CONN-92): temp commit to debug payment save * feat(CONN-92): remove loggers * feat(CONN-92): better job at omitempty * feat(CONN-92): fix payment destination account to match external account * feat(CONN-92): added test for no from payload * feat(CONN-92): test on raw where relevant * feat(CONN-92): added payment_test * feat(CONN-92): use jsonNumber for incoming floats * feat(CONN_92): remove page number from request, instead use last_updated + pagesize * feat(CONN-92): fetch all transactions by statuses, in order (not only completed ones) * feat(CONN-92): always add the parentReference * feat(CONN-92): extract couple of method to improve readability * feat(CONN-92): use constants for transaction status * feat(CONN-92): added comment on transaction status * feat(CONN-92): add transfer endpoint * feat(CONN-92): unify account metadata syntax between internal & external accounts * feat(CONN-92): make plugin inherit from basePlugin * feat(CONN-92): add transfer capability * feat(CONN-92): fix internal transfert -- doc is lying on the response format * feat(CONN-92): avoid sending update_at_from == zero time (as Qonto refuses the request) * feat(CONN-92): coderabbit suggestions: * fix error formatting * more leniency in transfer response status check (allwing completed) * more validaiton when creating a transfer * feat(CONN-92): more coderabbit suggestions, improve error reporting * feat(CONN-92): more coderabbit suggestions, more errors on invalid state * feat(CONN-92): more coderabbit reviews, more coverage and bits of refacto * feat(CONN-92): bit more coverage * feat(CONN-92): bit more coverage * feat(CONN-92): added more coverage for config & errors; also improved Qonto's error reporting * feat(CONN-92): precommit run * feat(CONN-92): remove needMore functionality as its mostly irrelevant here * feat(CONN-92): codeRabbit is right, Qonto has a max page size -- my bad * feat(CONN-92): correct Account pagination * feat(CONN-92): account pagination with equal lastUpdatedAt * feat(CONN-92): review pagination for beneficiaries and payments * feat(CONN-92): update speakeasy lock * feat(CONN-92): added a bit of comments on the surprising bits * feat(CONN-92): codeRabbit comment * feat(CONN-92): transfer don't always return currency -- we can default to EUR as its the only one supported * feat(CONN-92): return error when account does not have currency set * feat(CONN-92): remove initialization of lastUpdatedAt * feat(CONN-92): remove all pagination from accounts, as we fetch all anyway * feat(CONN-92): cleaned somewhat the http connection logic * feat(CONN-92): add uuid in transfer as reference to pick it up for transaction matching later on * feat(CONN-92): detect transactions created via transfer and set parentId appropriately * feat(CONN-92): truncate too long reference * feat(CONN-92): remove create internal transfer endpoint
113 lines
3.2 KiB
Go
113 lines
3.2 KiB
Go
package qonto
|
|
|
|
import (
|
|
"encoding/json"
|
|
"github.com/go-playground/validator/v10"
|
|
|
|
"github.com/formancehq/payments/internal/models"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("unmarshalAndValidateConfig", func() {
|
|
var (
|
|
payload json.RawMessage
|
|
expectedError error
|
|
config Config
|
|
err error
|
|
)
|
|
|
|
JustBeforeEach(func() {
|
|
config, err = unmarshalAndValidateConfig(payload)
|
|
})
|
|
|
|
Context("with valid configuration", func() {
|
|
BeforeEach(func() {
|
|
payload = json.RawMessage(`{"clientID":"validClient","apiKey":"validApiKey","endpoint":"https://example.com","stagingToken":"token123"}`)
|
|
expectedError = nil
|
|
})
|
|
|
|
It("should successfully unmarshal and validate", func() {
|
|
Expect(err).To(BeNil())
|
|
Expect(config.ClientID).To(Equal("validClient"))
|
|
Expect(config.APIKey).To(Equal("validApiKey"))
|
|
Expect(config.Endpoint).To(Equal("https://example.com"))
|
|
Expect(config.StagingToken).To(Equal("token123"))
|
|
})
|
|
})
|
|
|
|
Context("with missing required fields", func() {
|
|
When("clientID is missing", func() {
|
|
BeforeEach(func() {
|
|
payload = json.RawMessage(`{"apiKey":"validApiKey","endpoint":"https://example.com"}`)
|
|
})
|
|
|
|
It("should return a validation error", func() {
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err).To(BeAssignableToTypeOf(validator.ValidationErrors{}))
|
|
})
|
|
})
|
|
|
|
When("apiKey is missing", func() {
|
|
BeforeEach(func() {
|
|
payload = json.RawMessage(`{"clientID":"validClient","endpoint":"https://example.com"}`)
|
|
})
|
|
|
|
It("should return a validation error", func() {
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err).To(BeAssignableToTypeOf(validator.ValidationErrors{}))
|
|
})
|
|
})
|
|
|
|
When("endpoint is missing", func() {
|
|
BeforeEach(func() {
|
|
payload = json.RawMessage(`{"clientID":"validClient","apiKey":"validApiKey"}`)
|
|
})
|
|
|
|
It("should return a validation error", func() {
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err).To(BeAssignableToTypeOf(validator.ValidationErrors{}))
|
|
})
|
|
})
|
|
})
|
|
|
|
Context("with extra unknown fields", func() {
|
|
BeforeEach(func() {
|
|
payload = json.RawMessage(`{"clientID":"validClient","apiKey":"validApiKey","endpoint":"https://example.com","unknownField":"value"}`)
|
|
expectedError = nil
|
|
})
|
|
|
|
It("should ignore unknown fields and successfully unmarshal", func() {
|
|
Expect(err).To(BeNil())
|
|
Expect(config.ClientID).To(Equal("validClient"))
|
|
Expect(config.APIKey).To(Equal("validApiKey"))
|
|
Expect(config.Endpoint).To(Equal("https://example.com"))
|
|
Expect(config.StagingToken).To(BeEmpty())
|
|
})
|
|
})
|
|
|
|
Context("with invalid JSON payload", func() {
|
|
BeforeEach(func() {
|
|
payload = json.RawMessage(`{"clientID":invalidJson}`)
|
|
expectedError = models.ErrInvalidConfig
|
|
})
|
|
|
|
It("should return an unmarshalling error", func() {
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err).To(MatchError(ContainSubstring(expectedError.Error())))
|
|
})
|
|
})
|
|
|
|
Context("with empty payload", func() {
|
|
BeforeEach(func() {
|
|
payload = json.RawMessage(``)
|
|
expectedError = models.ErrInvalidConfig
|
|
})
|
|
|
|
It("should return an unmarshalling error", func() {
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err).To(MatchError(ContainSubstring(expectedError.Error())))
|
|
})
|
|
})
|
|
})
|