mirror of
https://github.com/hanzo-fi/payments.git
synced 2026-10-30 20:31:20 +00:00
* feat(EN-214): add outbox table migration * feat(EN-214): add outbox models and storage layer * feat(EN-214): implement outbox publisher activity * feat(EN-214): implement outbox schedule activity * feat(EN-214): add outbox publisher workflow * feat(EN-214): migrate accounts to outbox pattern * feat(EN-214): migrate balances to outbox pattern * feat(EN-214): migrate payments to outbox pattern * feat(EN-214): migrate bank accounts to outbox pattern * feat(EN-214): migrate pools to outbox pattern * feat(EN-214): migrate payment initiations to outbox pattern * feat(EN-214): migrate PSU and connections to outbox pattern * feat(EN-214): migrate connectors to outbox pattern * feat(EN-214): remove legacy send_events workflow * feat(EN-214): update workflows to use outbox pattern * feat(EN-214): improve outbox idempotency and error handling * feat(EN-214): update storage tasks and tests * test(EN-214): update e2e tests for outbox pattern * test(EN-214): clean up workflow tests * chore(EN-214): update docker compose configuration * feat(EN-214): add e2e run config in ide * fix: add back docker-compose-dev run config * chore: improve connector uninstall comments & remove connector id being passed * fix: ensure events are not pushed if balances are not created * fix: ensure err is not overwritten when using rollback * fix: ensure we use v3 provider format * chore: apply the nitpick comments from coderabbit * chore: consistentely use e() error handling * feat: optionally disable publisher schedule to make e2e test more consistent * fix: improve error handling on uninstall connector * avoid using custom payload and rely on existing interfaces; also avoid using different types for events * fix: remove unecessary unmarshalling * fix: ensure that rollbackOnTxError picks up errors on tx.Commit() * fix: add extra validation on iban & account number in the test * test: cover marshall/unmarshalling of event payload * fix: increase test timeout * try to make test more resiliant * fix: wrong pointer use in loop * fix: error formatting issue * fix: move oubtox schedule creation out of an activity and do it in the worker itself * feat: OutboxEventDeleteAndSend as batch * change outbox_event to have id only instead of idempotency key * make e2e test less brittle, save eventID as idempotency key in publication * feat: make outbox_event keep an history * feat(EN-214): added a schedule to cleanup outbox events * test: make cleanup actually clean * ignore linting rules for now * feat: do not add psu metadata to event anymore as it's irrelevant * fix: create local variable instead of relying on pointers, even if not 100% necessary * fix: remove temporal schedule describe calls
81 lines
2.4 KiB
Go
81 lines
2.4 KiB
Go
package activities
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/formancehq/go-libs/v3/publish"
|
|
"github.com/formancehq/payments/internal/models"
|
|
"github.com/formancehq/payments/pkg/events"
|
|
"go.temporal.io/sdk/workflow"
|
|
)
|
|
|
|
func (a Activities) OutboxPublishPendingEvents(ctx context.Context, limit int) error {
|
|
// Poll pending events from outbox
|
|
outboxEvents, err := a.storage.OutboxEventsPollPending(ctx, limit)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to poll pending outbox events: %w", err)
|
|
}
|
|
|
|
if len(outboxEvents) == 0 {
|
|
return nil // No events to process
|
|
}
|
|
|
|
// Collect successful events for batch processing
|
|
var successfulEventIDs []models.EventID
|
|
var successfulEventsSent []models.EventSent
|
|
|
|
// Process each event
|
|
for _, event := range outboxEvents {
|
|
if err := a.processOutboxEvent(ctx, event); err != nil {
|
|
// Increment retry count (OutboxEventsMarkFailed handles status based on retry count)
|
|
retryCount := event.RetryCount + 1
|
|
|
|
if markErr := a.storage.OutboxEventsMarkFailed(ctx, event.ID, retryCount, err); markErr != nil {
|
|
return fmt.Errorf("failed to update event retry count: %w", markErr)
|
|
}
|
|
continue
|
|
}
|
|
|
|
// Success - collect for batch deletion and recording
|
|
eventSent := models.EventSent{
|
|
ID: event.ID,
|
|
ConnectorID: event.ConnectorID,
|
|
SentAt: time.Now().UTC(),
|
|
}
|
|
successfulEventIDs = append(successfulEventIDs, event.ID)
|
|
successfulEventsSent = append(successfulEventsSent, eventSent)
|
|
}
|
|
|
|
// Batch mark as processed and record successful events
|
|
if len(successfulEventIDs) > 0 {
|
|
if err := a.storage.OutboxEventsMarkProcessedAndRecordSent(ctx, successfulEventIDs, successfulEventsSent); err != nil {
|
|
return fmt.Errorf("failed to mark outbox events as processed and record sent: %w", err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (a Activities) processOutboxEvent(ctx context.Context, event models.OutboxEvent) error {
|
|
// Create the event message
|
|
eventMessage := publish.EventMessage{
|
|
IdempotencyKey: event.ID.String(),
|
|
Date: time.Now().UTC(),
|
|
App: events.EventApp,
|
|
Version: events.EventVersion,
|
|
Type: event.EventType,
|
|
Payload: event.Payload,
|
|
}
|
|
|
|
// Publish the event
|
|
return a.events.Publish(ctx, eventMessage)
|
|
}
|
|
|
|
var OutboxPublishPendingEventsActivity = Activities{}.OutboxPublishPendingEvents
|
|
|
|
func OutboxPublishPendingEvents(ctx workflow.Context, limit int) error {
|
|
return executeActivity(ctx, OutboxPublishPendingEventsActivity, nil, limit)
|
|
}
|