Files
CrimsonandGitHub d8a440a5a2 fix(connectors): prevent injection of arbitrary json keys in connector config (#526)
* Rename engine/plugins package to avoid confusion with connector/plugins package

* Update instances of plugins to be renamed to connectors

* Use Load/Unload for Connectors Manager to avoid confusion with Plugin Registry actions

* Add some unit tests for connectors.Manager

* Add Config method to Plugin interface

* Use validated config instead of raw config for insertion into DB

* Update plugin template to include new Config command

* Ensure plugin is not nil in workflow unit tests

* Small adjustments to e2e test expectations to reflect change in json validation of config

* Update codecoverage to exclude new generated files

* Guard against nil map in combineConfigs

* Update Plugin interface in CONTRIBUTING.md
2025-09-02 13:06:12 +00:00

229 lines
5.7 KiB
Go

package workflow
import (
"fmt"
"github.com/formancehq/payments/internal/connectors/engine/activities"
"github.com/formancehq/payments/internal/models"
errorsutils "github.com/formancehq/payments/internal/utils/errors"
"go.temporal.io/api/enums/v1"
"go.temporal.io/sdk/client"
"go.temporal.io/sdk/temporal"
"go.temporal.io/sdk/workflow"
)
type CreateTransfer struct {
TaskID models.TaskID
ConnectorID models.ConnectorID
PaymentInitiationID models.PaymentInitiationID
}
func (w Workflow) runCreateTransfer(
ctx workflow.Context,
createTransfer CreateTransfer,
) error {
err := w.createTransfer(ctx, createTransfer)
if err != nil {
errUpdateTask := w.updateTasksError(
ctx,
createTransfer.TaskID,
&createTransfer.ConnectorID,
err,
)
if errUpdateTask != nil {
return errUpdateTask
}
return err
}
return nil
}
func (w Workflow) createTransfer(
ctx workflow.Context,
createTransfer CreateTransfer,
) error {
// Get the payment initiation
pi, err := activities.StoragePaymentInitiationsGet(
infiniteRetryContext(ctx),
createTransfer.PaymentInitiationID,
)
if err != nil {
return err
}
// If the transfer is scheduled in the future, we need to add a schedule
// for processing adjustment to the payment initiation, and then sleep until
// the scheduled time.
now := workflow.Now(ctx)
if !pi.ScheduledAt.IsZero() && pi.ScheduledAt.After(now) {
err = w.addPIAdjustment(
ctx,
models.PaymentInitiationAdjustmentID{
PaymentInitiationID: createTransfer.PaymentInitiationID,
CreatedAt: workflow.Now(ctx),
Status: models.PAYMENT_INITIATION_ADJUSTMENT_STATUS_SCHEDULED_FOR_PROCESSING,
},
pi.Amount,
&pi.Asset,
nil,
map[string]string{
"scheduledAt": pi.ScheduledAt.String(),
},
)
if err != nil {
return err
}
err = workflow.Sleep(ctx, pi.ScheduledAt.Sub(now))
if err != nil {
return err
}
}
pspPI, err := w.getPSPPI(ctx, pi)
if err != nil {
return err
}
err = w.addPIAdjustment(
ctx,
models.PaymentInitiationAdjustmentID{
PaymentInitiationID: createTransfer.PaymentInitiationID,
CreatedAt: workflow.Now(ctx),
Status: models.PAYMENT_INITIATION_ADJUSTMENT_STATUS_PROCESSING,
},
pi.Amount,
&pi.Asset,
nil,
nil,
)
if err != nil {
return err
}
createTransferResponse, errPlugin := activities.PluginCreateTransfer(
infiniteRetryContext(ctx),
createTransfer.ConnectorID,
models.CreateTransferRequest{
PaymentInitiation: pspPI,
},
)
switch errPlugin {
case nil:
if createTransferResponse.Payment != nil {
// payment is already available, storing it
payment, err := models.FromPSPPaymentToPayment(*createTransferResponse.Payment, createTransfer.ConnectorID)
if err != nil {
return temporal.NewNonRetryableApplicationError(
"failed to translate psp payment",
ErrValidation,
err,
)
}
if err := w.storePIPaymentWithStatus(
ctx,
payment,
createTransfer.PaymentInitiationID,
getPIStatusFromPayment(payment.Status),
); err != nil {
return err
}
return w.updateTaskSuccess(
ctx,
createTransfer.TaskID,
&createTransfer.ConnectorID,
payment.ID.String(),
)
}
if createTransferResponse.PollingTransferID != nil {
// payment not yet available, waiting for the next polling
config, err := w.connectors.GetConfig(createTransfer.ConnectorID)
if err != nil {
return err
}
scheduleID := fmt.Sprintf("polling-transfer-%s-%s-%s", w.stack, createTransfer.ConnectorID.String(), *createTransferResponse.PollingTransferID)
err = activities.StorageSchedulesStore(
infiniteRetryContext(ctx),
models.Schedule{
ID: scheduleID,
ConnectorID: createTransfer.ConnectorID,
CreatedAt: workflow.Now(ctx).UTC(),
})
if err != nil {
return err
}
err = activities.TemporalScheduleCreate(
infiniteRetryContext(ctx),
activities.ScheduleCreateOptions{
ScheduleID: scheduleID,
Interval: client.ScheduleIntervalSpec{
Every: config.PollingPeriod,
},
Action: client.ScheduleWorkflowAction{
Workflow: RunPollTransfer,
Args: []interface{}{
PollTransfer{
TaskID: createTransfer.TaskID,
ConnectorID: createTransfer.ConnectorID,
PaymentInitiationID: createTransfer.PaymentInitiationID,
TransferID: *createTransferResponse.PollingTransferID,
ScheduleID: scheduleID,
},
},
TaskQueue: w.getDefaultTaskQueue(),
TypedSearchAttributes: temporal.NewSearchAttributes(
temporal.NewSearchAttributeKeyKeyword(SearchAttributeScheduleID).ValueSet(scheduleID),
temporal.NewSearchAttributeKeyKeyword(SearchAttributeStack).ValueSet(w.stack),
),
},
Overlap: enums.SCHEDULE_OVERLAP_POLICY_SKIP,
TriggerImmediately: true,
SearchAttributes: map[string]any{
SearchAttributeScheduleID: scheduleID,
SearchAttributeStack: w.stack,
},
},
)
if err != nil {
return err
}
}
return nil
default:
// Temporal errors do not have a Cause method, so we need to unwrap them
// to get the underlying error and not store the whole stack trace inside
// the database.
cause := errorsutils.Cause(errPlugin)
err := w.addPIAdjustment(
ctx,
models.PaymentInitiationAdjustmentID{
PaymentInitiationID: createTransfer.PaymentInitiationID,
CreatedAt: workflow.Now(ctx),
Status: models.PAYMENT_INITIATION_ADJUSTMENT_STATUS_FAILED,
},
pi.Amount,
&pi.Asset,
cause,
nil,
)
if err != nil {
return err
}
return errPlugin
}
}
const RunCreateTransfer = "CreateTransfer"