mirror of
https://github.com/hanzo-fi/payments.git
synced 2026-10-30 20:31:20 +00:00
* feat(EN-214): add outbox table migration * feat(EN-214): add outbox models and storage layer * feat(EN-214): implement outbox publisher activity * feat(EN-214): implement outbox schedule activity * feat(EN-214): add outbox publisher workflow * feat(EN-214): migrate accounts to outbox pattern * feat(EN-214): migrate balances to outbox pattern * feat(EN-214): migrate payments to outbox pattern * feat(EN-214): migrate bank accounts to outbox pattern * feat(EN-214): migrate pools to outbox pattern * feat(EN-214): migrate payment initiations to outbox pattern * feat(EN-214): migrate PSU and connections to outbox pattern * feat(EN-214): migrate connectors to outbox pattern * feat(EN-214): remove legacy send_events workflow * feat(EN-214): update workflows to use outbox pattern * feat(EN-214): improve outbox idempotency and error handling * feat(EN-214): update storage tasks and tests * test(EN-214): update e2e tests for outbox pattern * test(EN-214): clean up workflow tests * chore(EN-214): update docker compose configuration * feat(EN-214): add e2e run config in ide * fix: add back docker-compose-dev run config * chore: improve connector uninstall comments & remove connector id being passed * fix: ensure events are not pushed if balances are not created * fix: ensure err is not overwritten when using rollback * fix: ensure we use v3 provider format * chore: apply the nitpick comments from coderabbit * chore: consistentely use e() error handling * feat: optionally disable publisher schedule to make e2e test more consistent * fix: improve error handling on uninstall connector * avoid using custom payload and rely on existing interfaces; also avoid using different types for events * fix: remove unecessary unmarshalling * fix: ensure that rollbackOnTxError picks up errors on tx.Commit() * fix: add extra validation on iban & account number in the test * test: cover marshall/unmarshalling of event payload * fix: increase test timeout * try to make test more resiliant * fix: wrong pointer use in loop * fix: error formatting issue * fix: move oubtox schedule creation out of an activity and do it in the worker itself * feat: OutboxEventDeleteAndSend as batch * change outbox_event to have id only instead of idempotency key * make e2e test less brittle, save eventID as idempotency key in publication * feat: make outbox_event keep an history * feat(EN-214): added a schedule to cleanup outbox events * test: make cleanup actually clean * ignore linting rules for now * feat: do not add psu metadata to event anymore as it's irrelevant * fix: create local variable instead of relying on pointers, even if not 100% necessary * fix: remove temporal schedule describe calls
63 lines
2.0 KiB
Go
63 lines
2.0 KiB
Go
package activities_test
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"time"
|
|
|
|
"github.com/formancehq/go-libs/v3/logging"
|
|
"github.com/formancehq/payments/internal/connectors/engine/activities"
|
|
internalevents "github.com/formancehq/payments/internal/events"
|
|
"github.com/formancehq/payments/internal/storage"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
"go.uber.org/mock/gomock"
|
|
)
|
|
|
|
var _ = Describe("OutboxDeleteOldProcessedEvents", func() {
|
|
var (
|
|
act activities.Activities
|
|
s *storage.MockStorage
|
|
evts *internalevents.Events
|
|
logger = logging.NewDefaultLogger(GinkgoWriter, true, false, false)
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
ctrl := gomock.NewController(GinkgoT())
|
|
s = storage.NewMockStorage(ctrl)
|
|
evts = internalevents.New(nil, "http://localhost")
|
|
act = activities.New(logger, nil, s, evts, nil, 0)
|
|
})
|
|
|
|
Context("when deleting old processed outbox events", func() {
|
|
It("successfully deletes events older than 1 month", func(ctx SpecContext) {
|
|
// The activity calculates cutoff date as 1 month ago
|
|
// We expect the storage method to be called with a time approximately 1 month ago
|
|
s.EXPECT().
|
|
OutboxEventsDeleteOldProcessed(ctx, gomock.Any()).
|
|
Do(func(_ context.Context, cutoffDate time.Time) {
|
|
// Verify the cutoff date is approximately 1 month ago (within 1 day tolerance)
|
|
expectedCutoff := time.Now().UTC().AddDate(0, -1, 0)
|
|
diff := expectedCutoff.Sub(cutoffDate)
|
|
Expect(diff).To(BeNumerically("<", 24*time.Hour))
|
|
Expect(diff).To(BeNumerically(">", -24*time.Hour))
|
|
}).
|
|
Return(nil)
|
|
|
|
err := act.OutboxDeleteOldProcessedEvents(ctx)
|
|
Expect(err).To(BeNil())
|
|
})
|
|
|
|
It("handles storage error", func(ctx SpecContext) {
|
|
expectedErr := errors.New("database error")
|
|
s.EXPECT().
|
|
OutboxEventsDeleteOldProcessed(ctx, gomock.Any()).
|
|
Return(expectedErr)
|
|
|
|
err := act.OutboxDeleteOldProcessedEvents(ctx)
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("failed to delete old processed outbox events"))
|
|
})
|
|
})
|
|
})
|