67 Commits
Author SHA1 Message Date
643c0eb871 chore(models): Move models into kubeflow_katib_api package (#2579)
* chore(models): Move models into kubeflow_katib_api package

Signed-off-by: kramaranya <[email protected]>

* Add generated files to .pre-commit-config.yaml

Signed-off-by: kramaranya <[email protected]>

* Add SDK generator JAR file to .gitignore

Signed-off-by: kramaranya <[email protected]>

* Rename subfolder for gen-python-api

Signed-off-by: kramaranya <[email protected]>

* Remove subfolder for python-api

Signed-off-by: kramaranya <[email protected]>

* Generate Katib modules for Kubeflow SDK

Signed-off-by: Andrey Velichkevich <[email protected]>

* Add container runtime models generation

Signed-off-by: kramaranya <[email protected]>

* Fix shellcheck

Signed-off-by: kramaranya <[email protected]>

---------

Signed-off-by: kramaranya <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Co-authored-by: Andrey Velichkevich <[email protected]>
2025-10-13 21:57:05 +00:00
Shao WangandGitHub cd320f5ee2 Upgrade Kubernetes Version to 1.34 (#2573)
* chore: update Makefile and go.mod

Signed-off-by: Electronic-Waste <[email protected]>

* chore: make generate.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(ci): update k8s version.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trail): Update UTs to remove version related logic.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(ci): update setup-minkube version.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2025-09-22 12:03:01 +00:00
Shao WangandGitHub c6d1c993e3 Upgrade Kubernetes Version to 1.33 & Go to 1.24 (#2572)
Signed-off-by: Electronic-Waste <[email protected]>
2025-09-18 10:59:35 +00:00
Shao WangandGitHub 4a0f2c6609 Upgrade Kubernetes Version to 1.32.2 (#2521)
* chore(Makefile): upgrade envtest version to 1.32 & setup-envtest to release-0.20.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(gomod): upgrade go version to 1.23.0 & update package version.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: make generate.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(ci): add 1.32 support & remove 1.29 support.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): add FailureTarget condition to job & add startTime.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): add SuccessCriteriaMet condition.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): add StartTime.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): create a new Job after the failed job.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): move the failed job test to the end.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): update job to indexed job.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): seperate job name between failed job and succeeded job.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): remove SuccessPolicy.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): disable SuccessCriteriaMet in 1.30.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): delete some fields in Job.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): update comments.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): update comments.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(ci): readd v1.29 version.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): fix error in ci.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): fix version error.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2025-09-13 15:19:31 +00:00
Yuki IwaiandGitHub 1b5928f174 chore: Upgrade Go version to 1.23 (#2526)
Signed-off-by: Yuki Iwai <[email protected]>
2025-07-16 19:17:38 +00:00
Mahdi KhashanandGitHub 19db2d47d4 [feature] move manifest image references to ghcr (#2529)
* move to ghcr

Signed-off-by: mahdikhashan <[email protected]>

* move images to ghcr

Signed-off-by: mahdikhashan <[email protected]>

* manifests

Signed-off-by: mahdikhashan <[email protected]>

* change registry in all path

Signed-off-by: mahdikhashan <[email protected]>

* update script

Signed-off-by: mahdikhashan <[email protected]>

* fix

Signed-off-by: mahdikhashan <[email protected]>

* fix

Signed-off-by: mahdikhashan <[email protected]>

* slight fix

Signed-off-by: mahdikhashan <[email protected]>

---------

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Mahdi Khashan <[email protected]>
2025-03-24 17:11:50 +00:00
Hezhi (Helen) XieandGitHub 00508a2207 Install typing-extensions v4.10.0 to fix Python test error (#2504)
* update the version of typing-extensions

Signed-off-by: helenxie-bit <[email protected]>

* update comment

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
2025-01-30 15:58:53 +00:00
Shao WangandGitHub 5e3928f32b Upgrade Kubernetes to v1.31.3 (#2478)
* chore(ci): add k8s version 1.31.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(Makefile): upgrade envtest version to 1.31 & setup-envtest to release-0.19.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update k8s related package in go.mod

Signed-off-by: Electronic-Waste <[email protected]>

* chore: make generate.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): add SkipNameValidation option to test frame.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor(grpc): remove deprecated grpc.Dial implementation.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(dependency): remove dependency on k8s v1.28

Signed-off-by: Electronic-Waste <[email protected]>

* fix: add type assertion to ptr.To

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2025-01-14 11:06:08 +00:00
Shao WangandGitHub 6eaa64b2ee Upgrade Kubernetes to v1.30.7 (#2463)
* chore: update go.mod & go mod tidy.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: replace source.Kind and EnqueueRequestForXxx with typed func call.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update admission.Decoder in webhook.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update Makefile.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update codegen script.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: execute update-codegen.sh.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update openapigen & generate new openapi definitions.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix typo error.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update k8s version in CI.

Signed-off-by: Electronic-Waste <[email protected]>

* test(codegen): output CODEGEN_PKG.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(codegen): move shell check annotation.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(ci): change k8s version in go test to 1.30.0.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove toolchain declaration in go.mod

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove codegen dependency in openapigen.sh.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in recursive dir detection.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove a blank line.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove klog/v2

Signed-off-by: Electronic-Waste <[email protected]>

* chore(codegen): add three dots in the comment.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(codegen): fix package dependency on k8s.io/code-generator.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(Makefile): add go-mod-download.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2025-01-10 18:46:06 +00:00
Shao WangandGitHub 62c20c8893 [SDK] fix grpc related bugs in Python SDK (#2398)
* fix: fix bugs in report_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in tune.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update .gitignore and setup.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update Makefile.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add report_metrics_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add UTs for get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update post_gen.py.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor: rebase to master.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): use single katib_client.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): add TODO for import rewrite.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with black.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with isort.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): reformat import in katib_client_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2024-08-23 11:12:58 +00:00
Tariq HasanandGitHub 552d01e8d2 Add unit test for create_experiment in the katib_client module (#2325)
* added logger for katib_client module

Signed-off-by: tariq-hasan <[email protected]>

* added API_VERSION as a constant

Signed-off-by: tariq-hasan <[email protected]>

* updated the KatibClient constructor to match the TrainingClient constructor

Signed-off-by: tariq-hasan <[email protected]>

* added test for create_experiment in katib_client

Signed-off-by: tariq-hasan <[email protected]>

---------

Signed-off-by: tariq-hasan <[email protected]>
2024-06-20 15:34:00 +00:00
Andrey VelichkevichandGitHub 7ee1186208 Remove code generation from release script (#2363)
Signed-off-by: Andrey Velichkevich <[email protected]>
2024-06-20 10:27:00 +00:00
coldWaterandGitHub 7b821836f4 Replace gRPC code generation tool from Znly/protoc to Buf (#2344)
* Replace gRPC code generation tool from Znly/protoc to Buf

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* del build.sh

Signed-off-by: forsaken628 <[email protected]>

* cleanup

Signed-off-by: forsaken628 <[email protected]>

* fix test

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* refine

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* rm outter yaml

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

---------

Signed-off-by: forsaken628 <[email protected]>
2024-06-15 15:18:33 +00:00
coldWaterandGitHub 6fee7e0e48 Replace already closed github.com/golang/mock with go.uber.org/mock (#2357)
* replace gomock

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* revert

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

---------

Signed-off-by: forsaken628 <[email protected]>
2024-06-14 13:54:09 +00:00
Andrey VelichkevichandGitHub ded506b93e Support ARM64 arch for release images (#2315)
* Support ARM arch for release images

Signed-off-by: Andrey Velichkevich <[email protected]>

* Update Developer Doc

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Andrey Velichkevich <[email protected]>
2024-04-24 22:48:44 +00:00
Yuki IwaiandGitHub adb937f4e4 Upgrade Go version to v1.22 (#2309)
Signed-off-by: Yuki Iwai <[email protected]>
2024-04-15 12:58:51 +00:00
Yuki IwaiandGitHub 91236421fd Drop Kubernetes v1.26, and support Kubernetes v1.29 (#2308)
Signed-off-by: Yuki Iwai <[email protected]>
2024-04-15 10:55:51 +00:00
Yuki IwaiandGitHub 2c4dfbe861 Drop Kubernetes v1.25, and Support Kubernetes v1.28 (#2303)
Signed-off-by: Yuki Iwai <[email protected]>
2024-04-11 16:14:47 +00:00
Yuki IwaiandGitHub 105aea3d9e Upgrade Python version to 3.11 (#2278)
* Upgrade Python version to 3.11

Signed-off-by: Yuki Iwai <[email protected]>

* Upgrade the numpy version to 1.25.2

Signed-off-by: Yuki Iwai <[email protected]>

* Increase resource requests for the ENAS suggestion service

Signed-off-by: Yuki Iwai <[email protected]>

* Update pytest CI

Signed-off-by: Yuki Iwai <[email protected]>

* Prepare dedicated pytest for skopt

Signed-off-by: Yuki Iwai <[email protected]>

---------

Signed-off-by: Yuki Iwai <[email protected]>
2024-03-12 19:54:11 +00:00
Yuki IwaiandGitHub 76283f07e2 Install typing-extensions v4.6.3 for Optuna (#2251)
Signed-off-by: tenzen-y <[email protected]>
2024-01-04 13:32:12 +00:00
Yuki IwaiandGitHub cc41442971 Upgrade Go version to v1.20 (#2190)
Signed-off-by: Yuki Iwai <[email protected]>
2023-08-03 11:20:19 +00:00
Yuki IwaiandGitHub 371b9066d7 Allow install binaries for the arm64 in the envtest (#2188)
Signed-off-by: Yuki Iwai <[email protected]>
2023-08-01 20:41:07 +00:00
Yuki IwaiandGitHub 71ee0464c0 Implement KatibConfig API (#2176)
* Implement KatibConfig API

Signed-off-by: Yuki Iwai <[email protected]>

* Replace 'collectorKind' with 'kind'

Signed-off-by: Yuki Iwai <[email protected]>

* Replace 'metricsCollectorSidecars' with 'metricsCollectors'

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a typo

Signed-off-by: Yuki Iwai <[email protected]>

* Make the init.controller.leaderElection non-pointer

Signed-off-by: Yuki Iwai <[email protected]>

* Make the init.controller.injectSecurityContext non-pointer

Signed-off-by: Yuki Iwai <[email protected]>

* Update a comment for the future works

Signed-off-by: Yuki Iwai <[email protected]>

* Update manifest for the katib-leader-election

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a comment for the KatibConfig API

Signed-off-by: Yuki Iwai <[email protected]>

* Replace 'configapi' with 'configv1beta1'

Signed-off-by: Yuki Iwai <[email protected]>

* Remove debug code

Signed-off-by: Yuki Iwai <[email protected]>

* Put constant for the default KatibConfig value on /pkg/apis/config/v1beta1

Signed-off-by: Yuki Iwai <[email protected]>

* Use 'sigs.k8s.io/yaml' instead of 'github.com/ghodss/yaml'

Signed-off-by: Yuki Iwai <[email protected]>

* Avoid to depend on k8s.io/utils directly

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a typo

Signed-off-by: Yuki Iwai <[email protected]>

* Refactor katib-config using kustomize vars

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a typo

Signed-off-by: Yuki Iwai <[email protected]>

* Put KatibConfig on every install

Signed-off-by: Yuki Iwai <[email protected]>

* Remove configMapGenerator from the katib-with-kubeflow

Signed-off-by: Yuki Iwai <[email protected]>

---------

Signed-off-by: Yuki Iwai <[email protected]>
2023-08-01 18:45:08 +00:00
Yuki IwaiandGitHub 1604d9b32b Drop Kubernetes v1.24 and support Kubernetes v1.27 (#2182)
Signed-off-by: Yuki Iwai <[email protected]>
2023-08-01 16:32:06 +00:00
Yuki IwaiandGitHub 3b6aa7fc8e Drop Kubernetes v1.23 and support Kubernetes v1.26 (#2177)
Signed-off-by: Yuki Iwai <[email protected]>
2023-07-31 20:15:29 +00:00
Andrey VelichkevichandGitHub 7d16660c2c [UI] Remove Deprecated Katib UI (#2179)
* [UI] Remove Deprecated Katib UI

* Fix UI Developer doc
2023-07-25 09:53:29 +00:00
Yuki IwaiandGitHub e1f38f8e29 Add a --prefer-binary flag to 'pip install' command (#2096)
* Pin the h5py version with 3.7.0

Signed-off-by: Yuki Iwai <[email protected]>

* Add a --prefer-binary flag to 'pip install' command

Signed-off-by: Yuki Iwai <[email protected]>

Signed-off-by: Yuki Iwai <[email protected]>
2023-01-24 14:25:25 +00:00
Yuki IwaiandGitHub 856fb5c3e7 Remove Chocolate Suggestion Service (#2071)
Signed-off-by: Yuki Iwai <[email protected]>

Signed-off-by: Yuki Iwai <[email protected]>
2023-01-05 18:40:11 +00:00
Yuki IwaiandGitHub 7ccedd4120 Add scripts to verify generated codes and Go Modules (#1999)
Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
2022-11-30 19:03:16 +00:00
Johnu GeorgeandGitHub a7e1a3fcff Support for k8s v1.25 in CI (#1997)
* Support for k8s v1.25 in CI

* Revert "Support for k8s v1.25 in CI"

This reverts commit 16e6fe4b16820aea30e266a5c69560a92cfb851c.

* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Add Readme changes
2022-11-04 10:06:17 +00:00
Yuki IwaiandGitHub 7f843315df [chore] Upgrade Go version to v1.19 (#1995)
Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
2022-11-03 03:02:04 +00:00
Yuki IwaiandGitHub e77903667f Drop Kuberenetes v1.21 and introduce Kubernetes v1.24 (#1953)
Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
2022-09-17 12:59:45 +00:00
e4857e4c72 Support postgres as a katib db (#1921)
* implement postgres for katib db

* fix yaml lint

* apply go mod tidy

* Update manifests/v1beta1/components/postgres/postgres.yaml

Co-authored-by: Yuki Iwai <[email protected]>

* refactoring by reviews

- split openconnection to common packages
- add unit test for postgres db

* change to install only mysql by default

* remove useless import

* add postgres kustomization and e2e test for it

* change mysql installation files to be variable

* fix shell scripts

* fix lint

* fix image name

* set default value on github action workflow

* make postgres deployment to use pvc

* temporarily comments

* uncomment invalid experiments

* test with for loop

* sleep until controller created well

* add some comments

* Update pkg/db/v1beta1/postgres/postgres.go

Co-authored-by: Yuki Iwai <[email protected]>

* Update pkg/db/v1beta1/postgres/postgres_test.go

Co-authored-by: Yuki Iwai <[email protected]>

* refactor by reviews

Co-authored-by: Yuki Iwai <[email protected]>
2022-08-19 14:40:53 +00:00
Yuki IwaiandGitHub 360565afc9 [chore] Upgrade Go version to v1.18 (#1925) 2022-08-17 04:35:50 +00:00
Rishit DagliandGitHub be289c355d Linting for K8s YAML files (#1901)
* Add yamllint checking

* Update yamllint command

* Revert changes to charmed

* Create new workflow for yamllint

* Create a script to verify installation and run yamllint

* Add `make yamllint`

* Update lint workflow
2022-06-22 15:50:26 +00:00
a9pandGitHub 3fd8502567 Population based training (#1833)
* docs: update new algorithm service details

* feat: trial augmentation strategy

* feat: pbt suggestion service

* feat: PbtTemplate and associated test image

* feat: introduce annotation field to trial specifications

* feat: trial assignment changes to support annotations from suggestion

- Add new Annotation types to suggestion_types.go
- Add Annotation object and update Trial parser in trial.py

* feat: update pbt suggestion to use new Annotation api

- Suggestion uses exact match to track spawned trials
- Trials that get transmitted, but not created (or added to experiment) are added back to the respawn pool (population_size consistency)

* chore: gofmt and black run across PBT changes

* feedback: remove tf summary export, change default print unit, reduce range to be percentage compatible.

* feedback: move PBT template to example.

* feedback: changes to inject_webhook and utils.

- Rename mutateVolume to mutateMetricsCollectorVolume
- Add addContainerVolumeMount
- Add getPrimaryContainerIndex

* feedback: change suggestion mutation mount variable name and add to consts

* feedback: Add trial_names to GetSuggestionsReply and change suggestion path to <experiment>/<trial>

* feedback: removed unnecessary checks and moved to async pbt implementation

* feedback: update trial name override location and change annotations override to labels.

* feedback: add pbt to github workflow

* feedback: move labels to ParameterAssignments in GetSuggestionsReply and cleanup pbt.yaml.

* feedback: remove operator changes

* feedback: GHA updates

* feedback: new formatting changes

* feedback: add suggestion-pbt to gh-actions build-load.sh.

* fix: missing pbt->simple-pbt name changes, add simple-pbt to update-images.sh update yaml function (causing failing gha).

* feedback: add pointer to website from main readme for pbt
2022-06-21 15:35:34 +00:00
Yuki IwaiandGitHub 0f970a74b9 Include MetricsUnavailable condition to Complete in Trial (#1877)
* include MetricsUnavailable condition to Complete in Trial

It is not easy for users to find why Trial failed when training code output incorrect format logs
since the trial-controller sets Succeeded condition with False to Trial if there are unavailable metrics in Katib DB as described in https://github.com/kubeflow/katib/issues/1343.
So we also include MetricsUnavailable condition to Complete in Trial.

* add gh-actions tasks to verify generated codes

* fix gh-actions workflow

* when the number of Failed Trials reaches maxTrialCount, experiment-controller sets Failed to Experiment status

* fix e2e test

* To avoid being set Failed in Experiment status when  and  is equal to 0, we need to add condition,
2022-06-08 04:22:15 +00:00
Yuki IwaiandGitHub fc8149e917 chore: Upgrade Go libraries to resolve some security issues in the katib-controller (#1888) 2022-06-07 06:33:30 +00:00
Yuki IwaiandGitHub 8e4d9b84c2 Fix errors when running the test on Apple Silicon M1 (#1886)
* specify the CPU architecture when running setup-envtest

* upgrade gopsutil version to v3.22.5

* fix shellcheck error
2022-06-06 07:58:29 +00:00
Yuki IwaiandGitHub a7b30bd40f Add semicolon when using command command in Makefile (#1885)
* add a semicolon when using the `command` command in Makefile to avoid the `make: command: Command not found` error.

* fix shellcheck
2022-06-04 20:43:27 +00:00
Yuki IwaiandGitHub d0a70e8029 Fix HAS_SHELLCHECK and HAS_SETUP_ENVTEST in Makefile (#1884) 2022-06-04 06:32:27 +00:00
Yuki IwaiandGitHub 1611db0f37 Upgrade the kubebuilder to v3.2.0 and Kubernetes Go libraries to v1.22.2 (#1861)
* upgrade kubebuilder version from v2.3.0 to v3.2.0

* fix envtest for experiment-controller

* fix suite test

To avoid the `timeout waiting for process kube-apiserver to stop` error, we must use the `context.WithCancel`.
Ref: https://github.com/kubernetes-sigs/controller-runtime/issues/1571#issuecomment-945535598

* update Go version to v1.17 in kubeflow-katib-presubmit

To avoid the `../../../../pkg/mod/k8s.io/[email protected].2/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)` error,
we must use Go v1.16 or later, but as described in https://github.com/kubeflow/training-operator/issues/1581,
we do not have permission to update `public.ecr.aws/j1r0q0g6/kubeflow-testing:latest` so we need to update it in this.
2022-05-22 18:33:00 +00:00
Yuki IwaiandGitHub 152f19185e Add shellcheck (#1857)
* add shellcheck

* fix /test/e2e/v1beta1/scripts/run-e2e-experiment.sh

* fix test/e2e/v1beta1/scripts/setup-katib.sh

* fix pkg/apis/manager/[v1beta1|health]/build.sh

* fix scripts/v1beta1/deploy.sh

* fix scripts/v1beta1/release.sh

* fix scripts/v1beta1/update-images.sh

* fix scripts/v1beta1/undeploy.sh

* fix hack/update-openapigen.sh

* update boilerplate

* fix hack/gen-python-sdk/gen-sdk.sh

* fix hack/update-codegen.sh

* fix hack/update-mockgen.sh

* use /usr/bin/env bash

* add path to update-boilerplate.sh

* fix script to update boilerplate

* fix comment
2022-05-03 01:15:00 +00:00
Andrey VelichkevichandGitHub 63029671ed Add CPU architecture to release scripts (#1791) 2022-01-25 01:53:19 +00:00
0f8895c4ee Bump Python version to 3.9 (#1731)
* bump Python to 3.9

* modify script to build container image

* fix example for enas

* update scripts to modify image name in ci

* review: change docker build command

* review: use new tf-mnist-with-example in Ci for tfjob

* review: refactor tf-mnist-with-summaries

* review: remove Dockerfile.ppc64le for new-ui

* review: update docs related tf-mnist-with-summaries

* TFEventMetricsCollector supports TF>=2.0 and stop supporting TF <=1.x

* review: add help command to scripts/v1beta1/build.sh

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix unit test for tfevent-metricscollector

* review: generate tf event files on CI

* add test command to Makefile

* update publish-trial-images

* update update-images.sh

* reduce batch size

Co-authored-by: Andrey Velichkevich <[email protected]>
2021-12-10 12:33:49 +00:00
Andrey VelichkevichandGitHub 2cbf4ec74a Use release tags for Trial images (#1757)
* Update all Trial image tags to latest

* Modify tags in Notebooks

* Rename script

* Script changes

* Few changes

* Add other images

* Modify test script

* Finish test script

* Modify release script

* Finish release script

* Few changes
2021-12-10 02:11:48 +00:00
Andrey VelichkevichandGitHub 23258c917b Update Go version to 1.17 (#1683)
* Use Go 1.17 version

* Fix code generator import

* Change after review

* Run lint

* Use go install for lint
2021-09-28 09:05:11 -07:00
ca6419ba90 Use golangci-lint as linter for Go (#1671)
* use golangci-lint as linter for Go instead of golint

* Update hack/verify-golangci-lint.sh

Co-authored-by: Andrey Velichkevich <[email protected]>

* specify golangci-lint version

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix echo comment

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix echo comment

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix lint

* fix gofmt

* fix generated codes

* close the connection for early stopping without using defer

* do not create or delete any resources within gomega.Eventually

* add condition to return error in getKatibJob func

* remove comment out lines

* simplify some codes

Co-authored-by: Andrey Velichkevich <[email protected]>

* remove an unnecessary variable

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix golangci-lint error

Co-authored-by: Andrey Velichkevich <[email protected]>

Co-authored-by: Andrey Velichkevich <[email protected]>
2021-09-23 23:09:37 -07:00
Seongjin KimandGitHub fd620741b6 new-ui: Add devDependency - prettier (#1629)
* new-ui: Add devDependency - prettier

* new-ui: update prettier version on Github Action

* new-ui: Update test-node.yaml

* new-ui: Edit test-node.yaml / Makefile

* new-ui: Edit npm install prettier command on test-node workflow

* new-ui: Apply npm run format:write
2021-08-24 18:37:45 -07:00
Andrey VelichkevichandGitHub d6937492c0 Add gRPC build script to CI (#1569)
* Add gRPC build script to CI

* Fix text

* Change to i flag

* Change to -i in health
2021-07-01 22:44:10 -07:00