56 Commits
Author SHA1 Message Date
Andrey VelichkevichandGitHub 389b4de95b Bump Katib Python SDK to 0.19.0 version (#2585)
* Bump Katib Python SDK to 0.19.0 version

Signed-off-by: Andrey Velichkevich <[email protected]>

* Update version in gen-api

Signed-off-by: Andrey Velichkevich <[email protected]>

* Fix release script

Signed-off-by: Andrey Velichkevich <[email protected]>

* Run gen-api directly

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Andrey Velichkevich <[email protected]>
2025-10-30 23:52:38 +00:00
643c0eb871 chore(models): Move models into kubeflow_katib_api package (#2579)
* chore(models): Move models into kubeflow_katib_api package

Signed-off-by: kramaranya <[email protected]>

* Add generated files to .pre-commit-config.yaml

Signed-off-by: kramaranya <[email protected]>

* Add SDK generator JAR file to .gitignore

Signed-off-by: kramaranya <[email protected]>

* Rename subfolder for gen-python-api

Signed-off-by: kramaranya <[email protected]>

* Remove subfolder for python-api

Signed-off-by: kramaranya <[email protected]>

* Generate Katib modules for Kubeflow SDK

Signed-off-by: Andrey Velichkevich <[email protected]>

* Add container runtime models generation

Signed-off-by: kramaranya <[email protected]>

* Fix shellcheck

Signed-off-by: kramaranya <[email protected]>

---------

Signed-off-by: kramaranya <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Co-authored-by: Andrey Velichkevich <[email protected]>
2025-10-13 21:57:05 +00:00
Yuki IwaiandGitHub 1b5928f174 chore: Upgrade Go version to 1.23 (#2526)
Signed-off-by: Yuki Iwai <[email protected]>
2025-07-16 19:17:38 +00:00
Andrey VelichkevichandGitHub 96f3ed1b5f [SDK] Support PyTorchJob as a Trial Worker (#2512)
* [SDK] Support PyTorchJob as Trial Worker

Signed-off-by: Andrey Velichkevich <[email protected]>

* Fix pod spec for Job

Signed-off-by: Andrey Velichkevich <[email protected]>

* Set default restart_policy to Never

Signed-off-by: Andrey Velichkevich <[email protected]>

* Fix primary_container_name for PyTorchJob

Signed-off-by: Andrey Velichkevich <[email protected]>

* Add unit tests for PyTorchJob as Trial

Signed-off-by: Andrey Velichkevich <[email protected]>

* Add e2e test for PyTorchJob as Trial

Signed-off-by: Andrey Velichkevich <[email protected]>

* Bump kubeflow-training SDK

Signed-off-by: Andrey Velichkevich <[email protected]>

* Deploy Training Operator with server side apply

Signed-off-by: Andrey Velichkevich <[email protected]>

* Decrease CPUs for E2E

Signed-off-by: Andrey Velichkevich <[email protected]>

* Install Training Operator for tune workflow

Signed-off-by: Andrey Velichkevich <[email protected]>

* Fix comments

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Andrey Velichkevich <[email protected]>
2025-02-13 11:10:36 +00:00
Tsz Lung ChungandGitHub 956f49ff87 fix(api): resolve all api voilation exceptions in katib api (#2482)
Signed-off-by: truc0 <[email protected]>
2025-01-21 14:23:11 +00:00
a13b11d25b Upgrade klog to v2 (#2470)
* Upgrade klog dependency to v2

Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>

* fix: fix conflict with k8s upate

Signed-off-by: Xinmin Du <[email protected]>

---------

Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Du Xinmin <[email protected]>
Co-authored-by: Xinmin Du <[email protected]>
2025-01-15 05:22:12 +00:00
Shao WangandGitHub 6eaa64b2ee Upgrade Kubernetes to v1.30.7 (#2463)
* chore: update go.mod & go mod tidy.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: replace source.Kind and EnqueueRequestForXxx with typed func call.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update admission.Decoder in webhook.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update Makefile.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update codegen script.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: execute update-codegen.sh.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update openapigen & generate new openapi definitions.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix typo error.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update k8s version in CI.

Signed-off-by: Electronic-Waste <[email protected]>

* test(codegen): output CODEGEN_PKG.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(codegen): move shell check annotation.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(ci): change k8s version in go test to 1.30.0.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove toolchain declaration in go.mod

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove codegen dependency in openapigen.sh.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in recursive dir detection.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove a blank line.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove klog/v2

Signed-off-by: Electronic-Waste <[email protected]>

* chore(codegen): add three dots in the comment.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(codegen): fix package dependency on k8s.io/code-generator.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(Makefile): add go-mod-download.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2025-01-10 18:46:06 +00:00
Shao WangandGitHub d0847fa6eb fix: remove remaining MXNet dependency. (#2456)
Signed-off-by: Electronic-Waste <[email protected]>
2024-12-02 13:23:57 +00:00
Hezhi (Helen) XieandGitHub 05b6be71bb [GSoC] Update tune API for LLM hyperparameters optimization (#2393)
* update tune api for llm hyperparameters optimization

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflict

Signed-off-by: helenxie-bit <[email protected]>

* fix the problem of dependency

Signed-off-by: helenxie-bit <[email protected]>

* fix the format of import statement

Signed-off-by: helenxie-bit <[email protected]>

* adjust the blank lines

Signed-off-by: helenxie-bit <[email protected]>

* delete the trainer to reuse it in Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* update constants

Signed-off-by: helenxie-bit <[email protected]>

* update metrics format

Signed-off-by: helenxie-bit <[email protected]>

* update the type of  and

Signed-off-by: helenxie-bit <[email protected]>

* update the message of 'ImportError'

Signed-off-by: helenxie-bit <[email protected]>

* add TODO of PVC creation

Signed-off-by: helenxie-bit <[email protected]>

* update the name of pvc

Signed-off-by: helenxie-bit <[email protected]>

* reuse constants from Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* keep 'parameters' and update validation

Signed-off-by: helenxie-bit <[email protected]>

* update for test

Signed-off-by: helenxie-bit <[email protected]>

* reuse 'get_container_spec' and 'get_pod_template_spec' from Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* format with black

Signed-off-by: helenxie-bit <[email protected]>

* fix Lint error

Signed-off-by: helenxie-bit <[email protected]>

* fix Lint errors

Signed-off-by: helenxie-bit <[email protected]>

* delete types

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* fix e2e test error

Signed-off-by: helenxie-bit <[email protected]>

* add TODO

Signed-off-by: helenxie-bit <[email protected]>

* format with max line length

Signed-off-by: helenxie-bit <[email protected]>

* format docstring

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* add helper functions

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* fix dict substitution in training_parameters

Signed-off-by: helenxie-bit <[email protected]>

* fix typo

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflicts and add check for case of no parameters

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix flake8 error

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update isort file to black and fix typo

Signed-off-by: helenxie-bit <[email protected]>

* modify the set of metrics format

Signed-off-by: helenxie-bit <[email protected]>

* update tune API

Signed-off-by: helenxie-bit <[email protected]>

* add types.TrainerResources class

Signed-off-by: helenxie-bit <[email protected]>

* fix flake8 error

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflict

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* delete properties of 'TrainerResources'

Signed-off-by: helenxie-bit <[email protected]>

* fix format error

Signed-off-by: helenxie-bit <[email protected]>

* update types

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* add import of 'TrainerResources' in '__init__.py' of katib

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* revert changes and rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* check pvc and pv status of katib deployments

Signed-off-by: helenxie-bit <[email protected]>

* check pvc and pv status of katib deployments

Signed-off-by: helenxie-bit <[email protected]>

* recommit changes

Signed-off-by: helenxie-bit <[email protected]>

* update minikube version when setup

Signed-off-by: helenxie-bit <[email protected]>

* delete the code that disables formatting for the tune function

Signed-off-by: helenxie-bit <[email protected]>

* update according to andrey's feedback

Signed-off-by: helenxie-bit <[email protected]>

* add helper function in utils

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* move metrics_collector_spec back & update helper functions & add return type for helper functions

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* fix some typos

Signed-off-by: helenxie-bit <[email protected]>

* simplify the definition of 'TrainerResources'

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
2024-09-03 11:35:14 +00:00
Shao WangandGitHub 62c20c8893 [SDK] fix grpc related bugs in Python SDK (#2398)
* fix: fix bugs in report_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in tune.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update .gitignore and setup.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update Makefile.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add report_metrics_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add UTs for get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update post_gen.py.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor: rebase to master.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): use single katib_client.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): add TODO for import rewrite.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with black.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with isort.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): reformat import in katib_client_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2024-08-23 11:12:58 +00:00
Ignas BaranauskasandGitHub bcb199ddc3 Enhance pre-commit hooks with flake8 and black (#2407)
* Add black formater and flake8 linter to pre-commit

Also add's the flake8 config file

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fixes black formating

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fixes flake8 linting errors

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
2024-08-16 10:13:28 +00:00
Shao WangandGitHub 1e06458e1f [GSoC] Add New Parameter in tune (#2369)
* chore: add metrics_collector_config in tune function.

Signed-off-by: Electronic-Waste <[email protected]>

* rebase: rebase feat/new-param-tune to master.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add metrics collector kind list in comment.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: always pass Trial name to the training container.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: delete passing env variable logics in katib_client.py

Signed-off-by: Electronic-Waste <[email protected]>

* fix: passing env variable KATIB_TRIAL_NAME in the webhook of pod.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: pass env variable KATIB_TRIAL_NAME only to the primary container.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add report_metrics in post_gen.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: change nil error to allErrs(deleted by accident).

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error in inject_webhook.go.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: wrap env variables passing logics into mutatePodEnv.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add unit tests for mutatePodEnv.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: delete protocmp.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
2024-07-18 17:51:57 +00:00
coldWaterandGitHub 7b821836f4 Replace gRPC code generation tool from Znly/protoc to Buf (#2344)
* Replace gRPC code generation tool from Znly/protoc to Buf

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* del build.sh

Signed-off-by: forsaken628 <[email protected]>

* cleanup

Signed-off-by: forsaken628 <[email protected]>

* fix test

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* refine

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* rm outter yaml

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

---------

Signed-off-by: forsaken628 <[email protected]>
2024-06-15 15:18:33 +00:00
coldWaterandGitHub 6fee7e0e48 Replace already closed github.com/golang/mock with go.uber.org/mock (#2357)
* replace gomock

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* revert

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

* fix

Signed-off-by: forsaken628 <[email protected]>

---------

Signed-off-by: forsaken628 <[email protected]>
2024-06-14 13:54:09 +00:00
Yuki IwaiandGitHub adb937f4e4 Upgrade Go version to v1.22 (#2309)
Signed-off-by: Yuki Iwai <[email protected]>
2024-04-15 12:58:51 +00:00
Yuki IwaiandGitHub 2c4dfbe861 Drop Kubernetes v1.25, and Support Kubernetes v1.28 (#2303)
Signed-off-by: Yuki Iwai <[email protected]>
2024-04-11 16:14:47 +00:00
Yuki IwaiandGitHub 38647e6989 Remove MXNet examples (#2267)
* UT: Replace MXNet example with PyTorch example

Signed-off-by: Yuki Iwai <[email protected]>

* CI: Replace MXNet examples with PyTorch examples

Signed-off-by: Yuki Iwai <[email protected]>

---------

Signed-off-by: Yuki Iwai <[email protected]>
2024-03-04 10:45:07 +00:00
Yuki IwaiandGitHub cc41442971 Upgrade Go version to v1.20 (#2190)
Signed-off-by: Yuki Iwai <[email protected]>
2023-08-03 11:20:19 +00:00
Yuki IwaiandGitHub 71ee0464c0 Implement KatibConfig API (#2176)
* Implement KatibConfig API

Signed-off-by: Yuki Iwai <[email protected]>

* Replace 'collectorKind' with 'kind'

Signed-off-by: Yuki Iwai <[email protected]>

* Replace 'metricsCollectorSidecars' with 'metricsCollectors'

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a typo

Signed-off-by: Yuki Iwai <[email protected]>

* Make the init.controller.leaderElection non-pointer

Signed-off-by: Yuki Iwai <[email protected]>

* Make the init.controller.injectSecurityContext non-pointer

Signed-off-by: Yuki Iwai <[email protected]>

* Update a comment for the future works

Signed-off-by: Yuki Iwai <[email protected]>

* Update manifest for the katib-leader-election

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a comment for the KatibConfig API

Signed-off-by: Yuki Iwai <[email protected]>

* Replace 'configapi' with 'configv1beta1'

Signed-off-by: Yuki Iwai <[email protected]>

* Remove debug code

Signed-off-by: Yuki Iwai <[email protected]>

* Put constant for the default KatibConfig value on /pkg/apis/config/v1beta1

Signed-off-by: Yuki Iwai <[email protected]>

* Use 'sigs.k8s.io/yaml' instead of 'github.com/ghodss/yaml'

Signed-off-by: Yuki Iwai <[email protected]>

* Avoid to depend on k8s.io/utils directly

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a typo

Signed-off-by: Yuki Iwai <[email protected]>

* Refactor katib-config using kustomize vars

Signed-off-by: Yuki Iwai <[email protected]>

* Fix a typo

Signed-off-by: Yuki Iwai <[email protected]>

* Put KatibConfig on every install

Signed-off-by: Yuki Iwai <[email protected]>

* Remove configMapGenerator from the katib-with-kubeflow

Signed-off-by: Yuki Iwai <[email protected]>

---------

Signed-off-by: Yuki Iwai <[email protected]>
2023-08-01 18:45:08 +00:00
Andrey VelichkevichandGitHub 00faa70d8e SDK: Import all Kubernetes Models (#2148) 2023-04-20 16:56:40 +00:00
Yuki IwaiandGitHub 7ccedd4120 Add scripts to verify generated codes and Go Modules (#1999)
Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
2022-11-30 19:03:16 +00:00
Yuki IwaiandGitHub 7f843315df [chore] Upgrade Go version to v1.19 (#1995)
Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
2022-11-03 03:02:04 +00:00
b96916f6fc Create Tune API in the Katib SDK (#1951)
* Create Tune API in the Katib SDK

* Add Final to consts
Modify packages_to_install doc
Create validate objective function

* Add GPU TF Image
Change k8s version package

* Create search module

* Fix link in README

Co-authored-by: Yuki Iwai <[email protected]>

* Fix licence date

Co-authored-by: Yuki Iwai <[email protected]>
2022-10-04 21:19:22 +00:00
Yuki IwaiandGitHub 360565afc9 [chore] Upgrade Go version to v1.18 (#1925) 2022-08-17 04:35:50 +00:00
Yuki IwaiandGitHub 36235df030 Upgrade Python and Pytorch versions for some examples (#1906) 2022-06-28 11:50:34 +00:00
Rishit DagliandGitHub be289c355d Linting for K8s YAML files (#1901)
* Add yamllint checking

* Update yamllint command

* Revert changes to charmed

* Create new workflow for yamllint

* Create a script to verify installation and run yamllint

* Add `make yamllint`

* Update lint workflow
2022-06-22 15:50:26 +00:00
Yuki IwaiandGitHub 2ea34d2d4a Migrate kubeflow-katib-presubmit to GitHub Actions (#1882)
* migrate test-infra to GitHub Actions

* change python base image to python:3.9-slim

* move from minikube to kind

* separate darts container images by device type

* run e2e test with multi kubernetes version

* disble to deploy katib-ui by default

* change kind kubernetes cluster version

* fix update-images.sh

* fix shellcheck

* fix script to setup katib

* split enas, darts and tf-mnist-with-summaries with trial images

* specicy experiments in pytorch-mnist-e2e-test

* reduce storage size for mysql

* fix trial image name for enas and darts

* fix trial image name for file-metrics-collector-with-json-format

* change kubernetes versions

* do not run e2e test on push master branch

* remove backoffLimit field in examples
2022-06-06 04:50:29 +00:00
Yuki IwaiandGitHub a7b30bd40f Add semicolon when using command command in Makefile (#1885)
* add a semicolon when using the `command` command in Makefile to avoid the `make: command: Command not found` error.

* fix shellcheck
2022-06-04 20:43:27 +00:00
Yuki IwaiandGitHub 1611db0f37 Upgrade the kubebuilder to v3.2.0 and Kubernetes Go libraries to v1.22.2 (#1861)
* upgrade kubebuilder version from v2.3.0 to v3.2.0

* fix envtest for experiment-controller

* fix suite test

To avoid the `timeout waiting for process kube-apiserver to stop` error, we must use the `context.WithCancel`.
Ref: https://github.com/kubernetes-sigs/controller-runtime/issues/1571#issuecomment-945535598

* update Go version to v1.17 in kubeflow-katib-presubmit

To avoid the `../../../../pkg/mod/k8s.io/[email protected].2/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)` error,
we must use Go v1.16 or later, but as described in https://github.com/kubeflow/training-operator/issues/1581,
we do not have permission to update `public.ecr.aws/j1r0q0g6/kubeflow-testing:latest` so we need to update it in this.
2022-05-22 18:33:00 +00:00
Yuki IwaiandGitHub 152f19185e Add shellcheck (#1857)
* add shellcheck

* fix /test/e2e/v1beta1/scripts/run-e2e-experiment.sh

* fix test/e2e/v1beta1/scripts/setup-katib.sh

* fix pkg/apis/manager/[v1beta1|health]/build.sh

* fix scripts/v1beta1/deploy.sh

* fix scripts/v1beta1/release.sh

* fix scripts/v1beta1/update-images.sh

* fix scripts/v1beta1/undeploy.sh

* fix hack/update-openapigen.sh

* update boilerplate

* fix hack/gen-python-sdk/gen-sdk.sh

* fix hack/update-codegen.sh

* fix hack/update-mockgen.sh

* use /usr/bin/env bash

* add path to update-boilerplate.sh

* fix script to update boilerplate

* fix comment
2022-05-03 01:15:00 +00:00
Andrey VelichkevichandGitHub 23258c917b Update Go version to 1.17 (#1683)
* Use Go 1.17 version

* Fix code generator import

* Change after review

* Run lint

* Use go install for lint
2021-09-28 09:05:11 -07:00
ca6419ba90 Use golangci-lint as linter for Go (#1671)
* use golangci-lint as linter for Go instead of golint

* Update hack/verify-golangci-lint.sh

Co-authored-by: Andrey Velichkevich <[email protected]>

* specify golangci-lint version

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix echo comment

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix echo comment

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix lint

* fix gofmt

* fix generated codes

* close the connection for early stopping without using defer

* do not create or delete any resources within gomega.Eventually

* add condition to return error in getKatibJob func

* remove comment out lines

* simplify some codes

Co-authored-by: Andrey Velichkevich <[email protected]>

* remove an unnecessary variable

Co-authored-by: Andrey Velichkevich <[email protected]>

* fix golangci-lint error

Co-authored-by: Andrey Velichkevich <[email protected]>

Co-authored-by: Andrey Velichkevich <[email protected]>
2021-09-23 23:09:37 -07:00
f7248c5cf3 Reimplement katib-cert-generator in Go (#1662)
* add cert-generator command

* go mod tidy

* fix gofmt lint check

* fix unittest for katib-cert-generator

* remove unnecessary test code

* fix comment

* review: fix kubeClient

* review: stop to use k8s.io/utils

* review: delete containers[].securityContext

* review: change directory name for cert-generator

* review: fix const

Co-authored-by: andreyvelich <[email protected]>

* review: stop to use k8s.io/utils

Co-authored-by: andreyvelich <[email protected]>

* review: delete containers[].securityContext

* review: change directory name for cert-generator

* review: fix const

Co-authored-by: andreyvelich <[email protected]>

* review: take webhook domain as consts

* review: keep the name testDescription and err

* review: do not try to patch webhook configuration in many times

* review: fix some functions to generate cert

* review: add comments

Co-authored-by: andreyvelich <[email protected]>

* review: remove v1beta1 from admissionReviewVersions in ValidatingWebhookConfiguration and MutatingWebhookConfiguration

* fix comments

* review: remove the securityContext field

Co-authored-by: andreyvelich <[email protected]>
2021-09-14 19:01:32 -07:00
Andrey VelichkevichandGitHub 3b98edea0b Add mockgen version to gen script (#1658)
* Add mockgen version to gen script

* Rename to update-mockgen
2021-09-07 05:09:39 -07:00
e09ea1f155 SDK: change list apis to return objects as default (#1630)
* SDK: change list apis to return objects as default

- change list_trials, list_experiments to return list of objects as
 a default
- also, give 'in_short' parameter for who wants only name and status
 as before

* [enh]: change return type from List[dict] to List[V1beta1Experiment]

* [enh]: deserialize dict to katib's custom class

* [docs]: refactor KatibClient docs

* change deserialize method location to utils

* remove useless import

* Add objects necessary to deserilization in swagger

* use fakeresponse rather than duplicating codes

* Update sdk/python/v1beta1/kubeflow/katib/utils/utils.py

Co-authored-by: Andrey Velichkevich <[email protected]>

* Update sdk/python/v1beta1/kubeflow/katib/utils/utils.py

Co-authored-by: Andrey Velichkevich <[email protected]>

Co-authored-by: Andrey Velichkevich <[email protected]>
2021-08-30 22:42:03 -07:00
Andrey VelichkevichandGitHub a59cd47f1d Update Katib SDK with OpenAPI generator (#1572)
* Use openapi JAR

* Remove test from SDK

* Use k8s>=12.0 version
2021-07-29 08:35:19 -07:00
Yannis ZarkadasandGitHub ffc3b17b98 Katib manifests fixes for 1.3 (#1502)
* cert-generator: Disable client-side validation

Closes https://github.com/kubeflow/katib/issues/1500

Signed-off-by: Yannis Zarkadas <[email protected]>

* manifests: Generate valid VirtualService by default

Signed-off-by: Yannis Zarkadas <[email protected]>

* manifests: Disable sidecar injection for all components

Signed-off-by: Yannis Zarkadas <[email protected]>

* manifests: Remove erroneous storageClassName from PVC

Signed-off-by: Yannis Zarkadas <[email protected]>

* manifests: Add katib-with-kubeflow-cert-manager overlay

Signed-off-by: Yannis Zarkadas <[email protected]>
2021-03-31 04:39:18 -07:00
Andrey VelichkevichandGitHub 558e1c5aeb Add script to update boilerplate (#1491)
* Update boilerplate for clients

* Modify not format boilerplate

* Modify boilerplate script for go files

* Update boilerplate manually for go files

* Modify script

* Generate boilerplate for Go files

* Add script for Python files

* Generate boilerplate for the Py files

* Include shell

* Generate boilerplate for shell scripts

* Add to makefile

* Fix comments

* Change comments
2021-03-19 23:48:17 -07:00
Andrey VelichkevichandGitHub b593d69b3e Remove completed TODOs for Katib config (#1459) 2021-03-16 00:21:15 -07:00
3a85423198 Disable dynamic creation for admission hooks and update dependencies (#1450)
* Update all dependencies to the latest versions
Add cert generator for the webhooks
Add manifests for the webhooks

* Modify Dockerfile for manager

* Remove comments

* Update Dockerfiles for Go images

* Add signerName: kubernetes.io/kube-apiserver-client to csr
Update roles for controller RBAC
Changes after review

* Fix not installed CRD error

* Update scripts

* Revert operator changes

* Describe controller pod in test

* Add log line to test

* Move kubectl version

* Change csr version to v1beta1

* Remove log

* Change signerName to kubernetes.io/kubelet-serving

* Modify common name

Co-authored-by: Yuki Iwai <[email protected]>

* Add env variable to init container

Co-authored-by: Yuki Iwai <[email protected]>

* Get namespace from env

Co-authored-by: Yuki Iwai <[email protected]>

* Remove quotes

* Remove spaces

* Run cert generator script from the Job

* Modify new ui Dockerfile

* Disable Actions on PR

* Modify setup Katib script

* Fix PODNUM

* Remove imagePullPolicy from PyTorch and TFJob examples

* Disable Pytorch examples in e2e

* Add sleep to e2e test

* Activate Actions

* Disable actions

Co-authored-by: Yuki Iwai <[email protected]>
2021-03-06 09:29:49 -08:00
Andrey VelichkevichandGitHub 1d059bfe61 Migrate to Go modules (#1438) 2021-02-18 10:04:52 -08:00
Andrey VelichkevichandGitHub 2e226de7e5 Remove v1alpha3 version (#1396)
* Remove v1alpha3 files

* Modify SDK

* Change dict() to object
2020-11-30 06:48:50 -08:00
Andrey VelichkevichandGitHub c371d3e8f3 feat: Ignore pb files in update gofmt (#1340)
Update travis nvm version to 12.18.1
Ignore .pb files in gofmt
2020-09-16 19:38:46 -07:00
Andrey VelichkevichandGitHub 2992c5706f Upload python SDK version (#1335)
* Upload 0.0.4 SDK version

* Fix doc links

* Fix links in README

* Modify tables

* Fix link

* Remove

* Modify client and gen script

* Update version to 0.0.5

* Run CI

* Add Katib client to init
2020-09-15 02:42:07 -07:00
Andrey VelichkevichandGitHub f200a2828d Update generate script with SDK (#1323)
* Update generate script

* Capitalise API

* Remove verbose
2020-09-04 13:47:42 -07:00
Xu XiaoandGitHub 6c07d26b78 [python sdk] add v1beta1 models (#1252)
* [python sdk] add v1beta1 models

* upgrade version of python SDK to 0.0.3

* remove v1Alpha3 python sdk

* add some python models manually: v1Time and V1UnstructuredUnstructured

* bring back v1alpha3

* create separate python sdk for v1alpha3 and v1beta1

* move on

* release pkg on pypi.org

* remove dist files

* refine
2020-08-18 03:11:32 -07:00
Xu XiaoandGitHub 4987218fdf add clientset/lister/informer generation (#1194)
* adapt v1beta1

* add resources for v1alpha3

* fix

* refine update-codegen script

* add katib apiVersion as prefix of swagger version
2020-06-10 08:08:51 -07:00
Andrey VelichkevichandGitHub 70a0fe3e73 Katib v1beta1 version (#1197)
* Add v1beta1 version

* Swagger for v1alpha3 and v1beta1 versions
Fix format in bash scripts

* Change make build to make buildv1alpha3

* Add folder path to python test

* Fix folder in python test

* Add goptuna and darts suggestions to check-katib-ready

* Disable custom metrics collector e2e in v1beta1
2020-05-27 18:54:02 -07:00
Masashi SHIBATAandGitHub 3e61406b4e Bump the Go version up to 1.14.2 for Travis CI (#1132) 2020-04-10 07:51:47 -07:00
Xu XiaoandGitHub a908eca534 continue (#1054) 2020-02-13 01:12:35 -08:00