Files
a13b11d25b Upgrade klog to v2 (#2470)
* Upgrade klog dependency to v2

Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>

* fix: fix conflict with k8s upate

Signed-off-by: Xinmin Du <[email protected]>

---------

Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Du Xinmin <[email protected]>
Co-authored-by: Xinmin Du <[email protected]>
2025-01-15 05:22:12 +00:00

167 lines
4.8 KiB
Go

/*
Copyright 2022 The Kubeflow Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package mysql
import (
"database/sql"
"fmt"
"os"
"time"
_ "github.com/go-sql-driver/mysql"
"k8s.io/klog/v2"
v1beta1 "github.com/kubeflow/katib/pkg/apis/manager/v1beta1"
"github.com/kubeflow/katib/pkg/db/v1beta1/common"
"github.com/kubeflow/katib/pkg/util/v1beta1/env"
)
const (
dbDriver = "mysql"
//dbNameTmpl = "root:%s@tcp(%s:%s)/%s?timeout=5s"
dbNameTmpl = "%s:%s@tcp(%s:%s)/%s?timeout=5s"
mysqlTimeFmt = "2006-01-02 15:04:05.999999"
)
type dbConn struct {
db *sql.DB
}
func getDbName() string {
dbPassEnvName := common.DBPasswordEnvName
dbPass := os.Getenv(dbPassEnvName)
dbUser := env.GetEnvOrDefault(
common.DBUserEnvName, common.DefaultMySQLUser)
dbHost := env.GetEnvOrDefault(
common.MySQLDBHostEnvName, common.DefaultMySQLHost)
dbPort := env.GetEnvOrDefault(
common.MySQLDBPortEnvName, common.DefaultMySQLPort)
dbName := env.GetEnvOrDefault(common.MySQLDatabase,
common.DefaultMySQLDatabase)
return fmt.Sprintf(dbNameTmpl, dbUser, dbPass, dbHost, dbPort, dbName)
}
func NewDBInterface(connectTimeout time.Duration) (common.KatibDBInterface, error) {
db, err := common.OpenSQLConn(dbDriver, getDbName(), common.ConnectInterval, connectTimeout)
if err != nil {
return nil, fmt.Errorf("DB open failed: %v", err)
}
return &dbConn{db: db}, nil
}
func (d *dbConn) RegisterObservationLog(trialName string, observationLog *v1beta1.ObservationLog) error {
sqlQuery := "INSERT INTO observation_logs (trial_name, time, metric_name, value) VALUES "
values := []interface{}{}
for _, mlog := range observationLog.MetricLogs {
if mlog.TimeStamp == "" {
continue
}
t, err := time.Parse(time.RFC3339Nano, mlog.TimeStamp)
if err != nil {
return fmt.Errorf("Error parsing start time %s: %v", mlog.TimeStamp, err)
}
sqlTimeStr := t.UTC().Format(mysqlTimeFmt)
sqlQuery += "(?, ?, ?, ?),"
values = append(values, trialName, sqlTimeStr, mlog.Metric.Name, mlog.Metric.Value)
}
sqlQuery = sqlQuery[0 : len(sqlQuery)-1]
// Prepare the statement
stmt, err := d.db.Prepare(sqlQuery)
if err != nil {
return fmt.Errorf("Prepare SQL statement failed: %v", err)
}
// Close the statement
defer stmt.Close()
// Execute INSERT
_, err = stmt.Exec(values...)
if err != nil {
return fmt.Errorf("Execute SQL INSERT failed: %v", err)
}
return nil
}
func (d *dbConn) DeleteObservationLog(trialName string) error {
_, err := d.db.Exec("DELETE FROM observation_logs WHERE trial_name = ?", trialName)
return err
}
func (d *dbConn) GetObservationLog(trialName string, metricName string, startTime string, endTime string) (*v1beta1.ObservationLog, error) {
qfield := []interface{}{trialName}
qstr := ""
if metricName != "" {
qstr += " AND metric_name = ?"
qfield = append(qfield, metricName)
}
if startTime != "" {
s_time, err := time.Parse(time.RFC3339Nano, startTime)
if err != nil {
return nil, fmt.Errorf("Error parsing start time %s: %v", startTime, err)
}
formattedStartTime := s_time.UTC().Format(mysqlTimeFmt)
qstr += " AND time >= ?"
qfield = append(qfield, formattedStartTime)
}
if endTime != "" {
e_time, err := time.Parse(time.RFC3339Nano, endTime)
if err != nil {
return nil, fmt.Errorf("Error parsing completion time %s: %v", endTime, err)
}
formattedEndTime := e_time.UTC().Format(mysqlTimeFmt)
qstr += " AND time <= ?"
qfield = append(qfield, formattedEndTime)
}
rows, err := d.db.Query("SELECT time, metric_name, value FROM observation_logs WHERE trial_name = ?"+qstr+" ORDER BY time",
qfield...)
if err != nil {
return nil, fmt.Errorf("Failed to get ObservationLogs %v", err)
}
// Close the rows
defer rows.Close()
result := &v1beta1.ObservationLog{
MetricLogs: []*v1beta1.MetricLog{},
}
for rows.Next() {
var mname, mvalue, sqlTimeStr string
err := rows.Scan(&sqlTimeStr, &mname, &mvalue)
if err != nil {
klog.Errorf("Error scanning log: %v", err)
continue
}
ptime, err := time.Parse(mysqlTimeFmt, sqlTimeStr)
if err != nil {
klog.Errorf("Error parsing time %s: %v", sqlTimeStr, err)
continue
}
timeStamp := ptime.UTC().Format(time.RFC3339Nano)
result.MetricLogs = append(result.MetricLogs, &v1beta1.MetricLog{
TimeStamp: timeStamp,
Metric: &v1beta1.Metric{
Name: mname,
Value: mvalue,
},
})
}
return result, nil
}