Files
2025-04-21 20:55:59 -07:00

129 lines
4.7 KiB
Go

package util
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
api "github.com/ray-project/kuberay/proto/go_client"
)
var apiJobNewCluster = &api.RayJob{
Name: "test",
Namespace: "test",
User: "test",
Entrypoint: "python /home/ray/samples/sample_code.py",
Metadata: map[string]string{
"job_submission_id": "123",
},
RuntimeEnv: "pip:\n - requests==2.26.0\n - pendulum==2.1.2\nenv_vars:\n counter_name: \"test_counter\"\n",
ShutdownAfterJobFinishes: true,
ClusterSpec: rayCluster.ClusterSpec,
ActiveDeadlineSeconds: 120,
}
var apiJobExistingCluster = &api.RayJob{
Name: "test",
Namespace: "test",
User: "test",
Entrypoint: "python /home/ray/samples/sample_code.py",
Metadata: map[string]string{
"job_submission_id": "123",
},
RuntimeEnv: "pip:\n - requests==2.26.0\n - pendulum==2.1.2\nenv_vars:\n counter_name: \"test_counter\"\n",
ClusterSelector: map[string]string{
RayClusterUserLabelKey: "test",
},
}
var apiJobExistingClusterSubmitter = &api.RayJob{
Name: "test",
Namespace: "test",
User: "test",
Entrypoint: "python /home/ray/samples/sample_code.py",
Metadata: map[string]string{
"job_submission_id": "123",
},
RuntimeEnv: "pip:\n - requests==2.26.0\n - pendulum==2.1.2\nenv_vars:\n counter_name: \"test_counter\"\n",
ClusterSelector: map[string]string{
RayClusterUserLabelKey: "test",
},
JobSubmitter: &api.RayJobSubmitter{
Image: "image",
Cpu: "400m",
Memory: "150Mi",
},
EntrypointNumCpus: 2,
}
var apiJobExistingClusterSubmitterBadParams = &api.RayJob{
Name: "test",
Namespace: "test",
User: "test",
Entrypoint: "python /home/ray/samples/sample_code.py",
Metadata: map[string]string{
"job_submission_id": "123",
},
RuntimeEnv: "pip:\n - requests==2.26.0\n - pendulum==2.1.2\nenv_vars:\n counter_name: \"test_counter\"\n",
ClusterSelector: map[string]string{
RayClusterUserLabelKey: "test",
},
JobSubmitter: &api.RayJobSubmitter{
Image: "image",
Memory: "1GB",
},
EntrypointNumCpus: 2,
}
func TestBuildRayJob(t *testing.T) {
// Test request with cluster creation
job, err := NewRayJob(apiJobNewCluster, map[string]*api.ComputeTemplate{"foo": &template})
require.NoError(t, err)
assert.Equal(t, "test", job.ObjectMeta.Name)
assert.Equal(t, "test", job.ObjectMeta.Namespace)
assert.Len(t, job.ObjectMeta.Labels, 4)
assert.Equal(t, "test", job.ObjectMeta.Labels[RayClusterUserLabelKey])
assert.Len(t, job.ObjectMeta.Annotations, 1)
assert.Greater(t, len(job.Spec.RuntimeEnvYAML), 1)
assert.Len(t, job.Spec.Metadata, 1)
assert.Nil(t, job.Spec.ClusterSelector)
assert.NotNil(t, job.Spec.RayClusterSpec)
assert.Equal(t, 120, int(*job.Spec.ActiveDeadlineSeconds))
// Test request without cluster creation
job, err = NewRayJob(apiJobExistingCluster, map[string]*api.ComputeTemplate{"foo": &template})
require.NoError(t, err)
assert.Equal(t, "test", job.ObjectMeta.Name)
assert.Equal(t, "test", job.ObjectMeta.Namespace)
assert.Len(t, job.ObjectMeta.Labels, 4)
assert.Equal(t, "test", job.ObjectMeta.Labels[RayClusterUserLabelKey])
assert.Greater(t, len(job.Spec.RuntimeEnvYAML), 1)
assert.NotNil(t, job.Spec.ClusterSelector)
assert.Nil(t, job.Spec.RayClusterSpec)
assert.Nil(t, job.Spec.SubmitterPodTemplate)
// Test request without cluster creation with submitter
job, err = NewRayJob(apiJobExistingClusterSubmitter, map[string]*api.ComputeTemplate{"foo": &template})
require.NoError(t, err)
assert.Equal(t, "test", job.ObjectMeta.Name)
assert.Equal(t, "test", job.ObjectMeta.Namespace)
assert.Len(t, job.ObjectMeta.Labels, 4)
assert.Equal(t, "test", job.ObjectMeta.Labels[RayClusterUserLabelKey])
assert.Greater(t, len(job.Spec.RuntimeEnvYAML), 1)
assert.NotNil(t, job.Spec.ClusterSelector)
assert.Nil(t, job.Spec.RayClusterSpec)
assert.InEpsilon(t, float32(2), job.Spec.EntrypointNumCpus, 1e-9 /*epsilon*/)
assert.NotNil(t, job.Spec.SubmitterPodTemplate)
assert.Equal(t, "ray-job-submitter", job.Spec.SubmitterPodTemplate.Spec.Containers[0].Name)
assert.Equal(t, "image", job.Spec.SubmitterPodTemplate.Spec.Containers[0].Image)
assert.Equal(t, "400m", job.Spec.SubmitterPodTemplate.Spec.Containers[0].Resources.Limits.Cpu().String())
assert.Equal(t, "150Mi", job.Spec.SubmitterPodTemplate.Spec.Containers[0].Resources.Limits.Memory().String())
assert.Equal(t, "400m", job.Spec.SubmitterPodTemplate.Spec.Containers[0].Resources.Requests.Cpu().String())
assert.Equal(t, "150Mi", job.Spec.SubmitterPodTemplate.Spec.Containers[0].Resources.Requests.Memory().String())
// Test request without cluster creation with submitter bad parameters
_, err = NewRayJob(apiJobExistingClusterSubmitterBadParams, map[string]*api.ComputeTemplate{"foo": &template})
require.Error(t, err)
}