Files
kuberay/ray-operator/controllers/ray/networkpolicy_controller_unit_test.go
1df0651f91 [Feature] Add NetworkIsolation support to RayClusters (#4638)
* [Feature] Add NetworkIsolation support to RayClusters

Co-authored-by: Pat O'Connor <[email protected]>
Co-authored-by: Bryan Keane <[email protected]>

* add feature gate reg to integration tests + removed redundant if err

Signed-off-by: Pat O'Connor <[email protected]>

* separate function for head and base ingress rules

Signed-off-by: Pat O'Connor <[email protected]>

* logger updates as per review

Signed-off-by: Pat O'Connor <[email protected]>

* adjust DNS egress rule to allow all port 53 egress

Signed-off-by: Pat O'Connor <[email protected]>

* resolve helm chart CI failure

Signed-off-by: Pat O'Connor <[email protected]>

* restrict KubeRay rule via NamespaceSelector

Signed-off-by: Pat O'Connor <[email protected]>

* check if update is necessary on NP via DeepEqual

Signed-off-by: Pat O'Connor <[email protected]>

* prevent same-name NP mod + add namespace fallback to default

Signed-off-by: Pat O'Connor <[email protected]>

* add missing rayStartParams ports to custom ports example

Signed-off-by: Pat O'Connor <[email protected]>

* emit warning when existing NP conflicts with new one via name + fix test

Signed-off-by: Pat O'Connor <[email protected]>

* remove redundant samples + add new samples

Signed-off-by: Pat O'Connor <[email protected]>

* remove permissive pod selector rule + test updates

Signed-off-by: Pat O'Connor <[email protected]>

* prop labels to jobsubmitter for networkpolicy rule

Signed-off-by: Pat O'Connor <[email protected]>

* Add opt-in ALLOW_ALL_RAYJOB_SUBMITTERS env var for broad submitter ingress on standalone RayClusters

Signed-off-by: Pat O'Connor <[email protected]>

* updated API and config to fix CI failures

Signed-off-by: Pat O'Connor <[email protected]>

* Moved label prop to getSummitterTemplate + review changes

Signed-off-by: Pat O'Connor <[email protected]>

* Review feedback: failed deletion event + reconcile on dupe + nits

Signed-off-by: Pat O'Connor <[email protected]>

* use rayStartParams for ports + review nits

Signed-off-by: Pat O'Connor <[email protected]>

* test fix + convert constants to CamelCase

Signed-off-by: Pat O'Connor <[email protected]>

* helm updates + check if RayCluster is externally managed

Signed-off-by: Pat O'Connor <[email protected]>

* API updates per review + autoscaling egress rule

Signed-off-by: Pat O'Connor <[email protected]>

* Use standard lib for CIDR + use logConstructor consistently

Signed-off-by: Pat O'Connor <[email protected]>

* Use EndpointSlice IPs for API server egress rule

Signed-off-by: Pat O'Connor <[email protected]>

* Deduplicates ports + peers across EndpointSlices in egress rules

Signed-off-by: Pat O'Connor <[email protected]>

* Remove operator namespace fallback and prop error if namespace not found

Signed-off-by: Pat O'Connor <[email protected]>

* Remove patch verb for networkpolicies

Signed-off-by: Pat O'Connor <[email protected]>

* Remove client port rule for operator

Signed-off-by: Pat O'Connor <[email protected]>

* Add reconcileConcurrency and GenerationChangedPredicate to NetworkPolicy controller setup

Signed-off-by: Pat O'Connor <[email protected]>

* solve 3 points, close to merge

Signed-off-by: Future-Outlier <[email protected]>

* helper

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* CI failure fixes after DNS logic removal

Signed-off-by: Pat O'Connor <[email protected]>

* Revert "helper"

This reverts commit 26c4053ae5775517f60a01cc4fb9457265d832c4.

* Skip networkpolicy integration test when missing namespace

Signed-off-by: Pat O'Connor <[email protected]>

* Normalize defaulted NetworkPolicy ports before comparing

Signed-off-by: Pat O'Connor <[email protected]>

* Drop network policy integration tests pending followup e2e

Signed-off-by: Pat O'Connor <[email protected]>

* Remove operator namespace ingress rule

Signed-off-by: Pat O'Connor <[email protected]>

* networkpolicy: separate head/worker custom rules in API Replace the flat ingressRules/egressRules on NetworkIsolationConfig with per-role head/worker sub-structs.Since the API has not shipped yet, this avoids locking in a shared-only design that would require a backward-compatible migration later. Head and workers have fundamentally different security profiles — head needs external access (dashboard, submitter, Prometheus) while workers typically need outbound access (S3, model registries). A shared-only API forces users to over-permit workers just to allow access to the head. New API shape:   networkIsolation:     mode: DenyAll     head:       ingressRules: [...]       egressRules: [...]     worker:       ingressRules: [...]       egressRules: [...]

Co-authored-by: Cursor <[email protected]>

* NetworkIsolation API change cleanup

Signed-off-by: Pat O'Connor <[email protected]>

* Unit tests to ensure custom policies don't leak between head and worker

Signed-off-by: Pat O'Connor <[email protected]>

* Sample comment indendation and removal of operator rule from API docs

Signed-off-by: Pat O'Connor <[email protected]>

* Indent update to pass linter

Signed-off-by: Pat O'Connor <[email protected]>

* Additional review nits - comments etc

Signed-off-by: Pat O'Connor <[email protected]>

* Remove redundant comments in controller code

Signed-off-by: Pat O'Connor <[email protected]>

---------

Signed-off-by: Pat O'Connor <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Laura Fitzgerald <[email protected]>
Co-authored-by: Bryan Keane <[email protected]>
Co-authored-by: Future-Outlier <[email protected]>
Co-authored-by: Cursor <[email protected]>
2026-06-23 10:03:32 -04:00

507 lines
19 KiB
Go

package ray
import (
"strings"
"testing"
. "github.com/onsi/ginkgo/v2"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1"
networkingv1 "k8s.io/api/networking/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/utils/ptr"
clientFake "sigs.k8s.io/controller-runtime/pkg/client/fake"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
rayv1 "github.com/ray-project/kuberay/ray-operator/apis/ray/v1"
"github.com/ray-project/kuberay/ray-operator/controllers/ray/utils"
"github.com/ray-project/kuberay/ray-operator/pkg/features"
)
var (
testNetworkPolicyController *NetworkPolicyController
testRayClusterBasic *rayv1.RayCluster
testRayClusterDenyAllIngress *rayv1.RayCluster
testRayClusterDenyAllEgress *rayv1.RayCluster
testRayClusterWithRayJob *rayv1.RayCluster
)
func setupNetworkPolicyTest(t *testing.T) {
t.Helper()
features.SetFeatureGateDuringTest(t, features.RayClusterNetworkIsolation, true)
logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
testScheme := runtime.NewScheme()
testNetworkPolicyController = &NetworkPolicyController{
Scheme: testScheme,
Client: clientFake.NewClientBuilder().
WithScheme(testScheme).
Build(),
}
// Basic cluster — DenyAll mode (default).
testRayClusterBasic = &rayv1.RayCluster{
ObjectMeta: metav1.ObjectMeta{
Name: "test-cluster",
Namespace: "default",
},
Spec: rayv1.RayClusterSpec{
NetworkIsolation: &rayv1.NetworkIsolationConfig{
Mode: ptr.To(rayv1.NetworkIsolationDenyAll),
},
HeadGroupSpec: rayv1.HeadGroupSpec{
RayStartParams: map[string]string{},
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{
{Name: "ray-head", Image: "rayproject/ray:latest"},
},
},
},
},
},
}
// Cluster configured with DenyAllIngress mode.
testRayClusterDenyAllIngress = &rayv1.RayCluster{
ObjectMeta: metav1.ObjectMeta{
Name: "test-cluster-ingress",
Namespace: "default",
},
Spec: rayv1.RayClusterSpec{
NetworkIsolation: &rayv1.NetworkIsolationConfig{
Mode: ptr.To(rayv1.NetworkIsolationDenyAllIngress),
},
HeadGroupSpec: rayv1.HeadGroupSpec{
RayStartParams: map[string]string{},
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{
{Name: "ray-head", Image: "rayproject/ray:latest"},
},
},
},
},
},
}
// Cluster configured with DenyAllEgress mode.
testRayClusterDenyAllEgress = &rayv1.RayCluster{
ObjectMeta: metav1.ObjectMeta{
Name: "test-cluster-egress",
Namespace: "default",
},
Spec: rayv1.RayClusterSpec{
NetworkIsolation: &rayv1.NetworkIsolationConfig{
Mode: ptr.To(rayv1.NetworkIsolationDenyAllEgress),
},
HeadGroupSpec: rayv1.HeadGroupSpec{
RayStartParams: map[string]string{},
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{
{Name: "ray-head", Image: "rayproject/ray:latest"},
},
},
},
},
},
}
// Cluster owned by a RayJob (K8sJobMode — has a standalone submitter pod).
testRayClusterWithRayJob = &rayv1.RayCluster{
ObjectMeta: metav1.ObjectMeta{
Name: "test-cluster-rayjob",
Namespace: "default",
Labels: map[string]string{
utils.RayJobSubmissionModeLabelKey: string(rayv1.K8sJobMode),
},
OwnerReferences: []metav1.OwnerReference{
{
APIVersion: "ray.io/v1",
Kind: "RayJob",
Name: "test-job",
UID: "12345",
Controller: ptr.To(true),
},
},
},
Spec: rayv1.RayClusterSpec{
NetworkIsolation: &rayv1.NetworkIsolationConfig{
Mode: ptr.To(rayv1.NetworkIsolationDenyAll),
},
HeadGroupSpec: rayv1.HeadGroupSpec{
RayStartParams: map[string]string{},
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{
{Name: "ray-head", Image: "rayproject/ray:latest"},
},
},
},
},
},
}
}
// TestBuildHeadNetworkPolicy_DenyAll verifies the head NetworkPolicy in default DenyAll mode.
func TestBuildHeadNetworkPolicy_DenyAll(t *testing.T) {
setupNetworkPolicyTest(t)
policy := testNetworkPolicyController.buildHeadNetworkPolicy(testRayClusterBasic, rayv1.NetworkIsolationDenyAll)
assert.Equal(t, "test-cluster-head", policy.Name)
assert.Equal(t, "default", policy.Namespace)
// Labels must identify the cluster and the operator.
expectedLabels := map[string]string{
utils.RayClusterLabelKey: testRayClusterBasic.Name,
utils.KubernetesApplicationNameLabelKey: utils.ApplicationName,
utils.KubernetesCreatedByLabelKey: utils.ComponentName,
}
assert.Equal(t, expectedLabels, policy.Labels)
// PodSelector must target head pods of this cluster.
assert.Equal(t, map[string]string{
utils.RayClusterLabelKey: "test-cluster",
utils.RayNodeTypeLabelKey: string(rayv1.HeadNode),
}, policy.Spec.PodSelector.MatchLabels)
// DenyAll restricts both directions.
assert.Contains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeIngress)
assert.Contains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeEgress)
// 1 base ingress rule: intra-cluster only (operator access removed, injected via webhook).
assert.Len(t, policy.Spec.Ingress, 1)
// 1 base egress rule: intra-cluster only (DNS no longer baked in).
assert.Len(t, policy.Spec.Egress, 1)
}
// TestBuildHeadNetworkPolicy_DenyAllIngress verifies that DenyAllIngress omits the Egress policy type.
func TestBuildHeadNetworkPolicy_DenyAllIngress(t *testing.T) {
setupNetworkPolicyTest(t)
policy := testNetworkPolicyController.buildHeadNetworkPolicy(testRayClusterDenyAllIngress, rayv1.NetworkIsolationDenyAllIngress)
assert.Contains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeIngress)
assert.NotContains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeEgress)
assert.Len(t, policy.Spec.Ingress, 1)
assert.Empty(t, policy.Spec.Egress)
}
// TestBuildHeadNetworkPolicy_DenyAllEgress verifies that DenyAllEgress only restricts egress.
func TestBuildHeadNetworkPolicy_DenyAllEgress(t *testing.T) {
setupNetworkPolicyTest(t)
policy := testNetworkPolicyController.buildHeadNetworkPolicy(testRayClusterDenyAllEgress, rayv1.NetworkIsolationDenyAllEgress)
assert.NotContains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeIngress)
assert.Contains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeEgress)
assert.Empty(t, policy.Spec.Ingress)
assert.Len(t, policy.Spec.Egress, 1)
}
// TestBuildWorkerNetworkPolicy_DenyAll verifies the worker NetworkPolicy in DenyAll mode.
func TestBuildWorkerNetworkPolicy_DenyAll(t *testing.T) {
setupNetworkPolicyTest(t)
policy := testNetworkPolicyController.buildWorkerNetworkPolicy(testRayClusterBasic, rayv1.NetworkIsolationDenyAll)
assert.Equal(t, "test-cluster-workers", policy.Name)
assert.Equal(t, "default", policy.Namespace)
// Labels must identify the cluster and the operator.
expectedLabels := map[string]string{
utils.RayClusterLabelKey: testRayClusterBasic.Name,
utils.KubernetesApplicationNameLabelKey: utils.ApplicationName,
utils.KubernetesCreatedByLabelKey: utils.ComponentName,
}
assert.Equal(t, expectedLabels, policy.Labels)
// PodSelector must target worker pods of this cluster.
assert.Equal(t, map[string]string{
utils.RayClusterLabelKey: "test-cluster",
utils.RayNodeTypeLabelKey: string(rayv1.WorkerNode),
}, policy.Spec.PodSelector.MatchLabels)
assert.Contains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeIngress)
assert.Contains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeEgress)
// Workers only allow intra-cluster ingress (no Ports = all ports).
require.Len(t, policy.Spec.Ingress, 1)
require.Len(t, policy.Spec.Ingress[0].From, 1)
assert.Equal(t, map[string]string{utils.RayClusterLabelKey: "test-cluster"},
policy.Spec.Ingress[0].From[0].PodSelector.MatchLabels)
assert.Empty(t, policy.Spec.Ingress[0].Ports)
// 1 base egress rule: intra-cluster only (DNS no longer baked in).
assert.Len(t, policy.Spec.Egress, 1)
}
// TestBuildWorkerNetworkPolicy_DenyAllIngress verifies no egress is added for DenyAllIngress mode.
func TestBuildWorkerNetworkPolicy_DenyAllIngress(t *testing.T) {
setupNetworkPolicyTest(t)
policy := testNetworkPolicyController.buildWorkerNetworkPolicy(testRayClusterDenyAllIngress, rayv1.NetworkIsolationDenyAllIngress)
assert.Contains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeIngress)
assert.NotContains(t, policy.Spec.PolicyTypes, networkingv1.PolicyTypeEgress)
assert.Len(t, policy.Spec.Ingress, 1)
assert.Empty(t, policy.Spec.Egress)
}
// TestBuildWorkerNetworkPolicy_CustomIngressRules verifies that custom Worker.IngressRules are appended to the worker policy.
func TestBuildWorkerNetworkPolicy_CustomIngressRules(t *testing.T) {
setupNetworkPolicyTest(t)
customPort := intstr.FromInt32(9999)
tcpProto := corev1.ProtocolTCP
cluster := testRayClusterBasic.DeepCopy()
cluster.Spec.NetworkIsolation.Worker = &rayv1.NetworkPolicyRules{
IngressRules: []networkingv1.NetworkPolicyIngressRule{
{
Ports: []networkingv1.NetworkPolicyPort{
{Protocol: &tcpProto, Port: &customPort},
},
},
},
}
policy := testNetworkPolicyController.buildWorkerNetworkPolicy(cluster, rayv1.NetworkIsolationDenyAll)
// 1 base intra-cluster + 1 custom = 2.
require.Len(t, policy.Spec.Ingress, 2)
require.Len(t, policy.Spec.Ingress[1].Ports, 1)
assert.Equal(t, &customPort, policy.Spec.Ingress[1].Ports[0].Port)
}
// TestBuildBaseIngressRules verifies the shared intra-cluster ingress rule used by both head and workers.
func TestBuildBaseIngressRules(t *testing.T) {
setupNetworkPolicyTest(t)
rules := testNetworkPolicyController.buildBaseIngressRules(testRayClusterBasic)
require.Len(t, rules, 1)
intraClusterRule := rules[0]
require.Len(t, intraClusterRule.From, 1)
assert.Equal(t, map[string]string{utils.RayClusterLabelKey: "test-cluster"},
intraClusterRule.From[0].PodSelector.MatchLabels)
assert.Empty(t, intraClusterRule.Ports, "Intra-cluster rule must allow all ports (no Ports field)")
}
// TestBuildHeadIngressRules verifies the head base ingress rules: intra-cluster only.
// The operator access rule is intentionally absent — platforms inject it via
// spec.networkIsolation.head.ingressRules (e.g. a mutating webhook).
func TestBuildHeadIngressRules(t *testing.T) {
setupNetworkPolicyTest(t)
rules := testNetworkPolicyController.buildHeadIngressRules(testRayClusterBasic)
require.Len(t, rules, 1)
// Rule 0: intra-cluster — no ports, pod selector matching the cluster label.
intraClusterRule := rules[0]
require.Len(t, intraClusterRule.From, 1)
assert.Equal(t, map[string]string{utils.RayClusterLabelKey: "test-cluster"},
intraClusterRule.From[0].PodSelector.MatchLabels)
assert.Empty(t, intraClusterRule.Ports, "Intra-cluster rule must allow all ports (no Ports field)")
}
// TestBuildRayJobPeer verifies that buildRayJobPeer returns a peer for RayJob-owned clusters
// and nil for standalone clusters.
func TestBuildRayJobPeer(t *testing.T) {
setupNetworkPolicyTest(t)
peer := testNetworkPolicyController.buildRayJobPeer(testRayClusterBasic)
assert.Nil(t, peer, "Standalone cluster should not have a RayJob peer")
peer = testNetworkPolicyController.buildRayJobPeer(testRayClusterWithRayJob)
require.NotNil(t, peer, "K8sJobMode RayJob-owned cluster should have a RayJob peer")
assert.Equal(t, map[string]string{
utils.RayOriginatedFromCRNameLabelKey: "test-job",
utils.RayOriginatedFromCRDLabelKey: utils.RayOriginatedFromCRDLabelValue(utils.RayJobCRD),
}, peer.PodSelector.MatchLabels)
// Non-K8sJobMode RayJob-owned cluster: no standalone submitter pod, so no peer.
sidecarCluster := testRayClusterWithRayJob.DeepCopy()
sidecarCluster.Labels[utils.RayJobSubmissionModeLabelKey] = string(rayv1.SidecarMode)
peer = testNetworkPolicyController.buildRayJobPeer(sidecarCluster)
assert.Nil(t, peer, "Non-K8sJobMode RayJob-owned cluster should not have a RayJob peer")
}
// TestBuildHeadIngressRules_WithRayJobOwner verifies that a RayJob-owned cluster gets
// a per-job submitter ingress rule (2 rules total: intra-cluster + submitter).
func TestBuildHeadIngressRules_WithRayJobOwner(t *testing.T) {
setupNetworkPolicyTest(t)
rules := testNetworkPolicyController.buildHeadIngressRules(testRayClusterWithRayJob)
require.Len(t, rules, 2)
submitterRule := rules[1]
require.Len(t, submitterRule.From, 1)
assert.Equal(t, map[string]string{
utils.RayOriginatedFromCRNameLabelKey: "test-job",
utils.RayOriginatedFromCRDLabelKey: utils.RayOriginatedFromCRDLabelValue(utils.RayJobCRD),
}, submitterRule.From[0].PodSelector.MatchLabels)
require.Len(t, submitterRule.Ports, 1)
dashboardPort := intstr.FromInt32(utils.DefaultDashboardPort)
assert.Equal(t, &dashboardPort, submitterRule.Ports[0].Port)
}
// TestBuildBaseEgressRules verifies the single base egress rule (intra-cluster only).
func TestBuildBaseEgressRules(t *testing.T) {
setupNetworkPolicyTest(t)
rules := testNetworkPolicyController.buildBaseEgressRules(testRayClusterBasic)
require.Len(t, rules, 1)
// Rule 0: intra-cluster egress — no ports, pod selector matching the cluster label.
intraClusterRule := rules[0]
require.Len(t, intraClusterRule.To, 1)
assert.Equal(t, map[string]string{utils.RayClusterLabelKey: "test-cluster"},
intraClusterRule.To[0].PodSelector.MatchLabels)
assert.Empty(t, intraClusterRule.Ports, "Intra-cluster egress must allow all ports (no Ports field)")
}
// TestBuildHeadNetworkPolicy_WithRayJob verifies that a RayJob-owned cluster gets
// 2 ingress rules: intra-cluster + per-job submitter.
func TestBuildHeadNetworkPolicy_WithRayJob(t *testing.T) {
setupNetworkPolicyTest(t)
policy := testNetworkPolicyController.buildHeadNetworkPolicy(testRayClusterWithRayJob, rayv1.NetworkIsolationDenyAll)
require.Len(t, policy.Spec.Ingress, 2)
}
// TestBuildHeadNetworkPolicy_CustomIngressRules verifies that custom Head.IngressRules are appended after base rules.
func TestBuildHeadNetworkPolicy_CustomIngressRules(t *testing.T) {
setupNetworkPolicyTest(t)
customPort := intstr.FromInt32(9999)
tcpProto := corev1.ProtocolTCP
cluster := testRayClusterBasic.DeepCopy()
cluster.Spec.NetworkIsolation.Head = &rayv1.NetworkPolicyRules{
IngressRules: []networkingv1.NetworkPolicyIngressRule{
{
Ports: []networkingv1.NetworkPolicyPort{
{Protocol: &tcpProto, Port: &customPort},
},
},
},
}
policy := testNetworkPolicyController.buildHeadNetworkPolicy(cluster, rayv1.NetworkIsolationDenyAll)
// 1 base intra-cluster + 1 custom = 2.
require.Len(t, policy.Spec.Ingress, 2)
require.Len(t, policy.Spec.Ingress[1].Ports, 1)
assert.Equal(t, &customPort, policy.Spec.Ingress[1].Ports[0].Port)
}
// TestBuildHeadNetworkPolicy_CustomEgressRules verifies that custom Head.EgressRules are appended after base egress.
func TestBuildHeadNetworkPolicy_CustomEgressRules(t *testing.T) {
setupNetworkPolicyTest(t)
customPort := intstr.FromInt32(8080)
tcpProto := corev1.ProtocolTCP
cluster := testRayClusterBasic.DeepCopy()
cluster.Spec.NetworkIsolation.Head = &rayv1.NetworkPolicyRules{
EgressRules: []networkingv1.NetworkPolicyEgressRule{
{
Ports: []networkingv1.NetworkPolicyPort{
{Protocol: &tcpProto, Port: &customPort},
},
},
},
}
policy := testNetworkPolicyController.buildHeadNetworkPolicy(cluster, rayv1.NetworkIsolationDenyAll)
// 1 base egress + 1 custom = 2.
require.Len(t, policy.Spec.Egress, 2)
require.Len(t, policy.Spec.Egress[1].Ports, 1)
assert.Equal(t, &customPort, policy.Spec.Egress[1].Ports[0].Port)
}
// TestGetHeadPort_DefaultFallback verifies the default port is returned when rayStartParams has no override.
func TestGetHeadPort_DefaultFallback(t *testing.T) {
setupNetworkPolicyTest(t)
cluster := testRayClusterBasic.DeepCopy()
cluster.Spec.HeadGroupSpec.RayStartParams = map[string]string{}
port := testNetworkPolicyController.getHeadPort(cluster, "dashboard-port", utils.DefaultDashboardPort)
assert.Equal(t, int32(utils.DefaultDashboardPort), port)
}
// TestGetHeadPort_CustomPort verifies that a port set via rayStartParams is returned.
func TestGetHeadPort_CustomPort(t *testing.T) {
setupNetworkPolicyTest(t)
cluster := testRayClusterBasic.DeepCopy()
cluster.Spec.HeadGroupSpec.RayStartParams = map[string]string{
"dashboard-port": "9265",
}
port := testNetworkPolicyController.getHeadPort(cluster, "dashboard-port", utils.DefaultDashboardPort)
assert.Equal(t, int32(9265), port)
}
// TestBuildNetworkPolicy_LongClusterName verifies NetworkPolicy names are constructed correctly for long names.
func TestBuildNetworkPolicy_LongClusterName(t *testing.T) {
setupNetworkPolicyTest(t)
cluster := testRayClusterBasic.DeepCopy()
cluster.Name = strings.Repeat("a", utils.MaxRayClusterNameLength)
headPolicy := testNetworkPolicyController.buildHeadNetworkPolicy(cluster, rayv1.NetworkIsolationDenyAll)
workerPolicy := testNetworkPolicyController.buildWorkerNetworkPolicy(cluster, rayv1.NetworkIsolationDenyAll)
assert.Equal(t, cluster.Name+"-head", headPolicy.Name)
assert.Equal(t, cluster.Name+"-workers", workerPolicy.Name)
}
// TestBuildHeadNetworkPolicy_WorkerRulesNotLeaked verifies that worker-specific
// IngressRules are not applied to the head NetworkPolicy.
func TestBuildHeadNetworkPolicy_WorkerRulesNotLeaked(t *testing.T) {
setupNetworkPolicyTest(t)
customPort := intstr.FromInt32(9999)
tcpProto := corev1.ProtocolTCP
cluster := testRayClusterBasic.DeepCopy()
cluster.Spec.NetworkIsolation.Worker = &rayv1.NetworkPolicyRules{
IngressRules: []networkingv1.NetworkPolicyIngressRule{
{Ports: []networkingv1.NetworkPolicyPort{{Protocol: &tcpProto, Port: &customPort}}},
},
}
policy := testNetworkPolicyController.buildHeadNetworkPolicy(cluster, rayv1.NetworkIsolationDenyAll)
// Head NP must only have the intra-cluster base rule — no worker rules.
require.Len(t, policy.Spec.Ingress, 1)
}
// TestBuildWorkerNetworkPolicy_HeadRulesNotLeaked verifies that head-specific
// IngressRules are not applied to the worker NetworkPolicy.
func TestBuildWorkerNetworkPolicy_HeadRulesNotLeaked(t *testing.T) {
setupNetworkPolicyTest(t)
customPort := intstr.FromInt32(9999)
tcpProto := corev1.ProtocolTCP
cluster := testRayClusterBasic.DeepCopy()
cluster.Spec.NetworkIsolation.Head = &rayv1.NetworkPolicyRules{
IngressRules: []networkingv1.NetworkPolicyIngressRule{
{Ports: []networkingv1.NetworkPolicyPort{{Protocol: &tcpProto, Port: &customPort}}},
},
}
policy := testNetworkPolicyController.buildWorkerNetworkPolicy(cluster, rayv1.NetworkIsolationDenyAll)
// Worker NP must only have the intra-cluster base rule — no head rules.
require.Len(t, policy.Spec.Ingress, 1)
}