mirror of
https://github.com/hanzo-ml/kuberay.git
synced 2026-10-30 19:48:47 +00:00
* Updating client-go to v1.36.0-beta.0 (and updating golang to 1.26) Signed-off-by: Mark Rossetti <[email protected]> * Bump golangci-lint to v2.11.4 and fix lint issues for Go 1.26 Signed-off-by: Mark Rossetti <[email protected]> * bump go to 1.26 in ray-operator docker file Signed-off-by: Mark Rossetti <[email protected]> * Migrate webhooks from deprecated CustomValidator to admission.Validation[T] Signed-off-by: Mark Rossetti <[email protected]> * Target K8s 1.36 GA deps Signed-off-by: Mark Rossetti <[email protected]> * Merge branch 'master' into go-client-go-updates Signed-off-by: Rueian <[email protected]> --------- Signed-off-by: Mark Rossetti <[email protected]> Signed-off-by: Rueian <[email protected]> Co-authored-by: Rueian <[email protected]>
81 lines
3.0 KiB
Go
81 lines
3.0 KiB
Go
package v1
|
|
|
|
import (
|
|
"context"
|
|
|
|
apierrors "k8s.io/apimachinery/pkg/api/errors"
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
"k8s.io/apimachinery/pkg/util/validation/field"
|
|
ctrl "sigs.k8s.io/controller-runtime"
|
|
logf "sigs.k8s.io/controller-runtime/pkg/log"
|
|
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
|
|
|
|
rayv1 "github.com/ray-project/kuberay/ray-operator/apis/ray/v1"
|
|
"github.com/ray-project/kuberay/ray-operator/controllers/ray/utils"
|
|
)
|
|
|
|
var rayClusterLog = logf.Log.WithName("raycluster-resource")
|
|
|
|
// SetupRayClusterWebhookWithManager registers the webhook for RayCluster in the manager.
|
|
func SetupRayClusterWebhookWithManager(mgr ctrl.Manager) error {
|
|
return ctrl.NewWebhookManagedBy(mgr, &rayv1.RayCluster{}).
|
|
WithValidator(&RayClusterWebhook{}).
|
|
Complete()
|
|
}
|
|
|
|
type RayClusterWebhook struct{}
|
|
|
|
//+kubebuilder:webhook:path=/validate-ray-io-v1-raycluster,mutating=false,failurePolicy=fail,sideEffects=None,groups=ray.io,resources=rayclusters,verbs=create;update,versions=v1,name=vraycluster.kb.io,admissionReviewVersions=v1
|
|
|
|
var _ admission.Validator[*rayv1.RayCluster] = &RayClusterWebhook{}
|
|
|
|
// ValidateCreate implements admission.Validator so a webhook will be registered for the type
|
|
func (w *RayClusterWebhook) ValidateCreate(_ context.Context, rayCluster *rayv1.RayCluster) (admission.Warnings, error) {
|
|
rayClusterLog.Info("validate create", "name", rayCluster.Name)
|
|
return nil, w.validateRayCluster(rayCluster)
|
|
}
|
|
|
|
// ValidateUpdate implements admission.Validator so a webhook will be registered for the type
|
|
func (w *RayClusterWebhook) ValidateUpdate(_ context.Context, _ *rayv1.RayCluster, rayCluster *rayv1.RayCluster) (admission.Warnings, error) {
|
|
rayClusterLog.Info("validate update", "name", rayCluster.Name)
|
|
return nil, w.validateRayCluster(rayCluster)
|
|
}
|
|
|
|
// ValidateDelete implements admission.Validator so a webhook will be registered for the type
|
|
func (w *RayClusterWebhook) ValidateDelete(_ context.Context, _ *rayv1.RayCluster) (admission.Warnings, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (w *RayClusterWebhook) validateRayCluster(rayCluster *rayv1.RayCluster) error {
|
|
var allErrs field.ErrorList
|
|
|
|
if err := utils.ValidateRayClusterMetadata(rayCluster.ObjectMeta); err != nil {
|
|
allErrs = append(allErrs, field.Invalid(field.NewPath("metadata").Child("name"), rayCluster.Name, err.Error()))
|
|
}
|
|
|
|
if err := w.validateWorkerGroups(rayCluster); err != nil {
|
|
allErrs = append(allErrs, err)
|
|
}
|
|
|
|
if len(allErrs) == 0 {
|
|
return nil
|
|
}
|
|
|
|
return apierrors.NewInvalid(
|
|
schema.GroupKind{Group: "ray.io", Kind: "RayCluster"},
|
|
rayCluster.Name, allErrs)
|
|
}
|
|
|
|
func (w *RayClusterWebhook) validateWorkerGroups(rayCluster *rayv1.RayCluster) *field.Error {
|
|
workerGroupNames := make(map[string]bool)
|
|
|
|
for i, workerGroup := range rayCluster.Spec.WorkerGroupSpecs {
|
|
if _, ok := workerGroupNames[workerGroup.GroupName]; ok {
|
|
return field.Invalid(field.NewPath("spec").Child("workerGroupSpecs").Index(i), workerGroup, "worker group names must be unique")
|
|
}
|
|
workerGroupNames[workerGroup.GroupName] = true
|
|
}
|
|
|
|
return nil
|
|
}
|