Files
kuberay/ray-operator/pkg/webhooks/v1/raycluster_webhook_test.go
c737feb129 Go 1.26 and K8s 1.36 client-go updates (#4703)
* Updating client-go to v1.36.0-beta.0 (and updating golang to 1.26)

Signed-off-by: Mark Rossetti <[email protected]>

* Bump golangci-lint to v2.11.4 and fix lint issues for Go 1.26

Signed-off-by: Mark Rossetti <[email protected]>

* bump go to 1.26 in ray-operator docker file

Signed-off-by: Mark Rossetti <[email protected]>

* Migrate webhooks from deprecated CustomValidator to admission.Validation[T]

Signed-off-by: Mark Rossetti <[email protected]>

* Target K8s 1.36 GA deps

Signed-off-by: Mark Rossetti <[email protected]>

* Merge branch 'master' into go-client-go-updates

Signed-off-by: Rueian <[email protected]>

---------

Signed-off-by: Mark Rossetti <[email protected]>
Signed-off-by: Rueian <[email protected]>
Co-authored-by: Rueian <[email protected]>
2026-05-03 00:03:55 -07:00

121 lines
3.0 KiB
Go

package v1
import (
"context"
"fmt"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/rand"
rayv1 "github.com/ray-project/kuberay/ray-operator/apis/ray/v1"
)
var _ = Describe("RayCluster validating webhook", func() {
Context("when name is too long", func() {
It("should return error", func() {
longName := "this-name-is-tooooooooooooooooooooooooooooooooooooooooooo-long-and-should-be-invalid"
rayCluster := rayv1.RayCluster{
ObjectMeta: metav1.ObjectMeta{
Namespace: "default",
Name: longName,
},
Spec: rayv1.RayClusterSpec{
HeadGroupSpec: rayv1.HeadGroupSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{},
},
},
},
WorkerGroupSpecs: []rayv1.WorkerGroupSpec{},
},
}
err := k8sClient.Create(context.TODO(), &rayCluster)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring(fmt.Sprintf("RayCluster.ray.io \"%s\" is invalid: metadata.name", longName)))
})
})
Context("when name isn't a DNS1035 label", func() {
It("should return error", func() {
rayCluster := rayv1.RayCluster{
ObjectMeta: metav1.ObjectMeta{
Namespace: "default",
Name: "invalid.name",
},
Spec: rayv1.RayClusterSpec{
HeadGroupSpec: rayv1.HeadGroupSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{},
},
},
},
WorkerGroupSpecs: []rayv1.WorkerGroupSpec{},
},
}
err := k8sClient.Create(context.TODO(), &rayCluster)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("RayCluster.ray.io \"invalid.name\" is invalid: metadata.name:"))
})
})
Context("when groupNames are not unique", func() {
var name, namespace string
var rayCluster rayv1.RayCluster
BeforeEach(func() {
namespace = "default"
name = fmt.Sprintf("test-raycluster-%d", rand.IntnRange(1000, 9000))
})
It("should return error", func() {
rayCluster = rayv1.RayCluster{
ObjectMeta: metav1.ObjectMeta{
Name: name,
Namespace: namespace,
},
Spec: rayv1.RayClusterSpec{
HeadGroupSpec: rayv1.HeadGroupSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{},
},
},
},
WorkerGroupSpecs: []rayv1.WorkerGroupSpec{
{
GroupName: "group1",
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{},
},
},
},
{
GroupName: "group1",
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{},
},
},
},
},
},
}
err := k8sClient.Create(context.TODO(), &rayCluster)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("worker group names must be unique"))
})
})
})