Files
kuberay/ray-operator/main_test.go
Thomas DesrosiersandGitHub 8e5f88ca35 [core] Bump Go Dependencies (#2205)
* bump ./proto deps

* bump ./apiserver deps

* bump ./ray-operator deps

* bump ./cli deps

* bump ./experimental deps

* fixup! bump ./ray-operator deps

* Doesn't seem to matter but also bump buildkite

* Don't change the distro version just yet

* Bump go version in gha jobs

* Also bump sigs.k8s.io/controller-tools for build time

* more bumps

* Update package import paths for proto rename

* Fix another deprecated API

* s/corev1.ResourceRequirements/corev1.VolumeResourceRequirements/gci rename

* Downgrade client-go

* update-codegen.sh

* Try bumping crd-ref-docs as well

* make manifests

* make sync

* k8s.io/utils/pointer -> k8s.io/utils/ptr

* lint: missing formatting directive

* make generate

* Try to bump version

* Bump & standardize builder images

* fixup! Bump & standardize builder images

* Switch multi-arch Dockerfile to distrolss as well
2024-06-26 16:08:34 -07:00

192 lines
4.7 KiB
Go

package main
import (
"reflect"
"strings"
"testing"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/utils/ptr"
configapi "github.com/ray-project/kuberay/ray-operator/apis/config/v1alpha1"
)
func Test_decodeConfig(t *testing.T) {
testcases := []struct {
name string
configData string
errContains string
expectedConfig configapi.Configuration
expectErr bool
}{
{
name: "default config file",
configData: `apiVersion: config.ray.io/v1alpha1
kind: Configuration
`,
expectedConfig: configapi.Configuration{
TypeMeta: metav1.TypeMeta{
Kind: "Configuration",
APIVersion: "config.ray.io/v1alpha1",
},
MetricsAddr: ":8080",
ProbeAddr: ":8082",
EnableLeaderElection: ptr.To(true),
ReconcileConcurrency: 1,
},
expectErr: false,
},
{
name: "config file all field set",
configData: `apiVersion: config.ray.io/v1alpha1
kind: Configuration
metricsAddr: ":8080"
probeAddr: ":8082"
enableLeaderElection: true
reconcileConcurrency: 1
`,
expectedConfig: configapi.Configuration{
TypeMeta: metav1.TypeMeta{
Kind: "Configuration",
APIVersion: "config.ray.io/v1alpha1",
},
MetricsAddr: ":8080",
ProbeAddr: ":8082",
EnableLeaderElection: ptr.To(true),
ReconcileConcurrency: 1,
},
expectErr: false,
},
{
name: "config with sidecars",
configData: `apiVersion: config.ray.io/v1alpha1
kind: Configuration
metricsAddr: ":8080"
probeAddr: ":8082"
enableLeaderElection: true
reconcileConcurrency: 1
headSidecarContainers:
- name: fluentbit
image: fluent/fluent-bit:1.9.6
workerSidecarContainers:
- name: fluentbit
image: fluent/fluent-bit:1.9.6
`,
expectedConfig: configapi.Configuration{
TypeMeta: metav1.TypeMeta{
Kind: "Configuration",
APIVersion: "config.ray.io/v1alpha1",
},
MetricsAddr: ":8080",
ProbeAddr: ":8082",
EnableLeaderElection: ptr.To(true),
ReconcileConcurrency: 1,
HeadSidecarContainers: []corev1.Container{
{
Name: "fluentbit",
Image: "fluent/fluent-bit:1.9.6",
},
},
WorkerSidecarContainers: []corev1.Container{
{
Name: "fluentbit",
Image: "fluent/fluent-bit:1.9.6",
},
},
},
expectErr: false,
},
{
name: "unknown filed ignored",
configData: `apiVersion: config.ray.io/v1alpha1
kind: Configuration
metricsAddr: ":8080"
probeAddr: ":8082"
enableLeaderElection: true
reconcileConcurrency: 1
unknownfield: 1
`,
expectedConfig: configapi.Configuration{
TypeMeta: metav1.TypeMeta{
Kind: "Configuration",
APIVersion: "config.ray.io/v1alpha1",
},
MetricsAddr: ":8080",
ProbeAddr: ":8082",
EnableLeaderElection: ptr.To(true),
ReconcileConcurrency: 1,
},
expectErr: false,
},
{
name: "invalid type for field",
configData: `apiVersion: config.ray.io/v1alpha1
kind: Configuration
metricsAddr: ":8080"
probeAddr: ":8082"
enableLeaderElection: true
reconcileConcurrency: true
`,
expectedConfig: configapi.Configuration{
TypeMeta: metav1.TypeMeta{
Kind: "Configuration",
APIVersion: "config.ray.io/v1alpha1",
},
MetricsAddr: ":8080",
ProbeAddr: ":8082",
EnableLeaderElection: ptr.To(true),
ReconcileConcurrency: 0,
},
expectErr: true,
errContains: "json: cannot unmarshal bool into Go struct field Configuration.reconcileConcurrency of type int",
},
{
name: "invalid version for config",
configData: `apiVersion: config.ray.io/v1beta1
kind: Configuration
metricsAddr: ":8080"
probeAddr: ":8082"
enableLeaderElection: true
reconcileConcurrency: true
`,
expectedConfig: configapi.Configuration{
MetricsAddr: ":8080",
ProbeAddr: ":8082",
EnableLeaderElection: ptr.To(true),
},
expectErr: true,
errContains: `no kind "Configuration" is registered for version "config.ray.io/v1beta1" in scheme`,
},
}
for _, testcase := range testcases {
t.Run(testcase.name, func(t *testing.T) {
config, err := decodeConfig([]byte(testcase.configData), scheme)
if testcase.expectErr {
if err == nil {
t.Error("expected err but got nil")
}
if err != nil && !strings.Contains(err.Error(), testcase.errContains) {
t.Logf("actual error: %v", err)
t.Logf("expected error to contain string: %q", testcase.errContains)
t.Error("unexpected error")
}
return
}
if err != nil {
t.Errorf("unexpected error: %v", err)
}
if !reflect.DeepEqual(config, testcase.expectedConfig) {
t.Logf("actual config: %v", config)
t.Logf("expected config: %v", testcase.expectedConfig)
t.Error("unexpected config")
}
})
}
}