mirror of
https://github.com/hanzo-ml/spark-operator.git
synced 2026-10-30 20:39:07 +00:00
Rishabh SinghandGitHub
bb0d8371c4
- Add test/drift/drift_test.go with 17 subtests covering resource inventory, ClusterRoles, Roles, MutatingWebhookConfiguration, ValidatingWebhookConfiguration, and Deployment container specs - Update Makefile drift-check target to run go test ./test/drift/ - Update workflow path triggers for test/drift/** - Remove scripts/drift-check.sh and config/drift-check-allowlist.yaml in favor of logic encoded directly in Go - add webhook selector drift detection for objectSelector and namespaceSelector - fix(drift): Add sideEffects subtests, handle multi-rule webhooks, and improve error logging - fix(drift): skip namespaceSelector comparison in cluster-wide mode Helm in cluster-wide mode (jobNamespaces: []) omits namespaceSelector, while Kustomize hardcodes it via strategic-merge patches since controller-gen cannot emit it from kubebuilder markers. Compare namespaceSelector only when Helm actually renders one; objectSelector comparison remains unconditional. - fix(bug) Changed sortedCopy(r.Resources) to dedupSorted(sortedCopy(r.Resources)) and Replaced the terse // Optionally present with a clear explanation of why PDB is ignored Signed-off-by: roburishabh <[email protected]>
32 lines
1.1 KiB
YAML
32 lines
1.1 KiB
YAML
#
|
|
# Copyright 2024 The Kubeflow authors.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# https://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
# Helm values to render output comparable to Kustomize defaults.
|
|
# Used by: make drift-check
|
|
#
|
|
# These values align the Helm template output with what kustomize build produces,
|
|
# so the drift detection script can perform an apples-to-apples comparison.
|
|
|
|
spark:
|
|
jobNamespaces:
|
|
- "" # Cluster-wide: puts policyRules in ClusterRole (matches Kustomize)
|
|
|
|
hook:
|
|
upgradeCrd: false # Exclude CRD hook Job (not present in Kustomize)
|
|
|
|
certManager:
|
|
enable: false # Exclude cert-manager resources (not present in Kustomize)
|