Commit Graph
84 Commits
Author SHA1 Message Date
Andrey VelichkevichandGitHub 31ba928cf6 Update Slack Invitation (#2142)
Signed-off-by: Andrey Velichkevich <[email protected]>
2024-06-11 12:09:14 +00:00
Andrey VelichkevichandGitHub dc8e4e0380 [SDK] Fix Incorrect Events in get_job_logs API (#2122)
Signed-off-by: Andrey Velichkevich <[email protected]>
2024-05-21 16:28:25 +00:00
af29559386 changed package name to flake8 to fix pytests pip install (#2109)
Signed-off-by: Christophe Brown <[email protected]>
Co-authored-by: Christophe Brown <[email protected]>
2024-05-10 14:31:45 +00:00
Yuki IwaiandGitHub f310db59a8 Support Python 3.11 and Drop Python 3.7 (#2105)
Signed-off-by: Yuki Iwai <[email protected]>
2024-05-09 20:58:45 +00:00
Yuki IwaiandGitHub 096a7bc6ab E2E: Replace outdated images with latest ones (#2083)
Signed-off-by: Yuki Iwai <[email protected]>
2024-04-25 21:54:46 +00:00
Andrey VelichkevichandGitHub 3ee6efcb10 [SDK] Add docstring for Train API (#2075)
* [SDK] Add docstring for Train API

Signed-off-by: Andrey Velichkevich <[email protected]>

* Update a few args

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Andrey Velichkevich <[email protected]>
2024-04-24 18:24:19 +00:00
Yuki IwaiandGitHub 3d741b0995 SDK: Upgrade the minimum required Kubernetes version to v1.27.2 (#2066)
Signed-off-by: Yuki Iwai <[email protected]>
2024-04-15 12:59:51 +00:00
deepanker13andGitHub 42a897c96f adding fine tune example with s3 as the dataset store (#2006)
* s3 as dataset source code review changes

Signed-off-by: deepanker13 <[email protected]>

* fixing python black test

Signed-off-by: deepanker13 <[email protected]>

* removing conflicts in example file

Signed-off-by: deepanker13 <[email protected]>

* retriggering CI

Signed-off-by: deepanker13 <[email protected]>

* removing dummy keys

Signed-off-by: deepanker13 <[email protected]>

* code review change for adding s3 keys block

Signed-off-by: deepanker13 <[email protected]>

---------

Signed-off-by: deepanker13 <[email protected]>
2024-04-12 19:54:48 +00:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
90f027853d Bump transformers from 4.37.2 to 4.38.0 in /sdk/python/kubeflow/storage_initializer (#2056)
Bumps [transformers](https://github.com/huggingface/transformers) from 4.37.2 to 4.38.0.
- [Release notes](https://github.com/huggingface/transformers/releases)
- [Commits](https://github.com/huggingface/transformers/compare/v4.37.2...v4.38.0)

---
updated-dependencies:
- dependency-name: transformers
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-11 07:24:47 +00:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
b39271e152 Bump transformers from 4.37.2 to 4.38.0 in /sdk/python/kubeflow/trainer (#2055)
Bumps [transformers](https://github.com/huggingface/transformers) from 4.37.2 to 4.38.0.
- [Release notes](https://github.com/huggingface/transformers/releases)
- [Commits](https://github.com/huggingface/transformers/compare/v4.37.2...v4.38.0)

---
updated-dependencies:
- dependency-name: transformers
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-11 07:18:47 +00:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
b24d26c474 Bump black from 21.12b0 to 24.3.0 in /sdk/python (#2033)
Bumps [black](https://github.com/psf/black) from 21.12b0 to 24.3.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/commits/24.3.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-25 14:01:18 +00:00
Andrey VelichkevichandGitHub 8634427e4d Modify LLM Trainer to support BERT and Tiny LLaMA (#2031)
* Modify LLM Trainer to support BERT and Tiny LLaMA

Signed-off-by: Andrey Velichkevich <[email protected]>

* Access PVC access modes to storage config

Signed-off-by: Andrey Velichkevich <[email protected]>

* Format Python files

Signed-off-by: Andrey Velichkevich <[email protected]>

* Distribute datasets

Fix access modes in storage config

Signed-off-by: Andrey Velichkevich <[email protected]>

* Update example to fine tune BERT with Train API

Signed-off-by: Andrey Velichkevich <[email protected]>

* Remove dataset download twice

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Andrey Velichkevich <[email protected]>
2024-03-15 19:28:30 +00:00
Andrey VelichkevichandGitHub 386392ded2 Add Fine-Tune BERT LLM Example (#2021)
* Add Fine-Tune BERT LLM Example

Signed-off-by: Andrey Velichkevich <[email protected]>

* Add 3 GPUs in Notebook requirements

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Andrey Velichkevich <[email protected]>
2024-03-12 11:35:10 +00:00
Gary MiguelandGitHub d365c12b0e Fix URL in python SDK setup.py (#2011)
Signed-off-by: Gary Miguel <[email protected]>
2024-03-01 23:29:05 +00:00
Andrey VelichkevichandGitHub a44b9d0b93 [SDK] Add resources per worker for Create Job API (#1990)
* [SDK] Add resources for create Job API

* Fix unbound var

* Assign values in get pod template

* Add torchrun issue

* Test to create PyTorchJob from Image

* Fix e2e to create from image

* Fix condition

* Modify check test conditions
2024-01-18 16:38:59 +00:00
Andrey VelichkevichandGitHub 99a719d266 [SDK] Fix Worker and Master templates for PyTorchJob (#1988) 2024-01-16 19:09:19 +00:00
deepanker13andGitHub 93ff8e54f3 publish trainer hugging face image (#1985)
* publish trainer hugging face

* renaming container image names
2024-01-12 14:29:14 +00:00
deepanker13andGitHub 46a80709a2 Adding Training image needed for train api (#1963)
* adding training image creationcode

* reformatting code using black

* code review changes

* fixes

* running workflow on push

* correcting context

* correcting context

* fixing trainer code

* code review changes

* resolving merge conflict

* code review changes

* downgrading pytorch version, removing changes for running things locally, adding jupyter notebook

* ci fix and removing unused parameter and adding check if pvc exists already

* gpu training example fix
2024-01-11 21:06:09 +00:00
Andrey VelichkevichandGitHub 16cb71035c Add test to create PyTorchJob from func (#1979)
* Add test to create PyTorchJob from func

* Use unique Job name for each test

* Fix job name in test

* Describe PyTorchJob when test fails

* Skip test for gang scheduling
2024-01-11 16:51:12 +00:00
Andrey VelichkevichandGitHub 8d8cb96ada [SDK] Get Kubernetes Events for Job (#1975)
* [SDK] Get Kubernetes Events for Job

* Move class at the top

* Add object kind to event message

* Add example for events
2024-01-11 16:30:12 +00:00
deepanker13andGitHub 6a34d14f04 [SDK] Train API (#1962)
* adding constant for init container name

* github workflow fixes

* removing constants file changes from this pr

* code review changes

* initial skeleton of train api

* train api updated

* fixes

* code review changes

* code review changes

* code review changes

* code review changes

* fixing python library requirements

* adding hugging face dataset download class

* code review changes

* fixing github workflow

* code review comments

* import fixes

* integration test fix for python3.7

* torch version fix for python3.7

* removing unused variable

* fixing library versions for python3.7

* removing alpine distribution

* removing torch ad dependency

* removing literal usage as python 3.7 doesn't support it

* adding types.py

* ci fix

* storage init container changes, fixing imports

* adding extra requires in setup.py, fixinf ci

* adding commit to retrigger go test

* renaming folder to storage initalizer

* bug fix

* removing extra gpu check as discussed with johnu

* retriggering ci
2024-01-10 17:06:08 +00:00
7d0df036ad [SDK] Add information about TrainingClient logging (#1973)
* [SDK] Use logging to print Job logs

* Update func description

* Add info to configure logging in debug mode

* Update sdk/python/kubeflow/training/api/training_client.py

Co-authored-by: Alex <[email protected]>

* Return logs if follow is True

---------

Co-authored-by: Alex <[email protected]>
2024-01-05 15:46:09 +00:00
deepanker13andGitHub 8fd0527327 Train api dataset download changes (#1959)
* adding constant for init container name

* adding master pod template spec and chief replica spec

* renaming vars and adding master spec

* github workflow fixes

* removing constants file changes from this pr

* code review changes

* adding s3/nutanix object store as  dataset provider

* adding validations
2023-12-14 10:42:53 +00:00
deepanker13andGitHub 138ad9c26c Train api init container creation (#1958)
* adding constant for init container name

* adding master pod template spec and chief replica spec

* renaming vars and adding master spec

* github workflow fixes

* removing constants file changes from this pr

* code review changes

* adding new folder for creating storage init container images

* changing variable name

* adding validation for model uri

* adding peft_config field

* updating python version
2023-12-12 14:02:24 +00:00
deepanker13andGitHub 3748eaa5ef utils changes needed to add train api (#1954)
* utils changes needed to add train api

* adding constant for init container name

* adding master pod template spec and chief replica spec

* renaming vars and adding master spec

* github workflow fixes

* removing constants file changes from this pr

* code review changes

* bug fix

* adding get_container_spec in get_pod_template_spec
2023-12-08 11:34:27 +00:00
deepanker13andGitHub 240e547c41 Training operator SDK unit test (#1938)
* adding bug fix in gen-sdk.sh and unit test for create_job function in training client

* code reformatted using black

* move unittest to a different folder

* code review comments changes

* adding pytest github action

* removing 3rd party github pytest action
2023-11-21 09:25:10 +00:00
AlexandGitHub 25da25b1c4 Avoid modifying log level globally (#1944)
* Avoid modifying log level globally

* Address get_job_logs

* Fix integration tests
2023-11-13 19:07:42 +00:00
Johnu GeorgeandGitHub 051a68a3b0 Merge v1.7 branch changes to Main (#1940)
* Update latest training operator images in v1.7 branch (#1881)

* Removing dead code

* Update monitoring guide

* Update latest training operator image

* Update sdk to v1.7.0rc0 (#1882)

* Removing dead code

* Update monitoring guide

* Update latest training operator image

* Update SDK version to v1.7.0rc0

* Update sdk to v1.7.0 (#1939)
2023-11-01 12:31:57 +00:00
Yuki IwaiandGitHub f7892a4214 Use a community hosted image in MXJob E2E (#1928)
Signed-off-by: Yuki Iwai <[email protected]>
2023-10-05 21:08:15 +00:00
Yuki IwaiandGitHub 32b7c1d4c0 Replace XGBoost image for E2E with community hosted (#1922)
Signed-off-by: Yuki Iwai <[email protected]>
2023-09-29 14:41:43 +00:00
af15b0d553 [SDK] Consolidate Naming for CRUD APIs (#1907)
* Add Flake and Black Lint

* Change SDK APIs

* Update E2E tests

* Fix a few function parameters

* Fix black format

* Fix a few comments

* Fix conftest location

* Fix Job kind in tests

* Fix client creation in test

* Fix namespace arg in get_job_conditions

* Update SDK examples with the latest changes

* Rename SDK examples

* Fix black action

* Update checkout action version

Co-authored-by: Yuki Iwai <[email protected]>

* Use Black 23.9.1 version

* Fix GitHub Action for Black

* Add unit test to create PyTorchJob from func

* Rename timeout to wait_timeout

* Validate that Job is not set with other input parameters

* Update black in developer guide

* Remove pip_index_url validation

* Use locals to verify input

* Print Job info when E2E fails

* Remove duplicated delete

---------

Co-authored-by: Yuki Iwai <[email protected]>
2023-09-22 14:27:33 +00:00
Yuki IwaiandGitHub de6d52bf3a Implement suspend semantics (#1859)
Signed-off-by: Yuki Iwai <[email protected]>
2023-07-20 20:25:24 +00:00
Yuki IwaiandGitHub 38092c3b6e Make Condition and ReplicaStatus optional (#1862)
Signed-off-by: Yuki Iwai <[email protected]>
2023-07-13 17:07:25 +00:00
Chitsing KUIandGitHub a81242a4cb Set correct ENV for PytorchJob to support torchrun (#1840)
* fix pytorch WORLD_SIZE env inconsistent

* add correct env node_rank, nnodes for torch

* restore elastic nnproc

* use string for nproc_per_node

* add defaults in api

* add validation for two nproc_per_node, use auto for defaulter

* add ut for defaults and validation

* fix ut

* add doc for nproc_per_node
2023-07-12 17:11:07 +00:00
Yuki IwaiandGitHub 08e96f76c8 Add check pods are not scheduled when testing gang-scheduler integrations in e2e (#1835)
Signed-off-by: Yuki Iwai <[email protected]>
2023-06-18 17:30:38 +00:00
c320716a1a Merge kubeflow/common to training-operator (#1813)
* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Change k8s api to v1.25

* Upgrade golangci-lint version

* Add changelog

* Update CHANGELOG.md

* Update Changelog

* Merge common repo

* Avoid to depend on local env when installing the code-generators (#1810)

Signed-off-by: Yuki Iwai <[email protected]>

* Make scheduler-plugins the default gang scheduler. (#1747)

Signed-off-by: Syulin7 <[email protected]>

* Fix tests

* Fix merge conflicts

* Fix CI issues

* Fix CI issues

* Fix review comments

* Add contributors in Readme file

* Fix review comments

* Fix review comments

---------

Signed-off-by: Yuki Iwai <[email protected]>
Signed-off-by: Syulin7 <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
Co-authored-by: yu lin <[email protected]>
2023-05-31 11:04:04 +00:00
yu linandGitHub 959a7b8711 Make scheduler-plugins the default gang scheduler. (#1747)
Signed-off-by: Syulin7 <[email protected]>
2023-05-23 11:10:35 +00:00
Yuki IwaiandGitHub 1a203355b0 Improve E2E tests for the gang-scheduling (#1801)
Signed-off-by: Yuki Iwai <[email protected]>
2023-05-11 10:30:01 +00:00
nagar-ajayandGitHub 28f900b7cf make timeout configurable from e2e tests (#1787) 2023-03-24 19:29:22 +00:00
nagar-ajayandGitHub 04887cd803 Containerize e2e tests for training operator conformance (#1780)
* docker file to create conformance tests container

* add resources to containers created by test jobs

* use setup.py to install dependencies

* update resources to fix the test in CI

* update resource limits

* update resource limits

* build and publish conformance test image in CI

* fix conformance file path

* fix python lint error

* fix python lint error

* use python 3.10
2023-03-19 18:43:09 +00:00
nagar-ajayandGitHub 3c6950797f Disable istio-sidecar injection (#1778)
* disable istio-sidecar injection for e2e integration tests

* make 'sidecar.istio.io/inject' annotation a constant
2023-03-16 07:38:27 +00:00
nagar-ajayandGitHub 955a71e8ac E2e test in k8s cluster and Namespace option (#1774)
* update mpijob e2e test to use fixtures

* update mxjob e2e test to use fixtures

* update paddlejob e2e test to use fixtures

* update pytorchjob e2e test to use fixtures

* update xgboostjob e2e test to use fixtures

* update tfjob e2e test to use fixtures

* remove training_client fixture

* move conftest to test root dir

* delete only autogenerated test files

* add default namespace option in integration-tests github action
2023-03-15 10:04:10 +00:00
nagar-ajayandGitHub 9de3493e78 Fix XGBoost flaky e2e tests (#1775) 2023-03-14 11:00:24 +00:00
Hongzhi ChenandGitHub 399715b012 [Bugfix][SDK] pod has no metadata attr anymore in the get_job_logs() … (#1760) 2023-02-16 18:40:07 +00:00
Andrey VelichkevichandGitHub 60987e2c61 [SDK] Use Training Client without Kube Config (#1740)
* [SDK] Use Training Client without Kube Config

* Skip kube-config when using client config
2023-01-24 16:22:24 +00:00
Yuki IwaiandGitHub e08d022a03 Add E2E test for gang-scheduling (#1736)
* Add E2E test for gang-scheduling

Signed-off-by: Yuki Iwai <[email protected]>

* Add a TODO comment for volcano

Signed-off-by: Yuki Iwai <[email protected]>

* Fix some nit

Signed-off-by: Yuki Iwai <[email protected]>

Signed-off-by: Yuki Iwai <[email protected]>
2023-01-24 11:48:24 +00:00
29c3feb9f4 Adopting coschduling plugin (#1724)
* Add scheduler plugin for coscheduling

Signed-off-by: Yuki Iwai <[email protected]>
Co-authored-by: Wang Zhang <[email protected]>
Signed-off-by: Yuki Iwai <[email protected]>

* generate codes

Signed-off-by: Yuki Iwai <[email protected]>

* Add a custom Watcher for scheduler-plugins PodGroup to controllers

Signed-off-by: Yuki Iwai <[email protected]>

* Fix predicates of paddlepaddle-controller for scheduling.volcano.sh/v1beta1 PodGroup

Signed-off-by: Yuki Iwai <[email protected]>

* Upgrade kubeflow/common version to v0.4.6 with HPA changes

Signed-off-by: Yuki Iwai <[email protected]>

Signed-off-by: Yuki Iwai <[email protected]>
Co-authored-by: Wang Zhang <[email protected]>
2023-01-21 17:58:50 +00:00
Andrey VelichkevichandGitHub 38c63d5b35 [SDK] Create Unify Training Client (#1719)
* Remove legacy ksonnet tests

* [SDK] Create Unify Training Client

* Modify E2E tests

* Rename Training to Operator version

* Add missing exception

* Add API server timeout parameter

* Add delete options

* Fix import for V1JobCondition

* Fix container name in e2e tests

* Fix mxnet container

* Import all Kubernetes models

* Update SDK Examples

* Verify other SDK APIs in e2e tests

* Add replica types to const

* Use logging in e2e tests

* Fix logging for status

* Use const for job types
2023-01-17 15:28:20 +00:00
Johnu GeorgeandGitHub df8881b56f Removing deprecated Job Labels (#1702)
* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Change k8s api to v1.25

* Upgrade golangci-lint version

* Remove deprecated job labels

* Updating dependencies

* Fix Sdk
2022-12-22 15:56:13 +00:00
Johnu GeorgeandGitHub 8c07ee0f54 HPA support for PyTorch Elastic (#1701)
* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Change k8s api to v1.25

* Upgrade golangci-lint version

* Fixes for HPA in pytorchjob

* Common changes
2022-12-21 15:49:13 +00:00