mirror of
https://github.com/hanzo-ml/trainer.git
synced 2026-09-24 00:31:34 +00:00
Andrey VelichkevichandGitHub
7cdf7ce5a2
* chore(deps): Bump Go 1.25, k8s to v1.35, and controller-runtime v0.23.1 Signed-off-by: Andrey Velichkevich <[email protected]> * Migrate to new events API with EventRecorder Signed-off-by: Andrey Velichkevich <[email protected]> * Fix RBAC for events Signed-off-by: Andrey Velichkevich <[email protected]> * Bump k8s version in tests Signed-off-by: Andrey Velichkevich <[email protected]> * Add type compliance check Signed-off-by: Andrey Velichkevich <[email protected]> * Use Reconciling action for event Signed-off-by: Andrey Velichkevich <[email protected]> --------- Signed-off-by: Andrey Velichkevich <[email protected]>
82 lines
2.4 KiB
Go
82 lines
2.4 KiB
Go
/*
|
|
Copyright 2025 The Kubeflow Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package webhooks
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"k8s.io/klog/v2/ktesting"
|
|
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
|
|
jobsetv1alpha2 "sigs.k8s.io/jobset/api/jobset/v1alpha2"
|
|
|
|
trainer "github.com/kubeflow/trainer/v2/pkg/apis/trainer/v1alpha1"
|
|
"github.com/kubeflow/trainer/v2/pkg/constants"
|
|
testingutil "github.com/kubeflow/trainer/v2/pkg/util/testing"
|
|
)
|
|
|
|
func TestClusterTrainingRuntimeValidateCreate(t *testing.T) {
|
|
cases := map[string]struct {
|
|
labels map[string]string
|
|
warnings admission.Warnings
|
|
}{
|
|
"no deprecation label": {
|
|
labels: nil,
|
|
warnings: nil,
|
|
},
|
|
"support=deprecated": {
|
|
labels: map[string]string{constants.LabelSupport: constants.SupportDeprecated},
|
|
warnings: admission.Warnings{
|
|
"ClusterTrainingRuntime \"test-runtime\" is deprecated and will be removed in a future release of Kubeflow Trainer. See runtime deprecation policy: " + constants.RuntimeDeprecationPolicyURL,
|
|
},
|
|
},
|
|
}
|
|
|
|
for name, tc := range cases {
|
|
t.Run(name, func(t *testing.T) {
|
|
_, ctx := ktesting.NewTestContext(t)
|
|
ctx, cancel := context.WithCancel(ctx)
|
|
t.Cleanup(cancel)
|
|
|
|
obj := testingutil.MakeClusterTrainingRuntimeWrapper("test-runtime").
|
|
RuntimeSpec(trainer.TrainingRuntimeSpec{
|
|
Template: trainer.JobSetTemplateSpec{
|
|
Spec: func() jobsetv1alpha2.JobSetSpec {
|
|
js := testingutil.MakeJobSetWrapper("", "")
|
|
js.Replicas(1, constants.DatasetInitializer, constants.ModelInitializer, constants.Node)
|
|
return js.Obj().Spec
|
|
}(),
|
|
},
|
|
}).Obj()
|
|
|
|
if len(tc.labels) != 0 {
|
|
obj.Labels = tc.labels
|
|
}
|
|
|
|
validator := &ClusterTrainingRuntimeValidator{}
|
|
warnings, err := validator.ValidateCreate(ctx, obj)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if diff := cmp.Diff(tc.warnings, warnings); diff != "" {
|
|
t.Fatalf("unexpected warnings (-want, +got): %s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|