mirror of
https://github.com/hanzo-ml/trainer.git
synced 2026-09-24 00:31:34 +00:00
* fix(torchtune): add validation for LoRA multi-node and immutable args Add two missing validations to validateTorchTune: 1. Reject LoRA fine-tuning when numNodes > 1. getRecipeAndConfig silently falls through to full_finetune_distributed in this case, discarding LoRA args without any user-visible error. 2. Reject immutable runtime configs (output_dir, tokenizer.path, checkpointer.checkpoint_dir, tokenizer.merges_file) in spec.trainer.args. These are injected by the runtime via extractOverridesFromRuntime and must not be overridden by the user. Resolves the TODO added by @Electronic-Waste in torchtune.go. Signed-off-by: Krish Garg <[email protected]> Signed-off-by: krishdef7 <[email protected]> * fix(runtimes): add validation for LoRA/QLoRA multi-node and immutable trainer args Signed-off-by: krishdef7 <[email protected]> --------- Signed-off-by: Krish Garg <[email protected]> Signed-off-by: krishdef7 <[email protected]>