mirror of
https://github.com/hanzoai/ai.git
synced 2026-11-20 14:13:23 +00:00
TestMain called os.Exit(0) before m.Run() whenever no seeded database was
present. That bought an honest "these did not run" for the integration tests at
the price of the entire package: `go test ./object/` printed a cheerful "ok" in
0.1s having executed NOTHING — all 182 tests, including the ~150 that touch no
database at all.
That is false assurance, and it was not theoretical. It concealed a real defect
for as long as it existed:
--- FAIL: TestCrawlStorageEndpoint
host = "minio.hanzo.svc.cluster.local:9000", want "s3.hanzo.svc:9000"
The crawl-storage default still named a MinIO Service that no longer exists in
the cluster (verified: no minio Service in any namespace; s3 is the replacement).
crawlStorageDefaultEndpoint had already been corrected to s3.hanzo.svc:9000 with
a comment explaining exactly this, but conf/app.conf still SET the key to the
dead host, so the corrected constant could never apply and the test guarding it
could never report. conf/app.conf now leaves it empty and the constant is the
single source of the default. (Production was unaffected — its mounted app.conf
carries no such line — so this bit local dev and any deploy shipping the repo
default.)
Only TWO tests in this package acquire a store, so the gate belongs in THEM, not
over all 182. requireStore(t) skips on an absent database and the panics that
made a missing store abort the whole binary are now t.Skip/t.Fatalf. Both
packages' helpers defer to ONE probe (object.StoreProbeReason, the standard
export_test.go idiom) so there is no second copy to drift.
Measured, before -> after: 0 tests executed -> 153 PASS, 0 FAIL, 26 honest SKIP,
0 panics. Full suite: 22 packages ok, 0 FAIL.
Co-authored-by: Hanzo Dev <[email protected]>
110 lines
2.7 KiB
Go
110 lines
2.7 KiB
Go
// Copyright 2023-2025 Hanzo AI Inc. All Rights Reserved.
|
|
// Portions Copyright 2024 The OpenAgent Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
//go:build !skipCi
|
|
|
|
package object_test
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/hanzoai/ai/controllers"
|
|
iam "github.com/hanzoai/ai/internal/iam"
|
|
"github.com/hanzoai/ai/object"
|
|
)
|
|
|
|
var userTag = "user"
|
|
|
|
func TestUpdateMessagesForName(t *testing.T) {
|
|
requireStore(t)
|
|
object.InitConfig()
|
|
controllers.InitAuthConfig()
|
|
users, err := iam.GetUsers()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
userMap := map[string]*iam.User{}
|
|
for _, user := range users {
|
|
if user.Tag != userTag {
|
|
continue
|
|
}
|
|
userMap[user.Name] = user
|
|
}
|
|
messages, err := object.GetGlobalMessages()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
for i, message := range messages {
|
|
user, ok := userMap[message.User]
|
|
if ok {
|
|
message.User = user.DisplayName
|
|
}
|
|
if message.Author != "AI" {
|
|
user, ok = userMap[message.Author]
|
|
if ok {
|
|
message.Author = user.DisplayName
|
|
}
|
|
}
|
|
fmt.Printf("[%d/%d] message: %s, organization: %s, user: %s, author: %s\n", i+1, len(messages), message.Name, message.Organization, message.User, message.Author)
|
|
_, err = object.UpdateMessage(message.GetId(), message, false)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestUpdateChatsForName(t *testing.T) {
|
|
requireStore(t)
|
|
object.InitConfig()
|
|
controllers.InitAuthConfig()
|
|
users, err := iam.GetUsers()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
userMap := map[string]*iam.User{}
|
|
for _, user := range users {
|
|
if user.Tag != userTag {
|
|
continue
|
|
}
|
|
userMap[user.Name] = user
|
|
}
|
|
chats, err := object.GetGlobalChats()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
for i, chat := range chats {
|
|
user, ok := userMap[chat.User]
|
|
if ok {
|
|
chat.User = user.DisplayName
|
|
}
|
|
user, ok = userMap[chat.Users[0]]
|
|
if ok {
|
|
chat.Users[0] = user.DisplayName
|
|
}
|
|
fmt.Printf("[%d/%d] chat: %s, store: %s, organization: %s, user1: %s, users: %v\n", i+1, len(chats), chat.Name, chat.Store, chat.Organization, chat.User1, chat.Users)
|
|
_, err = object.UpdateChat(chat.GetId(), chat)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestUpdateMessagesAndChatsForName(t *testing.T) {
|
|
requireStore(t)
|
|
TestUpdateMessagesForName(t)
|
|
TestUpdateChatsForName(t)
|
|
}
|