Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/16529 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mikeharder <[email protected]>
eval-scripts (CI glue + pinned Vally CLI)
This folder holds the TypeScript glue the Vally eval CI runs (matrix sharding, the shard
runner, the JUnit summary) and pins the @microsoft/vally-cli
version those shards install. The CLI and its full transitive dependency tree are locked by
the committed package-lock.json instead of resolved fresh from semver ranges on every run.
It lives under eng/common so it syncs to every repo that consumes the shared eval pipeline
templates.
- The only dependency should be
@microsoft/vally-cli, pinned to the version CI should evaluate with. package-lock.jsonmust be committed sonpm ciis deterministic.
TypeScript (no build step)
The *.ts sources run directly through Node's native type stripping (erasable syntax only —
no enum/namespace/parameter properties, no emit). CI pins Node 22.x, which strips types
unflagged on >=22.18; the pipeline node invocations and the npm test script pass
--experimental-strip-types so the same sources also run on older local Node (>=22.6), which
prints a harmless ExperimentalWarning. Relative imports use explicit .ts specifiers, as Node requires.
Vendored files
lib/exec.tswas copied from azure-rest-api-specs (.github/shared/src/exec.js@ef7dd74c13aa9ca12b67b33b9dc4b5d1419a46f0) and ported to TypeScript. It lives here undereng/common(rather than the specs repo's.github/sharedpath) so it travels with the eng/common sync into the language repos. Re-vendor from upstream rather than editing locally; see azure-sdk-tools#16296 for the plan to share these primitives instead of copying.
Updating the Vally CLI version
- Bump
@microsoft/vally-cliinpackage.json. - Run
npm installlocally to refreshpackage-lock.json. - Commit both files in the same PR. The eval pipelines' path triggers include
eng/common/scripts/eval/**, so CI re-runs against the new version automatically.
Local use
Reproduce what CI does by installing from the same lockfile and invoking the local binary:
cd eng/common/scripts/eval
npm ci
cd ../../../..
./eng/common/scripts/eval/node_modules/.bin/vally lint .
This matches the CI job step-for-step, so a green local run on the current lockfile means a green CI run.
A global install (npm install -g @microsoft/vally-cli@<version>) still works for ad-hoc iteration, but it won't match the transitive dependency tree CI uses and isn't a substitute for the steps above when validating a version bump.