mirror of
https://github.com/hanzoai/base.git
synced 2026-10-21 03:41:50 +00:00
zeekayandHanzo Dev
9b3c7c7a80
NewBaseCollection takes the id as an optional argument and nothing forbids it matching the name, so callers set it that way to keep a stable, readable id across deployments. The name/id collision check then looked up any collection whose id equals the new name and refused if it found one — including the collection being saved. So such a collection was created happily, because nothing existed yet to collide with, and could never be changed afterwards. Every later schema edit — one field, one index — failed on restart with "The name must not match an existing collection id", describing a collision with itself. A deployment either stayed on the old schema or stopped booting. Found from the other end: luxfi/bank creates every collection as NewBaseCollection(name, name) and its daemon would not start against an existing database once a new index was added to accounts. The check keeps its real job — another collection's id is still not available as a name, or FindCollectionByNameOrId would have two answers — and that half is asserted separately, since it passed before this change and has to keep passing. Co-authored-by: Hanzo Dev <[email protected]>
75 lines
2.3 KiB
Go
75 lines
2.3 KiB
Go
package core_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/hanzoai/base/core"
|
|
"github.com/hanzoai/base/tests"
|
|
)
|
|
|
|
// A collection may be created with its id set to its own name — NewBaseCollection
|
|
// takes the id as an optional argument and nothing forbids the two matching, and
|
|
// callers do it to keep a stable, readable id across deployments.
|
|
//
|
|
// The name/id collision check has to exclude the collection being saved. It did
|
|
// not, so it found the collection ITSELF and refused: such a collection passed
|
|
// creation (nothing to collide with yet) and could never be updated again. Every
|
|
// later schema change — a new field, a new index — died at startup with "The name
|
|
// must not match an existing collection id", and the deployment stayed on the old
|
|
// schema or stopped booting.
|
|
func TestCollectionWithIdEqualToItsNameCanBeUpdated(t *testing.T) {
|
|
app, err := tests.NewTestApp()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer app.Cleanup()
|
|
|
|
c := core.NewBaseCollection("ledger", "ledger")
|
|
c.Fields.Add(&core.TextField{Name: "memo"})
|
|
if err := app.Save(c); err != nil {
|
|
t.Fatalf("create: %v", err)
|
|
}
|
|
|
|
// The upgrade an existing deployment performs on restart.
|
|
again, err := app.FindCollectionByNameOrId("ledger")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
again.Fields.Add(&core.NumberField{Name: "amount"})
|
|
if err := app.Save(again); err != nil {
|
|
t.Fatalf("update: %v — a collection whose id is its own name cannot be changed", err)
|
|
}
|
|
|
|
got, err := app.FindCollectionByNameOrId("ledger")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got.Fields.GetByName("amount") == nil {
|
|
t.Fatal("the new field was not saved")
|
|
}
|
|
}
|
|
|
|
// The check still has to do its real job: a DIFFERENT collection's id is not
|
|
// available as a name, or FindCollectionByNameOrId would have two answers.
|
|
func TestANameStillCannotTakeAnotherCollectionsId(t *testing.T) {
|
|
app, err := tests.NewTestApp()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer app.Cleanup()
|
|
|
|
first := core.NewBaseCollection("alpha", "shared_id")
|
|
if err := app.Save(first); err != nil {
|
|
t.Fatalf("create first: %v", err)
|
|
}
|
|
|
|
second := core.NewBaseCollection("beta")
|
|
if err := app.Save(second); err != nil {
|
|
t.Fatalf("create second: %v", err)
|
|
}
|
|
second.Name = "shared_id" // the other collection's id
|
|
if err := app.Save(second); err == nil {
|
|
t.Fatal("a collection took another collection's id as its name")
|
|
}
|
|
}
|