Files
ca/server/service/admin/certificates_test.go
dissoupovandGitHub 27e411997c Added integration tests (#16)
* Refactor Backend service

* Added integration tests
2026-10-23 18:02:39 -05:00

161 lines
6.9 KiB
Go

package admin
import (
"context"
"database/sql"
"testing"
"time"
"github.com/cockroachdb/errors"
"github.com/effective-security/trustyca/api/pb"
"github.com/effective-security/trustyca/internal/db/model"
"github.com/effective-security/trustyca/internal/db/pgsql/query"
"github.com/effective-security/trustyca/mocks/mocktrustycadb"
"github.com/effective-security/trustyca/privpb"
"github.com/effective-security/xdb"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"
)
func TestService_ListCertificates(t *testing.T) {
ctx := context.Background()
ctrl := gomock.NewController(t)
defer ctrl.Finish()
caDb := mocktrustycadb.NewMockCaReadonlyDb(ctrl)
svc := Service{
ca: caDb,
}
rows := &model.CertificateResult{
Rows: []*model.Certificate{
{
ID: xdb.NewID(2),
OrgID: xdb.NewID(100),
ProjectID: xdb.NewID(201),
Ikid: "ikid-1",
Profile: "server",
Status: pb.CertificateStatus_Active,
Label: "edge-1",
},
{
ID: xdb.NewID(1),
Ikid: "ikid-0",
Status: pb.CertificateStatus_Revoked,
},
},
HasNextPage: true,
NextOffset: 2,
}
// every org and the platform
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).DoAndReturn(func(_ context.Context, req *query.ListCertificatesRequest) (*model.CertificateResult, error) {
assert.Equal(t, &query.ListCertificatesRequest{AllOrgs: true, Limit: 10}, req)
return rows, nil
})
res, err := svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{Limit: 10})
require.NoError(t, err)
require.Len(t, res.Certificates, 2)
assert.Equal(t, "100", res.Certificates[0].OrgID)
assert.Equal(t, "201", res.Certificates[0].ProjectID)
assert.Equal(t, "edge-1", res.Certificates[0].Label, "the support view keeps the client fields")
assert.Empty(t, res.Certificates[1].OrgID, "a platform certificate has no org")
require.NotNil(t, res.NextPage)
assert.Equal(t, 2, int(res.NextPage.Offset))
// an org, by issuer, profile, status and expiry
expiring := time.Date(2027, 1, 2, 3, 4, 5, 0, time.UTC)
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).DoAndReturn(func(_ context.Context, req *query.ListCertificatesRequest) (*model.CertificateResult, error) {
assert.Equal(t, &query.ListCertificatesRequest{
OrgID: 100,
IKID: "ikid-1",
Profile: "server",
Status: pb.CertificateStatus_Active,
ExpiringBefore: &expiring,
Limit: 5,
Offset: 10,
}, req)
return &model.CertificateResult{Rows: rows.Rows[:1]}, nil
})
res, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{
OrgID: "100",
IKID: "ikid-1",
Profile: "server",
Status: pb.CertificateStatus_Active,
ExpiringBefore: "2027-01-02T04:04:05+01:00",
Limit: 5,
Offset: 10,
})
require.NoError(t, err)
require.Len(t, res.Certificates, 1)
assert.Nil(t, res.NextPage)
// the platform only
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).DoAndReturn(func(_ context.Context, req *query.ListCertificatesRequest) (*model.CertificateResult, error) {
assert.True(t, req.Platform)
assert.False(t, req.AllOrgs)
return &model.CertificateResult{}, nil
})
res, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{Platform: true})
require.NoError(t, err)
assert.Empty(t, res.Certificates)
// by issuer without an org: the org of the issuer leads the index
caDb.EXPECT().GetIssuerBySKID(ctx, "ikid-1").Return(&model.Issuer{ID: xdb.NewID(10), OrgID: xdb.NewID(100)}, nil)
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).DoAndReturn(func(_ context.Context, req *query.ListCertificatesRequest) (*model.CertificateResult, error) {
assert.Equal(t, &query.ListCertificatesRequest{OrgID: 100, IKID: "ikid-1", Limit: 10}, req)
return &model.CertificateResult{Rows: rows.Rows[:1]}, nil
})
res, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{IKID: "ikid-1", Limit: 10})
require.NoError(t, err)
require.Len(t, res.Certificates, 1)
// a platform issuer
caDb.EXPECT().GetIssuerBySKID(ctx, "ikid-0").Return(&model.Issuer{ID: xdb.NewID(1)}, nil)
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).DoAndReturn(func(_ context.Context, req *query.ListCertificatesRequest) (*model.CertificateResult, error) {
assert.Equal(t, &query.ListCertificatesRequest{Platform: true, IKID: "ikid-0", Limit: 10}, req)
return &model.CertificateResult{Rows: rows.Rows[1:]}, nil
})
res, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{IKID: "ikid-0", Limit: 10})
require.NoError(t, err)
require.Len(t, res.Certificates, 1)
// no registered issuer has the key identifier: the certificates of a
// deleted issuer are listed across orgs
caDb.EXPECT().GetIssuerBySKID(ctx, "deleted").Return(nil, xdb.CheckNotFoundError(sql.ErrNoRows, "issuer", "deleted"))
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).DoAndReturn(func(_ context.Context, req *query.ListCertificatesRequest) (*model.CertificateResult, error) {
assert.Equal(t, &query.ListCertificatesRequest{AllOrgs: true, IKID: "deleted"}, req)
return &model.CertificateResult{Rows: rows.Rows[:1]}, nil
})
res, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{IKID: "deleted"})
require.NoError(t, err)
require.Len(t, res.Certificates, 1)
caDb.EXPECT().GetIssuerBySKID(ctx, "ikid-1").Return(nil, errors.New("db down"))
_, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{IKID: "ikid-1"})
assert.EqualError(t, err, "unexpected: unable to find issuer")
// with an org the issuer is not resolved
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).DoAndReturn(func(_ context.Context, req *query.ListCertificatesRequest) (*model.CertificateResult, error) {
assert.Equal(t, &query.ListCertificatesRequest{OrgID: 100, IKID: "ikid-9"}, req)
return &model.CertificateResult{}, nil
})
_, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{OrgID: "100", IKID: "ikid-9"})
require.NoError(t, err)
// the requests the service refuses
for _, tc := range []struct {
req *privpb.ListAllCertificatesRequest
err string
}{
{req: nil, err: "bad_request: missing request"},
{req: &privpb.ListAllCertificatesRequest{OrgID: "nope"}, err: "bad_request: invalid org ID"},
{req: &privpb.ListAllCertificatesRequest{ProjectID: "201"}, err: "bad_request: org ID is required with a project ID"},
{req: &privpb.ListAllCertificatesRequest{Cursor: "nope"}, err: "bad_request: invalid cursor"},
{req: &privpb.ListAllCertificatesRequest{ExpiringBefore: "tomorrow"}, err: "bad_request: invalid ExpiringBefore: RFC3339 time expected"},
} {
_, err := svc.ListCertificates(ctx, tc.req)
assert.EqualError(t, err, tc.err)
}
caDb.EXPECT().ListCertificates(ctx, gomock.Any()).Return(nil, errors.New("something happened"))
_, err = svc.ListCertificates(ctx, &privpb.ListAllCertificatesRequest{})
assert.EqualError(t, err, "unexpected: failed to list certificates")
}