mirror of
https://github.com/hanzoai/calendar.git
synced 2026-10-30 14:46:43 +00:00
* fix: remove @calcom/web imports from packages/features to eliminate circular dependency - Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts - Migrate useGeo hook to packages/features/geo/GeoContext.tsx - Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts - Migrate Calendar component to packages/features/calendars/weeklyview/components/ - Move test utilities (bookingScenario, fixtures) to packages/features/test/ - Update all imports in packages/features to use new locations - Add re-exports in apps/web for backward compatibility Co-Authored-By: [email protected] <[email protected]> * fix: delete original implementation files and fix type issues - Delete original calendar component files in apps/web (keep only re-export stubs) - Migrate OutOfOfficeInSlots to packages/features/bookings/components - Convert apps/web OutOfOfficeInSlots to re-export stub - Fix className vs class issue in Calendar.tsx - Fix @calcom/trpc import violation in user-table.ts by using structural type Co-Authored-By: [email protected] <[email protected]> * fix: add missing isGroup and contains fields to UserTableUser attributes type Co-Authored-By: [email protected] <[email protected]> * fix: update customRole type to match actual Prisma Role model Co-Authored-By: [email protected] <[email protected]> * fix build * fix * fix * cleanup weeklyview * fix * refactor to mv MemberPermissions to types package * add types dependency to features * fix * fix * fix * fix * fix * fix * rename * rename * migrate * migrate * migrate * fix * fix * fix * refactor: move test utilities from packages/features/test to tests/libs - Move bookingScenario utilities to tests/libs/bookingScenario - Move fixtures to tests/libs/fixtures - Update all imports in packages/features test files to use new location - Update all imports in apps/web test files to use new location - Eliminates duplication of test utilities between packages/features and apps/web Co-Authored-By: [email protected] <[email protected]> * fix: correct relative import paths for tests/libs in test files Co-Authored-By: [email protected] <[email protected]> * refactor: replace test utility implementations with re-exports to tests/libs Co-Authored-By: [email protected] <[email protected]> * fix: fix test import paths and move signup handler tests to apps/web Co-Authored-By: [email protected] <[email protected]> * fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features - Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency - Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib - Restore signup handlers and tests to packages/features/auth/signup/handlers - Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx Co-Authored-By: [email protected] <[email protected]> * fix: update recurring-event.test.ts imports to use tests/libs path Co-Authored-By: [email protected] <[email protected]> * refactor: delete test re-export files and update imports to use tests/libs directly Co-Authored-By: [email protected] <[email protected]> * fix: update remaining test imports to use tests/libs directly Co-Authored-By: [email protected] <[email protected]> * fix: update handleRecurringEventBooking calls to match function signature (1 arg) Co-Authored-By: [email protected] <[email protected]> * remove * migrate tests * migrate tests * refactor: update test mock imports by removing and using async for mock creators. * fix type errors * fix: add type assertion for MockUser in p2002.test-suite.ts Co-Authored-By: [email protected] <[email protected]> * fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path Co-Authored-By: [email protected] <[email protected]> * feat: create @calcom/testing package and migrate tests from /tests directory - Created new @calcom/testing package in /packages/testing - Moved all files from /tests to /packages/testing - Updated all imports across the codebase to use @calcom/testing alias - Removed /tests directory at root level This allows other packages like @calcom/features and @calcom/web to import testing utilities using the @calcom/testing alias instead of relative paths. Co-Authored-By: [email protected] <[email protected]> * fix * fix * fix: add missing useBookings export to @calcom/atoms package Co-Authored-By: [email protected] <[email protected]> * fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms Co-Authored-By: [email protected] <[email protected]> * chore: add @calcom/testing as explicit devDependency to packages that use it Co-Authored-By: [email protected] <[email protected]> * refactor: move setupVitest.ts into @calcom/testing package Co-Authored-By: [email protected] <[email protected]> * fix * chore: add biome rules to restrict @calcom/testing imports Co-Authored-By: [email protected] <[email protected]> * fix * rename libs to lib * rename libs to lib * add rule * add rule * refactor: remove @calcom/features imports from @calcom/testing - Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts - Replace ProfileRepository.generateProfileUid() with uuidv4() - Clone Tracking type into @calcom/testing/src/lib/types.ts - Update imports in expects.ts and getMockRequestDataForBooking.ts - Move source files into src/ folder - Move CalendarManager mock to @calcom/features Co-Authored-By: [email protected] <[email protected]> * fix: add explicit exports for nested paths in @calcom/testing Co-Authored-By: [email protected] <[email protected]> * improve * improve * fix * fix * fix type checks * fix type checks * fix type checks * fix tests --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
555 lines
16 KiB
TypeScript
555 lines
16 KiB
TypeScript
import {
|
|
TestData,
|
|
createBookingScenario,
|
|
getBooker,
|
|
getOrganizer,
|
|
getScenarioData,
|
|
getGoogleCalendarCredential,
|
|
Timezones,
|
|
} from "@calcom/testing/lib/bookingScenario/bookingScenario";
|
|
// TODO: we should rename this - it doesnt get a mockRequestDataForBooking - it just gets mock booking data.
|
|
import { getMockRequestDataForBooking } from "@calcom/testing/lib/bookingScenario/getMockRequestDataForBooking";
|
|
import { setupAndTeardown } from "@calcom/testing/lib/bookingScenario/setupAndTeardown";
|
|
|
|
import { describe, expect, vi, beforeAll } from "vitest";
|
|
|
|
import { SchedulingType } from "@calcom/prisma/enums";
|
|
import { BookingStatus } from "@calcom/prisma/enums";
|
|
import { test } from "@calcom/testing/lib/fixtures/fixtures";
|
|
|
|
import { getNewBookingHandler } from "./test/getNewBookingHandler";
|
|
|
|
// Local test runs sometime gets too slow
|
|
const timeout = process.env.CI ? 5000 : 20000;
|
|
|
|
const eventLength = 30;
|
|
|
|
const booker = getBooker({
|
|
email: "[email protected]",
|
|
name: "Booker",
|
|
});
|
|
|
|
const organizer = getOrganizer({
|
|
name: "Organizer",
|
|
email: "[email protected]",
|
|
id: 101,
|
|
schedules: [TestData.schedules.IstWorkHours],
|
|
});
|
|
|
|
const otherTeamMembers = [
|
|
{
|
|
name: "Other Team Member 1",
|
|
username: "other-team-member-1",
|
|
timeZone: Timezones["+5:30"],
|
|
// So, that it picks the first schedule from the list
|
|
defaultScheduleId: null,
|
|
email: "[email protected]",
|
|
id: 102,
|
|
// Has Evening shift
|
|
schedules: [TestData.schedules.IstEveningShift],
|
|
credentials: [getGoogleCalendarCredential()],
|
|
selectedCalendars: [TestData.selectedCalendars.google],
|
|
destinationCalendar: {
|
|
integration: TestData.apps["google-calendar"].type,
|
|
externalId: "[email protected]",
|
|
},
|
|
},
|
|
];
|
|
|
|
describe(
|
|
"handleNewBooking",
|
|
() => {
|
|
setupAndTeardown();
|
|
beforeAll(async () => {
|
|
vi.setSystemTime(new Date("2024-08-05")); //Monday
|
|
});
|
|
|
|
describe("Team Booking Limits", () => {
|
|
// This test fails on CI as handleNewBooking throws no_available_users_found_error error
|
|
// eslint-disable-next-line playwright/no-skipped-test
|
|
test(`Booking limits per week
|
|
`, async ({}) => {
|
|
const handleNewBooking = getNewBookingHandler();
|
|
await createBookingScenario(
|
|
getScenarioData({
|
|
eventTypes: [
|
|
{
|
|
id: 1,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
team: {
|
|
id: 1,
|
|
bookingLimits: { PER_WEEK: 2 },
|
|
includeManagedEventsInLimits: false,
|
|
},
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
{
|
|
id: 2,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
teamId: 1,
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
{
|
|
id: 3,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
},
|
|
],
|
|
teamId: 1,
|
|
schedulingType: SchedulingType.MANAGED,
|
|
},
|
|
{
|
|
id: 4,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
userId: 101,
|
|
parent: {
|
|
id: 3,
|
|
},
|
|
},
|
|
],
|
|
bookings: [
|
|
{
|
|
eventTypeId: 2,
|
|
userId: 101,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-06T03:30:00.000Z`,
|
|
endTime: `2024-08-06T04:00:00.000Z`,
|
|
},
|
|
{
|
|
eventTypeId: 1,
|
|
userId: 102,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-06T04:00:00.000Z`,
|
|
endTime: `2024-08-06T04:30:00.000Z`,
|
|
},
|
|
{
|
|
eventTypeId: 1,
|
|
userId: 102,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-06T04:30:00.000Z`,
|
|
endTime: `2024-08-06T05:00:00.000Z`,
|
|
},
|
|
{
|
|
// managed event type doesn't count, includeManagedEventsInLimits is false
|
|
eventTypeId: 4,
|
|
userId: 101,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-07T04:30:00.000Z`,
|
|
endTime: `2024-08-07T05:00:00.000Z`,
|
|
},
|
|
],
|
|
organizer,
|
|
usersApartFromOrganizer: otherTeamMembers,
|
|
})
|
|
);
|
|
|
|
const mockBookingWithinLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-08-08T04:00:00.000Z`,
|
|
end: `2024-08-08T04:30:00.000Z`,
|
|
eventTypeId: 1,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
const createdBooking = await handleNewBooking({
|
|
bookingData: mockBookingWithinLimit,
|
|
});
|
|
|
|
expect(createdBooking.responses).toEqual(
|
|
expect.objectContaining({
|
|
email: booker.email,
|
|
name: booker.name,
|
|
})
|
|
);
|
|
|
|
const mockBookingAboveLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-08-08T04:00:00.000Z`,
|
|
end: `2024-08-08T04:30:00.000Z`,
|
|
eventTypeId: 1,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
// this is the third team booking of this week for user 101, limit reached
|
|
await expect(
|
|
async () =>
|
|
await handleNewBooking({
|
|
bookingData: mockBookingAboveLimit,
|
|
})
|
|
).rejects.toThrowError("no_available_users_found_error");
|
|
});
|
|
|
|
test(`Booking limits per day`, async ({}) => {
|
|
const handleNewBooking = getNewBookingHandler();
|
|
await createBookingScenario(
|
|
getScenarioData({
|
|
eventTypes: [
|
|
{
|
|
id: 1,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
team: {
|
|
id: 1,
|
|
bookingLimits: { PER_DAY: 1 },
|
|
},
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
{
|
|
id: 2,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
teamId: 1,
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
],
|
|
bookings: [],
|
|
organizer,
|
|
usersApartFromOrganizer: otherTeamMembers,
|
|
})
|
|
);
|
|
|
|
const mockBookingWithinLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-08-07T04:30:00.000Z`,
|
|
end: `2024-08-07T05:00:00.000Z`,
|
|
eventTypeId: 1,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
const createdBooking = await handleNewBooking({
|
|
bookingData: mockBookingWithinLimit,
|
|
});
|
|
|
|
expect(createdBooking.responses).toEqual(
|
|
expect.objectContaining({
|
|
email: booker.email,
|
|
name: booker.name,
|
|
})
|
|
);
|
|
|
|
const mockBookingAboveLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-08-07T04:00:00.000Z`,
|
|
end: `2024-08-07T04:30:00.000Z`,
|
|
eventTypeId: 2,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
// this is the second team booking of this day for user 101, limit reached
|
|
await expect(
|
|
async () =>
|
|
await handleNewBooking({
|
|
bookingData: mockBookingAboveLimit,
|
|
})
|
|
).rejects.toThrowError("no_available_users_found_error");
|
|
});
|
|
|
|
test(`Booking limits per month`, async ({}) => {
|
|
const handleNewBooking = getNewBookingHandler();
|
|
await createBookingScenario(
|
|
getScenarioData({
|
|
eventTypes: [
|
|
{
|
|
id: 1,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
team: {
|
|
id: 1,
|
|
bookingLimits: { PER_MONTH: 4 },
|
|
includeManagedEventsInLimits: true,
|
|
},
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
{
|
|
id: 2,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
teamId: 1,
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
{
|
|
id: 3,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
},
|
|
],
|
|
teamId: 1,
|
|
schedulingType: SchedulingType.MANAGED,
|
|
},
|
|
{
|
|
id: 4,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
userId: 101,
|
|
parent: {
|
|
id: 3,
|
|
},
|
|
},
|
|
],
|
|
bookings: [
|
|
{
|
|
eventTypeId: 1,
|
|
userId: 101,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-03T03:30:00.000Z`,
|
|
endTime: `2024-08-03T04:00:00.000Z`,
|
|
},
|
|
{
|
|
eventTypeId: 2,
|
|
userId: 101,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-22T03:30:00.000Z`,
|
|
endTime: `2024-08-22T04:00:00.000Z`,
|
|
},
|
|
{
|
|
//managed event type also counts towards limits
|
|
eventTypeId: 4,
|
|
userId: 101,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-15T03:30:00.000Z`,
|
|
endTime: `2024-08-15T04:00:00.000Z`,
|
|
},
|
|
],
|
|
organizer,
|
|
usersApartFromOrganizer: otherTeamMembers,
|
|
})
|
|
);
|
|
|
|
const mockBookingWithinLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-08-29T04:30:00.000Z`,
|
|
end: `2024-08-29T05:00:00.000Z`,
|
|
eventTypeId: 1,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
const createdBooking = await handleNewBooking({
|
|
bookingData: mockBookingWithinLimit,
|
|
});
|
|
|
|
expect(createdBooking.responses).toEqual(
|
|
expect.objectContaining({
|
|
email: booker.email,
|
|
name: booker.name,
|
|
})
|
|
);
|
|
|
|
const mockBookingAboveLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-08-25T04:00:00.000Z`,
|
|
end: `2024-08-25T04:30:00.000Z`,
|
|
eventTypeId: 2,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
// this is the firth team booking (incl. managed) of this month for user 101, limit reached
|
|
await expect(
|
|
async () =>
|
|
await handleNewBooking({
|
|
bookingData: mockBookingAboveLimit,
|
|
})
|
|
).rejects.toThrowError("no_available_users_found_error");
|
|
});
|
|
|
|
test(`Booking limits per year`, async ({}) => {
|
|
const handleNewBooking = getNewBookingHandler();
|
|
await createBookingScenario(
|
|
getScenarioData({
|
|
eventTypes: [
|
|
{
|
|
id: 1,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
team: {
|
|
id: 1,
|
|
bookingLimits: { PER_YEAR: 3 },
|
|
includeManagedEventsInLimits: true,
|
|
},
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
{
|
|
id: 2,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
isFixed: true,
|
|
},
|
|
],
|
|
teamId: 1,
|
|
schedulingType: SchedulingType.COLLECTIVE,
|
|
},
|
|
{
|
|
id: 3,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
hosts: [
|
|
{
|
|
userId: 101,
|
|
},
|
|
],
|
|
teamId: 1,
|
|
schedulingType: SchedulingType.MANAGED,
|
|
},
|
|
{
|
|
id: 4,
|
|
slotInterval: eventLength,
|
|
length: eventLength,
|
|
userId: 101,
|
|
parent: {
|
|
id: 3,
|
|
},
|
|
},
|
|
],
|
|
bookings: [
|
|
{
|
|
eventTypeId: 1,
|
|
userId: 101,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-02-03T03:30:00.000Z`,
|
|
endTime: `2024-02-03T04:00:00.000Z`,
|
|
},
|
|
{
|
|
eventTypeId: 4,
|
|
userId: 101,
|
|
status: BookingStatus.ACCEPTED,
|
|
startTime: `2024-08-03T03:30:00.000Z`,
|
|
endTime: `2024-08-03T04:00:00.000Z`,
|
|
},
|
|
],
|
|
organizer,
|
|
usersApartFromOrganizer: otherTeamMembers,
|
|
})
|
|
);
|
|
|
|
const mockBookingWithinLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-08-29T04:30:00.000Z`,
|
|
end: `2024-08-29T05:00:00.000Z`,
|
|
eventTypeId: 2,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
const createdBooking = await handleNewBooking({
|
|
bookingData: mockBookingWithinLimit,
|
|
});
|
|
|
|
expect(createdBooking.responses).toEqual(
|
|
expect.objectContaining({
|
|
email: booker.email,
|
|
name: booker.name,
|
|
})
|
|
);
|
|
|
|
const mockBookingAboveLimit = getMockRequestDataForBooking({
|
|
data: {
|
|
start: `2024-11-25T04:00:00.000Z`,
|
|
end: `2024-11-25T04:30:00.000Z`,
|
|
eventTypeId: 2,
|
|
responses: {
|
|
email: booker.email,
|
|
name: booker.name,
|
|
location: { optionValue: "", value: "New York" },
|
|
},
|
|
},
|
|
});
|
|
|
|
await expect(
|
|
async () =>
|
|
await handleNewBooking({
|
|
bookingData: mockBookingAboveLimit,
|
|
})
|
|
).rejects.toThrowError("no_available_users_found_error");
|
|
});
|
|
});
|
|
},
|
|
timeout
|
|
);
|