Files
Benny JooGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
f5d345b133 refactor: remove @calcom/web imports from @calcom/features and add @calcom/testing package (#26480)
* fix: remove @calcom/web imports from packages/features to eliminate circular dependency

- Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts
- Migrate useGeo hook to packages/features/geo/GeoContext.tsx
- Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts
- Migrate Calendar component to packages/features/calendars/weeklyview/components/
- Move test utilities (bookingScenario, fixtures) to packages/features/test/
- Update all imports in packages/features to use new locations
- Add re-exports in apps/web for backward compatibility

Co-Authored-By: [email protected] <[email protected]>

* fix: delete original implementation files and fix type issues

- Delete original calendar component files in apps/web (keep only re-export stubs)
- Migrate OutOfOfficeInSlots to packages/features/bookings/components
- Convert apps/web OutOfOfficeInSlots to re-export stub
- Fix className vs class issue in Calendar.tsx
- Fix @calcom/trpc import violation in user-table.ts by using structural type

Co-Authored-By: [email protected] <[email protected]>

* fix: add missing isGroup and contains fields to UserTableUser attributes type

Co-Authored-By: [email protected] <[email protected]>

* fix: update customRole type to match actual Prisma Role model

Co-Authored-By: [email protected] <[email protected]>

* fix build

* fix

* fix

* cleanup weeklyview

* fix

* refactor to mv MemberPermissions to types package

* add types dependency to features

* fix

* fix

* fix

* fix

* fix

* fix

* rename

* rename

* migrate

* migrate

* migrate

* fix

* fix

* fix

* refactor: move test utilities from packages/features/test to tests/libs

- Move bookingScenario utilities to tests/libs/bookingScenario
- Move fixtures to tests/libs/fixtures
- Update all imports in packages/features test files to use new location
- Update all imports in apps/web test files to use new location
- Eliminates duplication of test utilities between packages/features and apps/web

Co-Authored-By: [email protected] <[email protected]>

* fix: correct relative import paths for tests/libs in test files

Co-Authored-By: [email protected] <[email protected]>

* refactor: replace test utility implementations with re-exports to tests/libs

Co-Authored-By: [email protected] <[email protected]>

* fix: fix test import paths and move signup handler tests to apps/web

Co-Authored-By: [email protected] <[email protected]>

* fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features

- Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency
- Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib
- Restore signup handlers and tests to packages/features/auth/signup/handlers
- Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx

Co-Authored-By: [email protected] <[email protected]>

* fix: update recurring-event.test.ts imports to use tests/libs path

Co-Authored-By: [email protected] <[email protected]>

* refactor: delete test re-export files and update imports to use tests/libs directly

Co-Authored-By: [email protected] <[email protected]>

* fix: update remaining test imports to use tests/libs directly

Co-Authored-By: [email protected] <[email protected]>

* fix: update handleRecurringEventBooking calls to match function signature (1 arg)

Co-Authored-By: [email protected] <[email protected]>

* remove

* migrate tests

* migrate tests

* refactor: update test mock imports by removing  and using async  for mock creators.

* fix type errors

* fix: add type assertion for MockUser in p2002.test-suite.ts

Co-Authored-By: [email protected] <[email protected]>

* fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path

Co-Authored-By: [email protected] <[email protected]>

* feat: create @calcom/testing package and migrate tests from /tests directory

- Created new @calcom/testing package in /packages/testing
- Moved all files from /tests to /packages/testing
- Updated all imports across the codebase to use @calcom/testing alias
- Removed /tests directory at root level

This allows other packages like @calcom/features and @calcom/web to import
testing utilities using the @calcom/testing alias instead of relative paths.

Co-Authored-By: [email protected] <[email protected]>

* fix

* fix

* fix: add missing useBookings export to @calcom/atoms package

Co-Authored-By: [email protected] <[email protected]>

* fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms

Co-Authored-By: [email protected] <[email protected]>

* chore: add @calcom/testing as explicit devDependency to packages that use it

Co-Authored-By: [email protected] <[email protected]>

* refactor: move setupVitest.ts into @calcom/testing package

Co-Authored-By: [email protected] <[email protected]>

* fix

* chore: add biome rules to restrict @calcom/testing imports

Co-Authored-By: [email protected] <[email protected]>

* fix

* rename libs to lib

* rename libs to lib

* add rule

* add rule

* refactor: remove @calcom/features imports from @calcom/testing

- Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts
- Replace ProfileRepository.generateProfileUid() with uuidv4()
- Clone Tracking type into @calcom/testing/src/lib/types.ts
- Update imports in expects.ts and getMockRequestDataForBooking.ts
- Move source files into src/ folder
- Move CalendarManager mock to @calcom/features

Co-Authored-By: [email protected] <[email protected]>

* fix: add explicit exports for nested paths in @calcom/testing

Co-Authored-By: [email protected] <[email protected]>

* improve

* improve

* fix

* fix

* fix type checks

* fix type checks

* fix type checks

* fix tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-01-08 16:59:11 +09:00

434 lines
12 KiB
TypeScript

/**
* These tests are unit tests that test the email verification functionality in the booking flow
* - Test missing verification code scenario
* - Test invalid verification code scenario
* - Test successful verification scenario
* - Test rate limiting behavior
*/
import {
createBookingScenario,
getBooker,
getOrganizer,
TestData,
getScenarioData,
} from "@calcom/testing/lib/bookingScenario/bookingScenario";
import { getMockRequestDataForBooking } from "@calcom/testing/lib/bookingScenario/getMockRequestDataForBooking";
import { setupAndTeardown } from "@calcom/testing/lib/bookingScenario/setupAndTeardown";
import { vi, describe, expect, beforeEach } from "vitest";
import { test } from "@calcom/testing/lib/fixtures/fixtures";
import { getNewBookingHandler } from "./getNewBookingHandler";
vi.mock("@calcom/features/auth/lib/verifyCodeUnAuthenticated", () => ({
verifyCodeUnAuthenticated: vi.fn(),
}));
const timeout = process.env.CI ? 5000 : 20000;
describe("handleNewBooking - Email Verification", () => {
setupAndTeardown();
beforeEach(() => {
vi.clearAllMocks();
});
describe("Email Verification Required", () => {
test(
"should throw error when email verification is required but no verification code is provided",
async () => {
const handleNewBooking = getNewBookingHandler();
const { verifyCodeUnAuthenticated } = await import(
"@calcom/features/auth/lib/verifyCodeUnAuthenticated"
);
const booker = getBooker({
email: "[email protected]",
name: "Booker",
});
const organizer = getOrganizer({
name: "Organizer",
email: "[email protected]",
id: 101,
schedules: [TestData.schedules.IstWorkHours],
});
const scenarioData = getScenarioData({
eventTypes: [
{
id: 1,
slotInterval: 15,
length: 30,
users: [
{
id: 101,
},
],
requiresBookerEmailVerification: true,
},
],
organizer,
});
await createBookingScenario(scenarioData);
const mockBookingData = getMockRequestDataForBooking({
data: {
eventTypeId: 1,
responses: {
email: booker.email,
name: booker.name,
location: { optionValue: "", value: "integrations:daily" },
},
},
});
await expect(handleNewBooking({ bookingData: mockBookingData })).rejects.toThrow(
expect.objectContaining({
statusCode: 400,
message: "email_verification_required",
})
);
expect(verifyCodeUnAuthenticated).not.toHaveBeenCalled();
},
timeout
);
test(
"should throw error when email verification is required and verification code is invalid",
async () => {
const handleNewBooking = getNewBookingHandler();
const { verifyCodeUnAuthenticated } = await import(
"@calcom/features/auth/lib/verifyCodeUnAuthenticated"
);
vi.mocked(verifyCodeUnAuthenticated).mockRejectedValue(new Error("Invalid verification code"));
const booker = getBooker({
email: "[email protected]",
name: "Booker",
});
const organizer = getOrganizer({
name: "Organizer",
email: "[email protected]",
id: 101,
schedules: [TestData.schedules.IstWorkHours],
});
const scenarioData = getScenarioData({
eventTypes: [
{
id: 1,
slotInterval: 15,
length: 30,
users: [
{
id: 101,
},
],
requiresBookerEmailVerification: true,
},
],
organizer,
});
await createBookingScenario(scenarioData);
const mockBookingData = getMockRequestDataForBooking({
data: {
eventTypeId: 1,
responses: {
email: booker.email,
name: booker.name,
location: { optionValue: "", value: "integrations:daily" },
},
verificationCode: "invalid-code",
},
});
await expect(handleNewBooking({ bookingData: mockBookingData })).rejects.toThrow(
expect.objectContaining({
statusCode: 400,
message: "invalid_verification_code",
})
);
expect(verifyCodeUnAuthenticated).toHaveBeenCalledWith(booker.email, "invalid-code");
},
timeout
);
test(
"should successfully create booking when email verification is required and valid verification code is provided",
async () => {
const handleNewBooking = getNewBookingHandler();
const { verifyCodeUnAuthenticated } = await import(
"@calcom/features/auth/lib/verifyCodeUnAuthenticated"
);
vi.mocked(verifyCodeUnAuthenticated).mockResolvedValue(undefined);
const booker = getBooker({
email: "[email protected]",
name: "Booker",
});
const organizer = getOrganizer({
name: "Organizer",
email: "[email protected]",
id: 101,
schedules: [TestData.schedules.IstWorkHours],
});
const scenarioData = getScenarioData({
eventTypes: [
{
id: 1,
slotInterval: 15,
length: 30,
users: [
{
id: 101,
},
],
requiresBookerEmailVerification: true,
},
],
organizer,
});
await createBookingScenario(scenarioData);
const mockBookingData = getMockRequestDataForBooking({
data: {
eventTypeId: 1,
responses: {
email: booker.email,
name: booker.name,
location: { optionValue: "", value: "integrations:daily" },
},
verificationCode: "valid-code",
},
});
const result = await handleNewBooking({ bookingData: mockBookingData });
expect(result).toBeDefined();
expect(result.uid).toBeDefined();
expect(verifyCodeUnAuthenticated).toHaveBeenCalledWith(booker.email, "valid-code");
},
timeout
);
test(
"should handle rate limiting error from verification service",
async () => {
const handleNewBooking = getNewBookingHandler();
const { verifyCodeUnAuthenticated } = await import(
"@calcom/features/auth/lib/verifyCodeUnAuthenticated"
);
const rateLimitError = new Error("Rate limit exceeded");
rateLimitError.name = "RateLimitError";
vi.mocked(verifyCodeUnAuthenticated).mockRejectedValue(rateLimitError);
const booker = getBooker({
email: "[email protected]",
name: "Booker",
});
const organizer = getOrganizer({
name: "Organizer",
email: "[email protected]",
id: 101,
schedules: [TestData.schedules.IstWorkHours],
});
const scenarioData = getScenarioData({
eventTypes: [
{
id: 1,
slotInterval: 15,
length: 30,
users: [
{
id: 101,
},
],
requiresBookerEmailVerification: true,
},
],
organizer,
});
await createBookingScenario(scenarioData);
const mockBookingData = getMockRequestDataForBooking({
data: {
eventTypeId: 1,
responses: {
email: booker.email,
name: booker.name,
location: { optionValue: "", value: "integrations:daily" },
},
verificationCode: "some-code",
},
});
await expect(handleNewBooking({ bookingData: mockBookingData })).rejects.toThrow(
expect.objectContaining({
statusCode: 400,
message: "invalid_verification_code",
})
);
expect(verifyCodeUnAuthenticated).toHaveBeenCalledWith(booker.email, "some-code");
},
timeout
);
test(
"should proceed normally when email verification is not required",
async () => {
const handleNewBooking = getNewBookingHandler();
const { verifyCodeUnAuthenticated } = await import(
"@calcom/features/auth/lib/verifyCodeUnAuthenticated"
);
const booker = getBooker({
email: "[email protected]",
name: "Booker",
});
const organizer = getOrganizer({
name: "Organizer",
email: "[email protected]",
id: 101,
schedules: [TestData.schedules.IstWorkHours],
});
const scenarioData = getScenarioData({
eventTypes: [
{
id: 1,
slotInterval: 15,
length: 30,
users: [
{
id: 101,
},
],
requiresBookerEmailVerification: false,
},
],
organizer,
});
await createBookingScenario(scenarioData);
const mockBookingData = getMockRequestDataForBooking({
data: {
eventTypeId: 1,
responses: {
email: booker.email,
name: booker.name,
location: { optionValue: "", value: "integrations:daily" },
},
},
});
const result = await handleNewBooking({ bookingData: mockBookingData });
expect(result).toBeDefined();
expect(result.uid).toBeDefined();
expect(verifyCodeUnAuthenticated).not.toHaveBeenCalled();
},
timeout
);
test(
"should allow rescheduling without email verification even when requiresBookerEmailVerification is true",
async () => {
const handleNewBooking = getNewBookingHandler();
const { verifyCodeUnAuthenticated } = await import(
"@calcom/features/auth/lib/verifyCodeUnAuthenticated"
);
const booker = getBooker({
email: "[email protected]",
name: "Booker",
});
const organizer = getOrganizer({
name: "Organizer",
email: "[email protected]",
id: 101,
schedules: [TestData.schedules.IstWorkHours],
});
const scenarioData = getScenarioData({
eventTypes: [
{
id: 1,
slotInterval: 15,
length: 30,
users: [
{
id: 101,
},
],
requiresBookerEmailVerification: true,
},
],
organizer,
bookings: [
{
uid: "existing-booking-uid",
eventTypeId: 1,
userId: 101,
status: "ACCEPTED",
startTime: new Date(Date.now() + 24 * 60 * 60 * 1000).toISOString(), // tomorrow
endTime: new Date(Date.now() + 24 * 60 * 60 * 1000 + 30 * 60 * 1000).toISOString(), // tomorrow + 30 min
attendees: [
{
email: booker.email,
name: booker.name,
timeZone: "Asia/Kolkata",
},
],
},
],
});
await createBookingScenario(scenarioData);
const mockBookingData = getMockRequestDataForBooking({
data: {
eventTypeId: 1,
rescheduleUid: "existing-booking-uid",
responses: {
email: booker.email,
name: booker.name,
location: { optionValue: "", value: "integrations:daily" },
},
},
});
const result = await handleNewBooking({ bookingData: mockBookingData });
expect(result).toBeDefined();
expect(result.uid).toBeDefined();
expect(verifyCodeUnAuthenticated).not.toHaveBeenCalled();
},
timeout
);
});
});