Files
calendar/packages/features/delegation-credentials/repositories/DelegationCredentialRepository.test.ts
Benny JooGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
f5d345b133 refactor: remove @calcom/web imports from @calcom/features and add @calcom/testing package (#26480)
* fix: remove @calcom/web imports from packages/features to eliminate circular dependency

- Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts
- Migrate useGeo hook to packages/features/geo/GeoContext.tsx
- Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts
- Migrate Calendar component to packages/features/calendars/weeklyview/components/
- Move test utilities (bookingScenario, fixtures) to packages/features/test/
- Update all imports in packages/features to use new locations
- Add re-exports in apps/web for backward compatibility

Co-Authored-By: [email protected] <[email protected]>

* fix: delete original implementation files and fix type issues

- Delete original calendar component files in apps/web (keep only re-export stubs)
- Migrate OutOfOfficeInSlots to packages/features/bookings/components
- Convert apps/web OutOfOfficeInSlots to re-export stub
- Fix className vs class issue in Calendar.tsx
- Fix @calcom/trpc import violation in user-table.ts by using structural type

Co-Authored-By: [email protected] <[email protected]>

* fix: add missing isGroup and contains fields to UserTableUser attributes type

Co-Authored-By: [email protected] <[email protected]>

* fix: update customRole type to match actual Prisma Role model

Co-Authored-By: [email protected] <[email protected]>

* fix build

* fix

* fix

* cleanup weeklyview

* fix

* refactor to mv MemberPermissions to types package

* add types dependency to features

* fix

* fix

* fix

* fix

* fix

* fix

* rename

* rename

* migrate

* migrate

* migrate

* fix

* fix

* fix

* refactor: move test utilities from packages/features/test to tests/libs

- Move bookingScenario utilities to tests/libs/bookingScenario
- Move fixtures to tests/libs/fixtures
- Update all imports in packages/features test files to use new location
- Update all imports in apps/web test files to use new location
- Eliminates duplication of test utilities between packages/features and apps/web

Co-Authored-By: [email protected] <[email protected]>

* fix: correct relative import paths for tests/libs in test files

Co-Authored-By: [email protected] <[email protected]>

* refactor: replace test utility implementations with re-exports to tests/libs

Co-Authored-By: [email protected] <[email protected]>

* fix: fix test import paths and move signup handler tests to apps/web

Co-Authored-By: [email protected] <[email protected]>

* fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features

- Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency
- Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib
- Restore signup handlers and tests to packages/features/auth/signup/handlers
- Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx

Co-Authored-By: [email protected] <[email protected]>

* fix: update recurring-event.test.ts imports to use tests/libs path

Co-Authored-By: [email protected] <[email protected]>

* refactor: delete test re-export files and update imports to use tests/libs directly

Co-Authored-By: [email protected] <[email protected]>

* fix: update remaining test imports to use tests/libs directly

Co-Authored-By: [email protected] <[email protected]>

* fix: update handleRecurringEventBooking calls to match function signature (1 arg)

Co-Authored-By: [email protected] <[email protected]>

* remove

* migrate tests

* migrate tests

* refactor: update test mock imports by removing  and using async  for mock creators.

* fix type errors

* fix: add type assertion for MockUser in p2002.test-suite.ts

Co-Authored-By: [email protected] <[email protected]>

* fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path

Co-Authored-By: [email protected] <[email protected]>

* feat: create @calcom/testing package and migrate tests from /tests directory

- Created new @calcom/testing package in /packages/testing
- Moved all files from /tests to /packages/testing
- Updated all imports across the codebase to use @calcom/testing alias
- Removed /tests directory at root level

This allows other packages like @calcom/features and @calcom/web to import
testing utilities using the @calcom/testing alias instead of relative paths.

Co-Authored-By: [email protected] <[email protected]>

* fix

* fix

* fix: add missing useBookings export to @calcom/atoms package

Co-Authored-By: [email protected] <[email protected]>

* fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms

Co-Authored-By: [email protected] <[email protected]>

* chore: add @calcom/testing as explicit devDependency to packages that use it

Co-Authored-By: [email protected] <[email protected]>

* refactor: move setupVitest.ts into @calcom/testing package

Co-Authored-By: [email protected] <[email protected]>

* fix

* chore: add biome rules to restrict @calcom/testing imports

Co-Authored-By: [email protected] <[email protected]>

* fix

* rename libs to lib

* rename libs to lib

* add rule

* add rule

* refactor: remove @calcom/features imports from @calcom/testing

- Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts
- Replace ProfileRepository.generateProfileUid() with uuidv4()
- Clone Tracking type into @calcom/testing/src/lib/types.ts
- Update imports in expects.ts and getMockRequestDataForBooking.ts
- Move source files into src/ folder
- Move CalendarManager mock to @calcom/features

Co-Authored-By: [email protected] <[email protected]>

* fix: add explicit exports for nested paths in @calcom/testing

Co-Authored-By: [email protected] <[email protected]>

* improve

* improve

* fix

* fix

* fix type checks

* fix type checks

* fix type checks

* fix tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-01-08 16:59:11 +09:00

353 lines
11 KiB
TypeScript

import prismock from "@calcom/testing/lib/__mocks__/prisma";
import { describe, expect, it, beforeEach, vi } from "vitest";
import { encryptServiceAccountKey } from "@calcom/lib/server/serviceAccountKey";
import { DelegationCredentialRepository } from "./DelegationCredentialRepository";
const mockOrganizationRepository = {
findByMemberEmail: vi.fn(),
};
vi.mock("@calcom/features/ee/organizations/di/OrganizationRepository.container", () => ({
getOrganizationRepository: () => mockOrganizationRepository,
}));
vi.mock("@calcom/prisma", () => ({
prisma: {},
}));
// Mock service account key functions
vi.mock("@calcom/lib/crypto", async (importOriginal) => {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const actual = await importOriginal<typeof import("@calcom/lib/crypto")>();
return {
...actual,
symmetricEncrypt: vi.fn((serviceAccountKey) => {
console.log({ mockEncrypted: serviceAccountKey });
return `encrypted(${serviceAccountKey})`;
}),
symmetricDecrypt: vi.fn((serviceAccountKey) => {
return serviceAccountKey.replace(/^encrypted\((.*)\)$/, "$1");
}),
};
});
// Test Data Helpers
const buildMockServiceAccountKey = () => ({
client_email: "[email protected]",
private_key: "private-key",
client_id: "client-id",
additional_field: "value",
});
const buildMockEncryptedServiceAccountKey = () => ({
client_email: "[email protected]",
client_id: "client-id",
encrypted_credentials: 'encrypted({"private_key":"private-key"})',
additional_field: "value",
});
const buildMockWorkspacePlatform = () => ({
id: 1,
name: "Test Platform",
slug: "test-platform",
});
const buildMockOrganization = () => ({
id: 1,
name: "Test Organization",
isOrganization: true,
});
const buildMockDelegationCredential = (overrides = {}) => ({
id: "test-id",
enabled: true,
domain: "example.com",
organizationId: 1,
workspacePlatformId: 1,
serviceAccountKey: buildMockServiceAccountKey(),
workspacePlatform: buildMockWorkspacePlatform(),
...overrides,
});
// Test Utilities
const createTestDelegationCredential = async (overrides = {}) => {
// Create organization first (as a team with isOrganization true)
await prismock.team.create({
data: buildMockOrganization(),
});
// Create workspace platform
await prismock.workspacePlatform.create({
data: buildMockWorkspacePlatform(),
});
const data = buildMockDelegationCredential(overrides);
return await prismock.delegationCredential.create({
data: {
...data,
serviceAccountKey: encryptServiceAccountKey(data.serviceAccountKey),
},
include: {
workspacePlatform: true,
},
});
};
const setupOrganizationMock = (returnValue: { id: number } | null) => {
mockOrganizationRepository.findByMemberEmail.mockResolvedValue(returnValue);
};
describe("DelegationCredentialRepository", () => {
beforeEach(() => {
prismock.delegationCredential.deleteMany();
prismock.workspacePlatform.deleteMany();
prismock.team.deleteMany();
vi.clearAllMocks();
});
describe("Service Account Key Access Control", () => {
beforeEach(async () => {
await createTestDelegationCredential();
});
describe("Regular Find Methods (No Service Account Key)", () => {
describe("findById", () => {
it("should not expose service account key in response", async () => {
const result = await DelegationCredentialRepository.findById({ id: "test-id" });
expect(result).not.toHaveProperty("serviceAccountKey");
expect(result).toEqual(
expect.objectContaining({
id: "test-id",
enabled: true,
domain: "example.com",
})
);
});
});
describe("findAllByDomain", () => {
it("should not expose service account key in any of the results", async () => {
const results = await DelegationCredentialRepository.findAllByDomain({ domain: "example.com" });
expect(results.length).toBeGreaterThan(0);
results.forEach((result) => {
expect(result).not.toHaveProperty("serviceAccountKey");
expect(result).toEqual(
expect.objectContaining({
domain: "example.com",
})
);
});
});
});
});
describe("Sensitive Methods (With Service Account Key)", () => {
describe("findByIdIncludeSensitiveServiceAccountKey", () => {
it("should expose valid service account key", async () => {
const result = await DelegationCredentialRepository.findByIdIncludeSensitiveServiceAccountKey({
id: "test-id",
});
expect(result).toHaveProperty("serviceAccountKey");
expect(result?.serviceAccountKey).toEqual(buildMockServiceAccountKey());
});
});
describe("findByOrgIdIncludeSensitiveServiceAccountKey", () => {
it("should expose validated service account keys", async () => {
const results = await DelegationCredentialRepository.findByOrgIdIncludeSensitiveServiceAccountKey({
organizationId: 1,
});
expect(results.length).toEqual(1);
const result = results[0];
expect(result).toHaveProperty("serviceAccountKey");
expect(result.serviceAccountKey).toEqual(buildMockEncryptedServiceAccountKey());
});
});
describe("findUniqueByOrganizationIdAndDomainIncludeSensitiveServiceAccountKey", () => {
it("should expose validated service account key", async () => {
const result =
await DelegationCredentialRepository.findUniqueByOrganizationIdAndDomainIncludeSensitiveServiceAccountKey(
{
organizationId: 1,
domain: "example.com",
}
);
expect(result).toHaveProperty("serviceAccountKey");
expect(result?.serviceAccountKey).toEqual(buildMockServiceAccountKey());
});
});
describe("findUniqueByOrgMemberEmailIncludeSensitiveServiceAccountKey", () => {
it("should return valid delegation when email exists in organization", async () => {
setupOrganizationMock({ id: 1 });
const result =
await DelegationCredentialRepository.findUniqueByOrgMemberEmailIncludeSensitiveServiceAccountKey({
email: "[email protected]",
});
expect(result).toHaveProperty("serviceAccountKey");
expect(result?.serviceAccountKey).toEqual(buildMockServiceAccountKey());
expect(result?.domain).toBe("example.com");
});
it("should return null when email not found in any organization", async () => {
setupOrganizationMock(null);
const result =
await DelegationCredentialRepository.findUniqueByOrgMemberEmailIncludeSensitiveServiceAccountKey({
email: "[email protected]",
});
expect(result).toBeNull();
});
});
});
});
describe("CRUD Operations", () => {
describe("create", () => {
it("should store delegation credential with all required fields and establish connections", async () => {
// Create organization first (as a team with isOrganization true)
await prismock.team.create({
data: buildMockOrganization(),
});
// Create workspace platform
const workspacePlatform = await prismock.workspacePlatform.create({
data: buildMockWorkspacePlatform(),
});
const data = buildMockDelegationCredential();
delete data.id; // ID is auto-generated
delete data.workspacePlatform; // Don't include the relation in create
const result = await DelegationCredentialRepository.create(data);
expect(result).toEqual({
id: expect.any(String),
domain: data.domain,
enabled: data.enabled,
createdAt: expect.any(Date),
lastEnabledAt: null,
lastDisabledAt: null,
updatedAt: null,
organizationId: data.organizationId,
workspacePlatform: {
name: workspacePlatform.name,
slug: workspacePlatform.slug,
},
});
});
});
describe("update", () => {
it("should modify workspace platform connection when workspacePlatformId is provided", async () => {
const created = await createTestDelegationCredential();
// Create new workspace platform
const newWorkspacePlatform = await prismock.workspacePlatform.create({
data: {
id: 2,
name: "New Platform",
slug: "new-platform",
},
});
const result = await DelegationCredentialRepository.updateById({
id: created.id,
data: { workspacePlatformId: newWorkspacePlatform.id },
});
expect(result).toEqual({
id: created.id,
domain: created.domain,
enabled: created.enabled,
createdAt: expect.any(Date),
lastEnabledAt: created.lastEnabledAt,
lastDisabledAt: created.lastDisabledAt,
updatedAt: null,
organizationId: created.organizationId,
workspacePlatform: {
name: newWorkspacePlatform.name,
slug: newWorkspacePlatform.slug,
},
});
});
it("should modify organization connection when organizationId is provided", async () => {
const created = await createTestDelegationCredential();
// Create new organization (as a team with isOrganization true)
const newOrganization = await prismock.team.create({
data: {
id: 2,
name: "New Organization",
isOrganization: true,
},
});
const result = await DelegationCredentialRepository.updateById({
id: created.id,
data: { organizationId: newOrganization.id },
});
expect(result).toEqual({
id: created.id,
lastEnabledAt: created.lastEnabledAt,
lastDisabledAt: created.lastDisabledAt,
domain: created.domain,
enabled: created.enabled,
createdAt: expect.any(Date),
updatedAt: null,
organizationId: newOrganization.id,
workspacePlatform: {
name: expect.any(String),
slug: expect.any(String),
},
});
});
it("should modify specified fields while preserving others", async () => {
const created = await createTestDelegationCredential();
const result = await DelegationCredentialRepository.updateById({
id: created.id,
data: { enabled: false },
});
expect(result).toEqual(
expect.objectContaining({
id: created.id,
enabled: false, // Changed
domain: created.domain, // Preserved
})
);
});
});
describe("delete", () => {
it("should remove the delegation credential completely", async () => {
const created = await createTestDelegationCredential();
await DelegationCredentialRepository.deleteById({ id: created.id });
const result = await prismock.delegationCredential.findUnique({
where: { id: created.id },
});
expect(result).toBeNull();
});
});
});
});