Files
Benny JooGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
f5d345b133 refactor: remove @calcom/web imports from @calcom/features and add @calcom/testing package (#26480)
* fix: remove @calcom/web imports from packages/features to eliminate circular dependency

- Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts
- Migrate useGeo hook to packages/features/geo/GeoContext.tsx
- Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts
- Migrate Calendar component to packages/features/calendars/weeklyview/components/
- Move test utilities (bookingScenario, fixtures) to packages/features/test/
- Update all imports in packages/features to use new locations
- Add re-exports in apps/web for backward compatibility

Co-Authored-By: [email protected] <[email protected]>

* fix: delete original implementation files and fix type issues

- Delete original calendar component files in apps/web (keep only re-export stubs)
- Migrate OutOfOfficeInSlots to packages/features/bookings/components
- Convert apps/web OutOfOfficeInSlots to re-export stub
- Fix className vs class issue in Calendar.tsx
- Fix @calcom/trpc import violation in user-table.ts by using structural type

Co-Authored-By: [email protected] <[email protected]>

* fix: add missing isGroup and contains fields to UserTableUser attributes type

Co-Authored-By: [email protected] <[email protected]>

* fix: update customRole type to match actual Prisma Role model

Co-Authored-By: [email protected] <[email protected]>

* fix build

* fix

* fix

* cleanup weeklyview

* fix

* refactor to mv MemberPermissions to types package

* add types dependency to features

* fix

* fix

* fix

* fix

* fix

* fix

* rename

* rename

* migrate

* migrate

* migrate

* fix

* fix

* fix

* refactor: move test utilities from packages/features/test to tests/libs

- Move bookingScenario utilities to tests/libs/bookingScenario
- Move fixtures to tests/libs/fixtures
- Update all imports in packages/features test files to use new location
- Update all imports in apps/web test files to use new location
- Eliminates duplication of test utilities between packages/features and apps/web

Co-Authored-By: [email protected] <[email protected]>

* fix: correct relative import paths for tests/libs in test files

Co-Authored-By: [email protected] <[email protected]>

* refactor: replace test utility implementations with re-exports to tests/libs

Co-Authored-By: [email protected] <[email protected]>

* fix: fix test import paths and move signup handler tests to apps/web

Co-Authored-By: [email protected] <[email protected]>

* fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features

- Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency
- Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib
- Restore signup handlers and tests to packages/features/auth/signup/handlers
- Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx

Co-Authored-By: [email protected] <[email protected]>

* fix: update recurring-event.test.ts imports to use tests/libs path

Co-Authored-By: [email protected] <[email protected]>

* refactor: delete test re-export files and update imports to use tests/libs directly

Co-Authored-By: [email protected] <[email protected]>

* fix: update remaining test imports to use tests/libs directly

Co-Authored-By: [email protected] <[email protected]>

* fix: update handleRecurringEventBooking calls to match function signature (1 arg)

Co-Authored-By: [email protected] <[email protected]>

* remove

* migrate tests

* migrate tests

* refactor: update test mock imports by removing  and using async  for mock creators.

* fix type errors

* fix: add type assertion for MockUser in p2002.test-suite.ts

Co-Authored-By: [email protected] <[email protected]>

* fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path

Co-Authored-By: [email protected] <[email protected]>

* feat: create @calcom/testing package and migrate tests from /tests directory

- Created new @calcom/testing package in /packages/testing
- Moved all files from /tests to /packages/testing
- Updated all imports across the codebase to use @calcom/testing alias
- Removed /tests directory at root level

This allows other packages like @calcom/features and @calcom/web to import
testing utilities using the @calcom/testing alias instead of relative paths.

Co-Authored-By: [email protected] <[email protected]>

* fix

* fix

* fix: add missing useBookings export to @calcom/atoms package

Co-Authored-By: [email protected] <[email protected]>

* fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms

Co-Authored-By: [email protected] <[email protected]>

* chore: add @calcom/testing as explicit devDependency to packages that use it

Co-Authored-By: [email protected] <[email protected]>

* refactor: move setupVitest.ts into @calcom/testing package

Co-Authored-By: [email protected] <[email protected]>

* fix

* chore: add biome rules to restrict @calcom/testing imports

Co-Authored-By: [email protected] <[email protected]>

* fix

* rename libs to lib

* rename libs to lib

* add rule

* add rule

* refactor: remove @calcom/features imports from @calcom/testing

- Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts
- Replace ProfileRepository.generateProfileUid() with uuidv4()
- Clone Tracking type into @calcom/testing/src/lib/types.ts
- Update imports in expects.ts and getMockRequestDataForBooking.ts
- Move source files into src/ folder
- Move CalendarManager mock to @calcom/features

Co-Authored-By: [email protected] <[email protected]>

* fix: add explicit exports for nested paths in @calcom/testing

Co-Authored-By: [email protected] <[email protected]>

* improve

* improve

* fix

* fix

* fix type checks

* fix type checks

* fix type checks

* fix tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-01-08 16:59:11 +09:00

234 lines
7.4 KiB
TypeScript

import prismaMock from "@calcom/testing/lib/__mocks__/prismaMock";
import { describe, expect, it, vi, beforeEach } from "vitest";
import type { Schedule, User } from "@calcom/prisma/client";
import { ScheduleRepository } from "./ScheduleRepository";
vi.mock("@calcom/lib/hasEditPermissionForUser", () => ({
hasReadPermissionsForUserId: vi.fn(),
}));
import { hasReadPermissionsForUserId } from "@calcom/lib/hasEditPermissionForUser";
const mockHasReadPermissions = vi.mocked(hasReadPermissionsForUserId);
describe("ScheduleRepository", () => {
let scheduleRepository: ScheduleRepository;
beforeEach(() => {
vi.clearAllMocks();
scheduleRepository = new ScheduleRepository(prismaMock);
});
describe("constructor", () => {
it("should throw error if prismaClient is not provided", () => {
// @ts-expect-error - testing invalid input
expect(() => new ScheduleRepository(null)).toThrow("PrismaClient is required for ScheduleRepository");
// @ts-expect-error - testing invalid input
expect(() => new ScheduleRepository(undefined)).toThrow(
"PrismaClient is required for ScheduleRepository"
);
});
it("should create instance successfully with valid prismaClient", () => {
const repo = new ScheduleRepository(prismaMock);
expect(repo).toBeInstanceOf(ScheduleRepository);
});
});
describe("getDefaultScheduleId", () => {
it("should return defaultScheduleId if user has one", async () => {
const userId = 1;
const defaultScheduleId = 123;
prismaMock.user.findUnique.mockResolvedValue({ defaultScheduleId } as User);
const result = await scheduleRepository.getDefaultScheduleId(userId);
expect(prismaMock.user.findUnique).toHaveBeenCalledWith({
where: { id: userId },
select: { defaultScheduleId: true },
});
expect(result).toBe(defaultScheduleId);
});
it("should find and return first schedule if user has no defaultScheduleId", async () => {
const userId = 1;
const scheduleId = 456;
prismaMock.user.findUnique.mockResolvedValue({ defaultScheduleId: null } as User);
prismaMock.schedule.findFirst.mockResolvedValue({ id: scheduleId } as Schedule);
const result = await scheduleRepository.getDefaultScheduleId(userId);
expect(prismaMock.schedule.findFirst).toHaveBeenCalledWith({
where: { userId },
select: { id: true },
});
expect(result).toBe(scheduleId);
});
it("should throw error if no schedules found", async () => {
const userId = 1;
prismaMock.user.findUnique.mockResolvedValue({ defaultScheduleId: null } as User);
prismaMock.schedule.findFirst.mockResolvedValue(null);
await expect(scheduleRepository.getDefaultScheduleId(userId)).rejects.toThrow(
"No schedules found for user"
);
});
});
describe("hasDefaultSchedule", () => {
it("should return true if user has defaultScheduleId", async () => {
const user = { id: 1, defaultScheduleId: 123 };
const result = await scheduleRepository.hasDefaultSchedule(user);
expect(result).toBe(true);
});
it("should return true if user has a schedule", async () => {
const user = { id: 1, defaultScheduleId: null };
prismaMock.schedule.findFirst.mockResolvedValue({ id: 456 } as Schedule);
const result = await scheduleRepository.hasDefaultSchedule(user);
expect(prismaMock.schedule.findFirst).toHaveBeenCalledWith({
where: { userId: user.id },
});
expect(result).toBe(true);
});
it("should return false if user has no defaultScheduleId and no schedules", async () => {
const user = { id: 1, defaultScheduleId: null };
prismaMock.schedule.findFirst.mockResolvedValue(null);
const result = await scheduleRepository.hasDefaultSchedule(user);
expect(result).toBe(false);
});
});
describe("setupDefaultSchedule", () => {
it("should update user with new defaultScheduleId", async () => {
const userId = 1;
const scheduleId = 123;
const updatedUser = { id: userId, defaultScheduleId: scheduleId } as User;
prismaMock.user.update.mockResolvedValue(updatedUser);
const result = await scheduleRepository.setupDefaultSchedule(userId, scheduleId);
expect(prismaMock.user.update).toHaveBeenCalledWith({
where: { id: userId },
data: { defaultScheduleId: scheduleId },
});
expect(result).toEqual(updatedUser);
});
});
describe("findDetailedScheduleById", () => {
const createMockSchedule = (overrides: Partial<Schedule> = {}): Partial<Schedule> => ({
id: 100,
userId: 2,
name: "Working Hours",
availability: [],
timeZone: "America/New_York",
...overrides,
});
beforeEach(() => {
prismaMock.schedule.count.mockResolvedValue(1);
});
it("should allow access when user is the schedule owner", async () => {
const ownerId = 2;
const mockSchedule = createMockSchedule({ userId: ownerId });
prismaMock.schedule.findUnique.mockResolvedValue(mockSchedule as Schedule);
mockHasReadPermissions.mockResolvedValue(false);
const result = await scheduleRepository.findDetailedScheduleById({
scheduleId: 100,
userId: ownerId,
timeZone: "UTC",
defaultScheduleId: 100,
});
expect(result).toMatchObject({
id: 100,
name: "Working Hours",
userId: ownerId,
});
});
it("should allow access when user is part of the same team", async () => {
const scheduleOwnerId = 2;
const teamMemberId = 3;
const mockSchedule = createMockSchedule({ userId: scheduleOwnerId });
prismaMock.schedule.findUnique.mockResolvedValue(mockSchedule as Schedule);
mockHasReadPermissions.mockResolvedValue(true);
const result = await scheduleRepository.findDetailedScheduleById({
scheduleId: 100,
userId: teamMemberId,
timeZone: "UTC",
defaultScheduleId: null,
});
expect(mockHasReadPermissions).toHaveBeenCalledWith({
memberId: scheduleOwnerId,
userId: teamMemberId,
});
expect(result).toMatchObject({
id: 100,
name: "Working Hours",
userId: scheduleOwnerId,
});
});
it("should deny access when user is not owner and not part of team", async () => {
const scheduleOwnerId = 2;
const unauthorizedUserId = 999;
const mockSchedule = createMockSchedule({ userId: scheduleOwnerId });
prismaMock.schedule.findUnique.mockResolvedValue(mockSchedule as Schedule);
mockHasReadPermissions.mockResolvedValue(false);
await expect(
scheduleRepository.findDetailedScheduleById({
scheduleId: 100,
userId: unauthorizedUserId,
timeZone: "UTC",
defaultScheduleId: null,
})
).rejects.toThrow("UNAUTHORIZED");
expect(mockHasReadPermissions).toHaveBeenCalledWith({
memberId: scheduleOwnerId,
userId: unauthorizedUserId,
});
});
it("should throw error when schedule is not found", async () => {
prismaMock.schedule.findUnique.mockResolvedValue(null);
await expect(
scheduleRepository.findDetailedScheduleById({
scheduleId: 999,
userId: 1,
timeZone: "UTC",
defaultScheduleId: null,
})
).rejects.toThrow("Schedule not found");
});
});
});