Files
calendar/packages/features/insights/__tests__/routing-form-response-field.integration-test.ts
c28eb90928 chore: Upgrade prisma to 6.7.0 (#21264)
* chore: Upgrade prisma to 6.7.0

* Build fixes

* type fixes

Signed-off-by: Omar López <[email protected]>

* Update schema.prisma

* Patching

* Revert "Update schema.prisma"

This reverts commit 47d8618bf89ef4d007b30084df766f17281e21a1.

* Revert "Patching"

This reverts commit a1d2e3040e71690a44d4324db95d73b4d68c6adb.

* Revert schema changes

Signed-off-by: Omar López <[email protected]>

* WIP

Signed-off-by: Omar López <[email protected]>

* Update getPublicEvent.ts

* Update imports

Signed-off-by: Omar López <[email protected]>

* Update gitignore

Signed-off-by: Omar López <[email protected]>

* update remaining imports

Signed-off-by: Omar López <[email protected]>

* Delete .cursor/config.json

* Discard changes to packages/features/eventtypes/lib/getPublicEvent.ts

* Update _get.ts

* Update user.ts

* Update .gitignore

* update

* Update WorkflowStepContainer.tsx

* Update next-auth-custom-adapter.ts

* Update getPublicEvent.ts

* Update workflow.ts

* Update next-auth-custom-adapter.ts

* Update next-auth-options.ts

* Update bookingScenario.ts

* fix missing imports

* upgrades prismock

Signed-off-by: Omar López <[email protected]>

* patches prismock

Signed-off-by: Omar López <[email protected]>

* Update reschedule.test.ts

* Update prisma.ts

* patch prismock

Signed-off-by: Omar López <[email protected]>

* fix enums imports

Signed-off-by: Omar López <[email protected]>

* Revert "Update prisma.ts"

This reverts commit 64edcf8db54171ff4456c209d563b5d431d99619.

* Revert "patch prismock"

This reverts commit e95819113dc9d88e7130947aa120cd42710977c8.

* fix patch

* Fix test that overrun the boundary, it shouldn't test too much

* Move prisma import to changeSMSLockState

* Bring back broken test without illegal imports

* Merge with main and fix filter hosts by same round robin host

* Fixed buildDryRunBooking fn tests

* Fix and move ooo create or update handler test

* Fix packages/features/eventtypes/lib/isCurrentlyAvailable.test.ts

* Fix packages/trpc/server/routers/viewer/organizations/listMembers.handler.test.ts

* Mock @calcom/prisma

* Fix: verify-email.test.ts

* fix: Moved WebhookService test and fixed default import mock

* Fix: Added missing prisma mock, handleNewBooking uses that of course

* We're not testing createContext here

* fix: Prisma mock fix for listMembers.test.ts

* More fixes to broken testcases

* Forgot to remove borked test

* Prevent the need to mock a lot of dependencies by moving out buildBaseWhereCondition to its own file

* Temporarily skip getCalendarEvents, needs a rewrite

* Fix: turns out you can access protected in testcases

* fix further mocks

* Added packages/features/insights/server/buildBaseWhereCondition.ts, types

* Always great to have a mock and then not use it

* And one less again.

* fix: confirm.handler.test, didn't mock prisma

* fix: Address minor nit by @eunjae & fix ImpersonationProvider test

* Updated isPrismaAvailableCheck that doesn't crash on import

* fix: Get Prisma directly from the client, it usually involves the Validator and does not need 'local' inclusion

* Add zod-prisma-types without the generator enabled (commented out)

* Uncomment and see what happens

* Change method of import as imports did not work in Input Schemas

* Remove custom 'zod' booking model, it does not belong with Prisma

* Fix all other global Model imports

* Rewrite most schema includes AND remove barrel file

* Add bookingCreateBodySchema to features/bookings

* Flurry of type fixes for compatibility with new zod gen

* Refactor out the custom prisma type createEventTypeInput

* Work around nullable eventTypeLocations

* HandlePayment type fix

* More fixes, final fix remaining is CompleteEventType

* Should fix a bunch more booking related type errors

* Missed one

* Some props missing from BookingCreateBodySchema

* Fix location type in handleChildrenEventTypes

* Little bit hacky imo but it works

* Final type error \o/

* Forgot to include Prisma

* Do not include zod-utils in booker/types

* Oops, was already including Booker/types

* Fix membership type, also disallow updating createdAt/updatedAt, make part of patch/post

* Fix api v1 type errors

* Fix EventTypeDescription typings

* Remove getParserWithGeneric, use userBodySchema with UserSchema

* use centralized timeZoneSchema

* Implement feedback by @zomars

* Couple of WIP pushes

* Fix tests

* Type fixes in `handleChildrenEventTypes` test

* Try and parse metadata before use

* Change zod-prisma-types configuration for optimal performance

* Fix prisma validator error in `prisma/selects/credential`

* Disable seperate relations model, hits a bug

* Import absolute - this makes rollup work in @platform/libraries

* Attempt at removing resolutions override

* Refactor using `Prisma.validator` to `satisfies`

* Build atoms using @calcom/prisma/client

* Build atoms using @calcom/prisma/client

* fixes

* Update eventTypeSelect.ts

* Adjust `eventTypeMetaDataSchemaWithUntypedApps` from `unknown` to `record(any)`

* `EventTypeDescription` rely on `descriptionAsSafeHTML` instead of `description`

* Add `seatsPerTimeSlot` to event type public select

* Fix typing in `users-public-view` getServerSide props

* Add missing `schedulingType` to prop

* chore: bump platform libraries

* Function return type is illegal, not sure how this passed eslint (#21567)

* Merged with main

* Update updateTokenObject.ts

* Update handleResponse.ts

* Update index.ts

* Update handleChildrenEventTypes.ts

* Update booking-idempotency-key.ts

* Update WebhookService.test.ts

* Update events.test.ts

* Update queued-response.test.ts

* Update events.test.ts

* Update getRoutedUrl.test.ts

* fix: type checks

Signed-off-by: Omar López <[email protected]>

* fixes

Signed-off-by: Omar López <[email protected]>

* chore: bump platform libraries

* Update yarn.lock

* more fixes

Signed-off-by: Omar López <[email protected]>

* fixes

Signed-off-by: Omar López <[email protected]>

* biuld fixes

* chore: bump platform libraries

* Update conferencing.repository.ts

* Update conferencing.repository.ts

* Update getCalendarsEvents.test.ts

* Update vite.config.js

* chore: bump platform libraries

* Update users.ts

* Discard changes to docs/api-reference/v2/openapi.json

* Update vite.config.ts

* updated platform libraries

* Update get.handler.test.ts

* Update get.handler.test.ts

* Update schema.prisma

* Discard changes to docs/api-reference/v2/openapi.json

* Update next-auth-custom-adapter.ts

* Update team.ts

* Flurry of type fixes

* Fix majority of insight related type errors

* Type fixes for unlink of account

* Make user nullable again

* Fixed a bunch of unit tests and one type error

* Attempted mock fix

* Attempted fix for Attribute type

* Ensure default import becomes prisma, but not direct usage

* Import default as prisma in prisma.module

* Add attributeOption to attribute type

* Fix calcom/prisma mock

* Refactor Prisma client imports to @calcom/prisma/client

Updated all imports from '@prisma/client' to '@calcom/prisma/client' across tests and repository files for consistency and to use the correct Prisma client package. This change improves maintainability and ensures the correct client is referenced throughout the codebase.

* Undo removal of max-warnings=0 to get main to merge

* Remove unit tests for e2e fixtures, provide new prisma mock

* Mock @calcom/prisma in event manager

* Mock @calcom/prisma in event manager

* Add correct format even with --no-verify

* Mock prisma in CalendarManager

* Add mock for permission-check.service

* Better injection in PrismaApiKeyRepository imports

* More mock fixes :)

* Fix listMembers.handler.test

* Fix User import

* Appropriately adjust all types to be imported as types, there were a lot of types imported as normal deps

* Why was this a thing?

* Strictly speaking; Not using prismock anymore

* Ditched patch file for prismock

* Fix output.service.ts platform type imports, need concrete for plainToClass

* Better typing and tests for unlinkConnectedAccount.handler

* Small type fix

* Disable calendar cache tests as they are dependent on prismock

* chore: bump platform lib

* getRoutedUrl test remove of unused import

* Extract select to external const on getEventTypesFromDB

* Direct select of userSelect from selects/user

* fix type error from merging 23653

* Fixed integration tests by removing hardcoded values that were possible due to mocking, but as its now directly hitting the db no longer

* fix: vite config atoms prisma client type location

* revert: example app prisma client

* revert: example app prisma client

* bump platform libs

* fix: use class instead of type for DI of PlatformBookingsService

* update platform libs

* remove unused variable

* chore: generate prisma client for api v2

* fix: api v2 e2e

* fix: atoms e2e

* fix: atoms e2e

* fix: atoms e2e

* fix: api v2 e2e

* fix: tsconfig apiv2 enums

* publish libraries

* Simplify check for existence teamId

---------

Signed-off-by: Omar López <[email protected]>
Co-authored-by: Alex van Andel <[email protected]>
Co-authored-by: Joe Au-Yeung <[email protected]>
Co-authored-by: supalarry <[email protected]>
Co-authored-by: cal.com <[email protected]>
Co-authored-by: Morgan <[email protected]>
Co-authored-by: Benny Joo <[email protected]>
2025-09-11 15:27:50 +01:00

452 lines
14 KiB
TypeScript

import { describe, expect, beforeEach, afterEach, it } from "vitest";
import prisma from "@calcom/prisma";
import { Prisma } from "@calcom/prisma/client";
import { BookingStatus } from "@calcom/prisma/enums";
describe("RoutingFormResponseField", () => {
let userId: number;
let formId: string;
let eventTypeId: number;
let bookingId: number;
let responseId: number;
const randomId = Math.floor(Math.random() * 1000000);
const email = `routing-form-response-field-${randomId}@example.com`;
beforeEach(async () => {
const user = await prisma.user.create({
data: {
email,
username: `routing-form-response-field-testuser-${randomId}`,
name: "Test User",
},
});
userId = user.id;
const eventType = await prisma.eventType.create({
data: {
title: "Test Event",
slug: "test-event",
length: 60,
userId: user.id,
},
});
eventTypeId = eventType.id;
const form = await prisma.app_RoutingForms_Form.create({
data: {
name: "Test Form",
userId: user.id,
fields: [
{
id: "text-field-id",
type: "text",
label: "Name",
required: true,
},
{
id: "number-field-id",
type: "number",
label: "Rating",
required: false,
},
{
id: "multiselect-field-id",
type: "multiselect",
label: "Skills",
required: false,
options: [
{
id: "skill-1",
label: "JavaScript",
},
{
id: "skill-2",
label: "TypeScript",
},
{
id: "skill-3",
label: "React",
},
],
},
{
id: "email-field-id",
type: "email",
label: "Email",
required: true,
},
],
},
});
formId = form.id;
const booking = await prisma.booking.create({
data: {
uid: `routing-form-response-field-${randomId}`,
title: "Test Booking",
startTime: new Date(),
endTime: new Date(Date.now() + 60 * 60 * 1000),
userId: user.id,
eventTypeId: eventType.id,
status: BookingStatus.PENDING,
},
});
bookingId = booking.id;
});
afterEach(async () => {
if (responseId) {
await prisma.routingFormResponseField.deleteMany({
where: { responseId },
});
await prisma.routingFormResponseDenormalized.deleteMany({
where: { id: responseId },
});
await prisma.app_RoutingForms_FormResponse.deleteMany({
where: { id: responseId },
});
}
if (bookingId) {
await prisma.booking.deleteMany({
where: { id: bookingId },
});
}
if (formId) {
await prisma.app_RoutingForms_Form.deleteMany({
where: { id: formId },
});
}
if (eventTypeId) {
await prisma.eventType.deleteMany({
where: { id: eventTypeId },
});
}
if (userId) {
await prisma.user.deleteMany({
where: { id: userId },
});
}
});
describe("INSERT Trigger Tests", () => {
it("should create field entries when form response is created", async () => {
const formResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: "test-filler-all-fields",
formId: formId,
response: {
"text-field-id": {
label: "Name",
value: "John Doe",
},
"number-field-id": {
label: "Rating",
value: 5,
},
"multiselect-field-id": {
label: "Skills",
value: ["skill-1", "skill-3"],
},
"email-field-id": {
label: "Email",
value: "[email protected]",
},
},
routedToBookingUid: null,
},
});
responseId = formResponse.id;
const denormalizedResponse = await prisma.routingFormResponseDenormalized.findUnique({
where: { id: responseId },
include: { fields: true },
});
expect(denormalizedResponse).not.toBeNull();
expect(denormalizedResponse?.fields).toBeDefined();
expect(denormalizedResponse?.fields).toHaveLength(4);
const textField = denormalizedResponse?.fields.find((field) => field.fieldId === "text-field-id");
expect(textField).toBeDefined();
expect(textField?.valueString).toBe("John Doe");
expect(textField?.valueNumber).toBeNull();
expect(textField?.valueStringArray).toEqual([]);
const numberField = denormalizedResponse?.fields.find((field) => field.fieldId === "number-field-id");
expect(numberField).toBeDefined();
expect(numberField?.valueString).toBeNull();
expect(numberField?.valueNumber?.equals(new Prisma.Decimal(5))).toBe(true);
expect(numberField?.valueStringArray).toEqual([]);
const multiselectField = denormalizedResponse?.fields.find(
(field) => field.fieldId === "multiselect-field-id"
);
expect(multiselectField).toBeDefined();
expect(multiselectField?.valueString).toBeNull();
expect(multiselectField?.valueNumber).toBeNull();
expect(multiselectField?.valueStringArray).toContain("skill-1");
expect(multiselectField?.valueStringArray).toContain("skill-3");
expect(multiselectField?.valueStringArray).toHaveLength(2);
const emailField = denormalizedResponse?.fields.find((field) => field.fieldId === "email-field-id");
expect(emailField).toBeDefined();
expect(emailField?.valueString).toBe("[email protected]");
expect(emailField?.valueNumber).toBeNull();
expect(emailField?.valueStringArray).toEqual([]);
});
it("should handle null and undefined field values", async () => {
const formResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: "test-filler-null-values",
formId: formId,
response: {
"text-field-id": {
label: "Name",
value: null,
},
"number-field-id": {
label: "Rating",
value: undefined,
},
"multiselect-field-id": {
label: "Skills",
value: [],
},
"email-field-id": {
label: "Email",
value: "",
},
},
routedToBookingUid: null,
},
});
responseId = formResponse.id;
const denormalizedResponse = await prisma.routingFormResponseDenormalized.findUnique({
where: { id: responseId },
include: { fields: true },
});
expect(denormalizedResponse).not.toBeNull();
expect(denormalizedResponse?.fields).toBeDefined();
expect(denormalizedResponse?.fields.length).toBeLessThanOrEqual(2);
const emailField = denormalizedResponse?.fields.find((field) => field.fieldId === "email-field-id");
if (emailField) {
expect(emailField.valueString).toBe("");
}
const multiselectField = denormalizedResponse?.fields.find(
(field) => field.fieldId === "multiselect-field-id"
);
if (multiselectField) {
expect(multiselectField.valueStringArray).toEqual([]);
}
});
it("should handle invalid data types", async () => {
const formResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: "test-filler-invalid-types",
formId: formId,
response: {
"text-field-id": {
label: "Name",
value: 123, // Number instead of string
},
"number-field-id": {
label: "Rating",
value: "five", // String instead of number
},
"multiselect-field-id": {
label: "Skills",
value: "skill-1", // String instead of array
},
},
routedToBookingUid: null,
},
});
responseId = formResponse.id;
const denormalizedResponse = await prisma.routingFormResponseDenormalized.findUnique({
where: { id: responseId },
include: { fields: true },
});
expect(denormalizedResponse).not.toBeNull();
expect(denormalizedResponse?.fields).toBeDefined();
});
});
describe("UPDATE Trigger Tests", () => {
it("should update field entries when form response is updated", async () => {
const formResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: "test-filler-update",
formId: formId,
response: {
"text-field-id": {
label: "Name",
value: "Original Name",
},
"number-field-id": {
label: "Rating",
value: 3,
},
"multiselect-field-id": {
label: "Skills",
value: ["skill-1"],
},
},
routedToBookingUid: null,
},
});
responseId = formResponse.id;
const initialDenormalizedResponse = await prisma.routingFormResponseDenormalized.findUnique({
where: { id: responseId },
include: { fields: true },
});
expect(initialDenormalizedResponse).not.toBeNull();
expect(initialDenormalizedResponse?.fields).toBeDefined();
expect(initialDenormalizedResponse?.fields).toHaveLength(3);
const initialTextField = initialDenormalizedResponse?.fields.find(
(field) => field.fieldId === "text-field-id"
);
expect(initialTextField?.valueString).toBe("Original Name");
await prisma.app_RoutingForms_FormResponse.update({
where: { id: responseId },
data: {
response: {
"text-field-id": {
label: "Name",
value: "Updated Name",
},
"number-field-id": {
label: "Rating",
value: 5,
},
"multiselect-field-id": {
label: "Skills",
value: ["skill-1", "skill-2"],
},
"email-field-id": {
label: "Email",
value: "[email protected]",
},
},
},
});
const updatedDenormalizedResponse = await prisma.routingFormResponseDenormalized.findUnique({
where: { id: responseId },
include: { fields: true },
});
expect(updatedDenormalizedResponse).not.toBeNull();
expect(updatedDenormalizedResponse?.fields).toBeDefined();
expect(updatedDenormalizedResponse?.fields).toHaveLength(4); // Now we have 4 fields
const updatedTextField = updatedDenormalizedResponse?.fields.find(
(field) => field.fieldId === "text-field-id"
);
expect(updatedTextField).toBeDefined();
expect(updatedTextField?.valueString).toBe("Updated Name");
const updatedNumberField = updatedDenormalizedResponse?.fields.find(
(field) => field.fieldId === "number-field-id"
);
expect(updatedNumberField).toBeDefined();
expect(updatedNumberField?.valueNumber?.equals(new Prisma.Decimal(5))).toBe(true);
const updatedMultiselectField = updatedDenormalizedResponse?.fields.find(
(field) => field.fieldId === "multiselect-field-id"
);
expect(updatedMultiselectField).toBeDefined();
expect(updatedMultiselectField?.valueStringArray).toContain("skill-1");
expect(updatedMultiselectField?.valueStringArray).toContain("skill-2");
expect(updatedMultiselectField?.valueStringArray).toHaveLength(2);
const newEmailField = updatedDenormalizedResponse?.fields.find(
(field) => field.fieldId === "email-field-id"
);
expect(newEmailField).toBeDefined();
expect(newEmailField?.valueString).toBe("[email protected]");
});
it("should remove field entries when fields are removed from response", async () => {
const formResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: "test-filler-remove-fields",
formId: formId,
response: {
"text-field-id": {
label: "Name",
value: "Test Name",
},
"number-field-id": {
label: "Rating",
value: 4,
},
"multiselect-field-id": {
label: "Skills",
value: ["skill-1", "skill-2"],
},
"email-field-id": {
label: "Email",
value: "[email protected]",
},
},
routedToBookingUid: null,
},
});
responseId = formResponse.id;
const initialDenormalizedResponse = await prisma.routingFormResponseDenormalized.findUnique({
where: { id: responseId },
include: { fields: true },
});
expect(initialDenormalizedResponse).not.toBeNull();
expect(initialDenormalizedResponse?.fields).toBeDefined();
expect(initialDenormalizedResponse?.fields).toHaveLength(4);
await prisma.app_RoutingForms_FormResponse.update({
where: { id: responseId },
data: {
response: {
"text-field-id": {
label: "Name",
value: "Test Name",
},
"email-field-id": {
label: "Email",
value: "[email protected]",
},
},
},
});
const updatedDenormalizedResponse = await prisma.routingFormResponseDenormalized.findUnique({
where: { id: responseId },
include: { fields: true },
});
expect(updatedDenormalizedResponse).not.toBeNull();
expect(updatedDenormalizedResponse?.fields).toBeDefined();
expect(updatedDenormalizedResponse?.fields).toHaveLength(2); // Now we have only 2 fields
const fieldIds = updatedDenormalizedResponse?.fields.map((field) => field.fieldId);
expect(fieldIds).toContain("text-field-id");
expect(fieldIds).toContain("email-field-id");
expect(fieldIds).not.toContain("number-field-id");
expect(fieldIds).not.toContain("multiselect-field-id");
});
});
});