Files
jwinters01andGitHub ad616de862 chore: fix Rules-of-React violations for React Compiler readiness (#624)
* chore: fix Rules-of-React violations for React Compiler readiness

Add eslint-plugin-react-hooks v7 (recommended-latest) and fix all
error-level Rules-of-React findings so the React Compiler can optimize
the component library.

The healthcheck reports 100% of components compilable; these fixes
clear the 34 ESLint errors across the src and v2 component trees:

- refs: stop accessing ref.current during render (incl. the react-form
  compat shim, whose public ref-forwarding API is preserved)
- set-state-in-effect: convert to derived state or restructure effects
- immutability: clone-before-mutate; stop mutating props/state
- rules-of-hooks: hoist conditional hook calls to top level

All 47 unit tests pass; behavior is preserved.

Signed-off-by: Jonathan Winters <[email protected]>

* chore: resolve react-hooks deps from public npm registry

The eslint-plugin-react-hooks@7 dependency subtree was locked to an
internal mirror, which the public CI runner can't reach (ETIMEDOUT).
Rewrite the 21 affected resolved URLs to registry.yarnpkg.com.

Signed-off-by: Jonathan Winters <[email protected]>

* useKeybinding -> registerKeybinding

Signed-off-by: Jonathan Winters <[email protected]>

* chore: fix Rules-of-React refs violations from registerKeybinding rename

The useKeybinding->registerKeybinding rename turned hook calls into plain
function calls in the render body; since registerKeybinding takes ref
targets, the new react-hooks/refs lint flagged them. Move the calls into
useEffect (registration is a side effect) in sliding-panel and the v2
autocomplete. In the v1 autocomplete, the flagged value is a forwarded
callback ref, not a render-time read, so suppress that one with a comment.

Also dedupe pnpm-lock.yaml.

Signed-off-by: Jonathan Winters <[email protected]>

---------

Signed-off-by: Jonathan Winters <[email protected]>
2026-06-30 11:51:17 +02:00

36 lines
1010 B
TypeScript

import * as React from 'react';
import Text from '../text/text';
import {Input, useInput} from './input';
export default {
title: 'Components/Input',
component: Input,
argTypes: {
style: {control: {disable: true}},
innerref: {control: {disable: true}},
placeholder: {control: {type: 'text'}},
onChange: {action: 'inputChanged'},
},
};
export const Primary = (args: any) => {
const [field, , fieldProps] = useInput('');
const origOnChange = fieldProps.onChange;
const onChange = (val: React.ChangeEvent<HTMLInputElement>) => {
origOnChange(val);
args.onChange(val);
};
return (
<React.Fragment>
<div style={{width: '50%', marginBottom: '1em'}}>
<Input {...args} {...fieldProps} onChange={onChange} />
</div>
{field && field !== '' && <Text>Your input: {field}</Text>}
</React.Fragment>
);
};
Primary.args = {
placeholder: 'Type something here',
};