mirror of
https://github.com/hanzoai/cd-ui.git
synced 2026-10-30 20:42:45 +00:00
jwinters01andGitHub
ad616de862
* chore: fix Rules-of-React violations for React Compiler readiness Add eslint-plugin-react-hooks v7 (recommended-latest) and fix all error-level Rules-of-React findings so the React Compiler can optimize the component library. The healthcheck reports 100% of components compilable; these fixes clear the 34 ESLint errors across the src and v2 component trees: - refs: stop accessing ref.current during render (incl. the react-form compat shim, whose public ref-forwarding API is preserved) - set-state-in-effect: convert to derived state or restructure effects - immutability: clone-before-mutate; stop mutating props/state - rules-of-hooks: hoist conditional hook calls to top level All 47 unit tests pass; behavior is preserved. Signed-off-by: Jonathan Winters <[email protected]> * chore: resolve react-hooks deps from public npm registry The eslint-plugin-react-hooks@7 dependency subtree was locked to an internal mirror, which the public CI runner can't reach (ETIMEDOUT). Rewrite the 21 affected resolved URLs to registry.yarnpkg.com. Signed-off-by: Jonathan Winters <[email protected]> * useKeybinding -> registerKeybinding Signed-off-by: Jonathan Winters <[email protected]> * chore: fix Rules-of-React refs violations from registerKeybinding rename The useKeybinding->registerKeybinding rename turned hook calls into plain function calls in the render body; since registerKeybinding takes ref targets, the new react-hooks/refs lint flagged them. Move the calls into useEffect (registration is a side effect) in sliding-panel and the v2 autocomplete. In the v1 autocomplete, the flagged value is a forwarded callback ref, not a render-time read, so suppress that one with a comment. Also dedupe pnpm-lock.yaml. Signed-off-by: Jonathan Winters <[email protected]> --------- Signed-off-by: Jonathan Winters <[email protected]>
35 lines
1.3 KiB
TypeScript
35 lines
1.3 KiB
TypeScript
import * as React from 'react';
|
|
import ActionButton from '../action-button/action-button';
|
|
import {Flexy} from '../flexy/flexy';
|
|
import Text from '../text/text';
|
|
import {Theme, ThemeDiv} from './theme-div';
|
|
|
|
export default {
|
|
component: ThemeDiv,
|
|
title: 'Components/ThemeDiv',
|
|
argTypes: {
|
|
innerref: {control: {disable: true}},
|
|
},
|
|
};
|
|
|
|
export const Primary = (args: any) => {
|
|
const [theme, setTheme] = React.useState(args.theme as Theme);
|
|
const [prevArgsTheme, setPrevArgsTheme] = React.useState(args.theme as Theme);
|
|
if (args.theme !== prevArgsTheme) {
|
|
setPrevArgsTheme(args.theme as Theme);
|
|
setTheme(args.theme as Theme);
|
|
}
|
|
const toggleTheme = () => setTheme(theme === Theme.Dark ? Theme.Light : Theme.Dark);
|
|
const style = {background: theme === Theme.Dark ? 'black' : 'white', padding: '1em'};
|
|
return (
|
|
<ThemeDiv theme={theme} {...args} className='test' style={style}>
|
|
<Flexy>
|
|
<ActionButton action={toggleTheme} theme={theme} icon={theme === Theme.Dark ? 'fa-sun' : 'fa-moon'} />
|
|
<Text theme={theme}>
|
|
Classes: <code>{theme === Theme.Dark ? 'test test--dark' : 'test'}</code>
|
|
</Text>
|
|
</Flexy>
|
|
</ThemeDiv>
|
|
);
|
|
};
|