mirror of
https://github.com/hanzoai/cd.git
synced 2026-10-30 14:56:45 +00:00
zeekayandHanzo Dev
cbf668a980
go fix applied the modernizers: promoted-field keys in struct literals,
strings.Cut, SplitSeq, new(expr), slices and maps helpers, wg.Go, reflect.TypeFor
and errors.AsType. omitzero is left out, since omitting a zero struct such as
time.Time{} is a per-field wire decision and not a mechanical one.
Two changes the modernizers could not make for themselves. AsType needs its type
argument to be an error, so the git exit-status reader embeds error in the
interface it asks for. And an error built by concatenating a tag list into its
own format string now says so with a verb, which is what vet was pointing at.
Co-authored-by: Hanzo Dev <[email protected]>
635 lines
15 KiB
Go
635 lines
15 KiB
Go
package controllers
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/hanzoai/cd/common"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
corev1 "k8s.io/api/core/v1"
|
|
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
ctrl "sigs.k8s.io/controller-runtime"
|
|
"sigs.k8s.io/controller-runtime/pkg/client/fake"
|
|
"sigs.k8s.io/controller-runtime/pkg/reconcile"
|
|
|
|
"github.com/hanzoai/cd/pkg/apis/application/v1alpha1"
|
|
)
|
|
|
|
type mockAddRateLimitingInterface struct {
|
|
addedItems []reconcile.Request
|
|
}
|
|
|
|
// Add checks the type, and adds it to the internal list of received additions
|
|
func (obj *mockAddRateLimitingInterface) Add(item reconcile.Request) {
|
|
obj.addedItems = append(obj.addedItems, item)
|
|
}
|
|
|
|
func TestClusterEventHandler(t *testing.T) {
|
|
t.Parallel()
|
|
scheme := runtime.NewScheme()
|
|
err := v1alpha1.AddToScheme(scheme)
|
|
require.NoError(t, err)
|
|
|
|
err = v1alpha1.AddToScheme(scheme)
|
|
require.NoError(t, err)
|
|
|
|
tests := []struct {
|
|
name string
|
|
items []v1alpha1.ApplicationSet
|
|
secret corev1.Secret
|
|
expectedRequests []ctrl.Request
|
|
}{
|
|
{
|
|
name: "no application sets should mean no requests",
|
|
items: []v1alpha1.ApplicationSet{},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a cluster generator should produce a request",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
Namespace: "cd", Name: "my-app-set",
|
|
}},
|
|
},
|
|
{
|
|
name: "multiple cluster generators should produce multiple requests",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "my-app-set2",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{
|
|
{Namespace: "cd", Name: "my-app-set"},
|
|
{Namespace: "cd", Name: "my-app-set2"},
|
|
},
|
|
},
|
|
{
|
|
name: "non-cluster generator should not match",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "app-set-non-cluster",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
List: &v1alpha1.ListGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{
|
|
{Namespace: "cd", Name: "my-app-set"},
|
|
},
|
|
},
|
|
{
|
|
name: "cluster generators in other namespaces should not match",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "my-namespace-not-allowed",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "non-cd secret should not match",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "another-namespace",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-non-cd-secret",
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a matrix generator with a cluster generator should produce a request",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &v1alpha1.MatrixGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
Namespace: "cd", Name: "my-app-set",
|
|
}},
|
|
},
|
|
{
|
|
name: "a matrix generator with non cluster generator should not match",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &v1alpha1.MatrixGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
List: &v1alpha1.ListGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a matrix generator with a nested matrix generator containing a cluster generator should produce a request",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &v1alpha1.MatrixGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Matrix: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
Namespace: "cd", Name: "my-app-set",
|
|
}},
|
|
},
|
|
{
|
|
name: "a matrix generator with a nested matrix generator containing non cluster generator should not match",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &v1alpha1.MatrixGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Matrix: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"list": {
|
|
"elements": [
|
|
"a",
|
|
"b"
|
|
]
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a merge generator with a cluster generator should produce a request",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &v1alpha1.MergeGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
Namespace: "cd", Name: "my-app-set",
|
|
}},
|
|
},
|
|
{
|
|
name: "a matrix generator with non cluster generator should not match",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &v1alpha1.MergeGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
List: &v1alpha1.ListGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a merge generator with a nested merge generator containing a cluster generator should produce a request",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &v1alpha1.MergeGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
Namespace: "cd", Name: "my-app-set",
|
|
}},
|
|
},
|
|
{
|
|
name: "a merge generator with a nested merge generator containing non cluster generator should not match",
|
|
items: []v1alpha1.ApplicationSet{
|
|
{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
Spec: v1alpha1.ApplicationSetSpec{
|
|
Generators: []v1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &v1alpha1.MergeGenerator{
|
|
Generators: []v1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"list": {
|
|
"elements": [
|
|
"a",
|
|
"b"
|
|
]
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
common.LabelKeySecretType: common.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
appSetList := v1alpha1.ApplicationSetList{
|
|
Items: test.items,
|
|
}
|
|
|
|
fakeClient := fake.NewClientBuilder().WithScheme(scheme).WithLists(&appSetList).Build()
|
|
|
|
handler := &clusterSecretEventHandler{
|
|
Client: fakeClient,
|
|
Log: log.WithField("type", "createSecretEventHandler"),
|
|
ApplicationSetNamespaces: []string{"cd"},
|
|
}
|
|
|
|
mockAddRateLimitingInterface := mockAddRateLimitingInterface{}
|
|
|
|
handler.queueRelatedAppGenerators(t.Context(), &mockAddRateLimitingInterface, &test.secret)
|
|
|
|
assert.ElementsMatch(t, mockAddRateLimitingInterface.addedItems, test.expectedRequests)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNestedGeneratorHasClusterGenerator_NestedClusterGenerator(t *testing.T) {
|
|
t.Parallel()
|
|
nested := v1alpha1.ApplicationSetNestedGenerator{
|
|
Clusters: &v1alpha1.ClusterGenerator{},
|
|
}
|
|
|
|
hasClusterGenerator, err := nestedGeneratorHasClusterGenerator(nested)
|
|
|
|
require.NoError(t, err)
|
|
assert.True(t, hasClusterGenerator)
|
|
}
|
|
|
|
func TestNestedGeneratorHasClusterGenerator_NestedMergeGenerator(t *testing.T) {
|
|
t.Parallel()
|
|
nested := v1alpha1.ApplicationSetNestedGenerator{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
}
|
|
|
|
hasClusterGenerator, err := nestedGeneratorHasClusterGenerator(nested)
|
|
|
|
require.NoError(t, err)
|
|
assert.True(t, hasClusterGenerator)
|
|
}
|
|
|
|
func TestNestedGeneratorHasClusterGenerator_NestedMergeGeneratorWithInvalidJSON(t *testing.T) {
|
|
t.Parallel()
|
|
nested := v1alpha1.ApplicationSetNestedGenerator{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
`,
|
|
),
|
|
},
|
|
}
|
|
|
|
hasClusterGenerator, err := nestedGeneratorHasClusterGenerator(nested)
|
|
|
|
require.Error(t, err)
|
|
assert.False(t, hasClusterGenerator)
|
|
}
|