mirror of
https://github.com/hanzoai/cd.git
synced 2026-10-30 14:56:45 +00:00
zeekay
31c64ef661
Rename test names, comments, fixture data, and mock GitHub/webhook responses that still said Argo/ArgoCD/argocd/argoproj in our own voice, matching the hanzocd-* binary/configmap names and the apps.hanzo.ai CRD/annotation domain already established elsewhere in the fork. Also drop the dated argov1alpha1/argoprojiov1alpha1 import aliases for our own v1alpha1 API package. Restore the CRD groups a prior blind rename had mangled on a vendored third-party Argo Workflows example manifest back to the real argoproj.io, and fix several places where an earlier half-finished rename had gone silently wrong instead of just being cosmetic: stale CD_BINARY_NAME values and a stale --argocd-repo-server flag no longer recognized by the binary, cert filenames and an ssh_known_hosts alias that didn't match what's actually on disk, a namespace and a kustomize image substitution that were silent no-ops, and a test assertion regex that could never match its own fixture. External lookup keys we don't control are left byte-exact: quay.io/argoprojlabs images, the docker.io/argoproj CI builder image, live argoproj/argo-workflows release URLs, the generated ArgoprojV1alpha1() clientset method, and the Makefile-coupled /tmp/argo-e2e and GOPATH mount conventions.
234 lines
5.4 KiB
Go
234 lines
5.4 KiB
Go
package utils
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.yaml.in/yaml/v3"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
"github.com/hanzoai/cd/pkg/apis/application/v1alpha1"
|
|
"github.com/hanzoai/cd/util/cd/normalizers"
|
|
)
|
|
|
|
func Test_applyIgnoreDifferences(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
appMeta := metav1.TypeMeta{
|
|
APIVersion: v1alpha1.ApplicationSchemaGroupVersionKind.GroupVersion().String(),
|
|
Kind: v1alpha1.ApplicationSchemaGroupVersionKind.Kind,
|
|
}
|
|
testCases := []struct {
|
|
name string
|
|
ignoreDifferences v1alpha1.ApplicationSetIgnoreDifferences
|
|
foundApp string
|
|
generatedApp string
|
|
expectedApp string
|
|
}{
|
|
{
|
|
name: "empty ignoreDifferences",
|
|
foundApp: `
|
|
spec: {}`,
|
|
generatedApp: `
|
|
spec: {}`,
|
|
expectedApp: `
|
|
spec: {}`,
|
|
},
|
|
{
|
|
name: "ignore target revision with jq",
|
|
ignoreDifferences: v1alpha1.ApplicationSetIgnoreDifferences{
|
|
{JQPathExpressions: []string{".spec.source.targetRevision"}},
|
|
},
|
|
foundApp: `
|
|
spec:
|
|
source:
|
|
targetRevision: foo`,
|
|
generatedApp: `
|
|
spec:
|
|
source:
|
|
targetRevision: bar`,
|
|
expectedApp: `
|
|
spec:
|
|
source:
|
|
targetRevision: foo`,
|
|
},
|
|
{
|
|
name: "ignore helm parameter with jq",
|
|
ignoreDifferences: v1alpha1.ApplicationSetIgnoreDifferences{
|
|
{JQPathExpressions: []string{`.spec.source.helm.parameters | select(.name == "image.tag")`}},
|
|
},
|
|
foundApp: `
|
|
spec:
|
|
source:
|
|
helm:
|
|
parameters:
|
|
- name: image.tag
|
|
value: test
|
|
- name: another
|
|
value: value`,
|
|
generatedApp: `
|
|
spec:
|
|
source:
|
|
helm:
|
|
parameters:
|
|
- name: image.tag
|
|
value: v1.0.0
|
|
- name: another
|
|
value: value`,
|
|
expectedApp: `
|
|
spec:
|
|
source:
|
|
helm:
|
|
parameters:
|
|
- name: image.tag
|
|
value: test
|
|
- name: another
|
|
value: value`,
|
|
},
|
|
{
|
|
name: "ignore auto-sync in appset when it's not in the cluster with jq",
|
|
ignoreDifferences: v1alpha1.ApplicationSetIgnoreDifferences{
|
|
{JQPathExpressions: []string{".spec.syncPolicy.automated"}},
|
|
},
|
|
foundApp: `
|
|
spec:
|
|
syncPolicy:
|
|
retry:
|
|
limit: 5`,
|
|
generatedApp: `
|
|
spec:
|
|
syncPolicy:
|
|
automated:
|
|
selfHeal: true
|
|
retry:
|
|
limit: 5`,
|
|
expectedApp: `
|
|
spec:
|
|
syncPolicy:
|
|
retry:
|
|
limit: 5`,
|
|
},
|
|
{
|
|
name: "ignore auto-sync in the cluster when it's not in the appset with jq",
|
|
ignoreDifferences: v1alpha1.ApplicationSetIgnoreDifferences{
|
|
{JQPathExpressions: []string{".spec.syncPolicy.automated"}},
|
|
},
|
|
foundApp: `
|
|
spec:
|
|
syncPolicy:
|
|
automated:
|
|
selfHeal: true
|
|
retry:
|
|
limit: 5`,
|
|
generatedApp: `
|
|
spec:
|
|
syncPolicy:
|
|
retry:
|
|
limit: 5`,
|
|
expectedApp: `
|
|
spec:
|
|
syncPolicy:
|
|
automated:
|
|
selfHeal: true
|
|
retry:
|
|
limit: 5`,
|
|
},
|
|
{
|
|
name: "ignore a one-off annotation with jq",
|
|
ignoreDifferences: v1alpha1.ApplicationSetIgnoreDifferences{
|
|
{JQPathExpressions: []string{`.metadata.annotations | select(.["foo.bar"] == "baz")`}},
|
|
},
|
|
foundApp: `
|
|
metadata:
|
|
annotations:
|
|
foo.bar: baz
|
|
some.other: annotation`,
|
|
generatedApp: `
|
|
metadata:
|
|
annotations:
|
|
some.other: annotation`,
|
|
expectedApp: `
|
|
metadata:
|
|
annotations:
|
|
foo.bar: baz
|
|
some.other: annotation`,
|
|
},
|
|
{
|
|
name: "ignore the source.plugin field with a json pointer",
|
|
ignoreDifferences: v1alpha1.ApplicationSetIgnoreDifferences{
|
|
{JSONPointers: []string{"/spec/source/plugin"}},
|
|
},
|
|
foundApp: `
|
|
spec:
|
|
source:
|
|
plugin:
|
|
parameters:
|
|
- name: url
|
|
string: https://example.com`,
|
|
generatedApp: `
|
|
spec:
|
|
source:
|
|
plugin:
|
|
parameters:
|
|
- name: url
|
|
string: https://example.com/wrong`,
|
|
expectedApp: `
|
|
spec:
|
|
source:
|
|
plugin:
|
|
parameters:
|
|
- name: url
|
|
string: https://example.com`,
|
|
},
|
|
{
|
|
// For this use case: https://github.com/hanzoai/cd/pull/14743#issuecomment-1761954799
|
|
name: "ignore parameters added to a multi-source app in the cluster",
|
|
ignoreDifferences: v1alpha1.ApplicationSetIgnoreDifferences{
|
|
{JQPathExpressions: []string{`.spec.sources[] | select(.repoURL | contains("test-repo")).helm.parameters`}},
|
|
},
|
|
foundApp: `
|
|
spec:
|
|
sources:
|
|
- repoURL: https://git.example.com/test-org/test-repo
|
|
helm:
|
|
parameters:
|
|
- name: test
|
|
value: hi`,
|
|
generatedApp: `
|
|
spec:
|
|
sources:
|
|
- repoURL: https://git.example.com/test-org/test-repo`,
|
|
expectedApp: `
|
|
spec:
|
|
sources:
|
|
- repoURL: https://git.example.com/test-org/test-repo
|
|
helm:
|
|
parameters:
|
|
- name: test
|
|
value: hi`,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
foundApp := v1alpha1.Application{TypeMeta: appMeta}
|
|
err := yaml.Unmarshal([]byte(tc.foundApp), &foundApp)
|
|
require.NoError(t, err, tc.foundApp)
|
|
generatedApp := v1alpha1.Application{TypeMeta: appMeta}
|
|
err = yaml.Unmarshal([]byte(tc.generatedApp), &generatedApp)
|
|
require.NoError(t, err, tc.generatedApp)
|
|
diffConfig, err := BuildIgnoreDiffConfig(tc.ignoreDifferences, normalizers.IgnoreNormalizerOpts{})
|
|
require.NoError(t, err)
|
|
err = applyIgnoreDifferences(diffConfig, &foundApp, &generatedApp)
|
|
require.NoError(t, err)
|
|
yamlFound, err := yaml.Marshal(tc.foundApp)
|
|
require.NoError(t, err)
|
|
yamlExpected, err := yaml.Marshal(tc.expectedApp)
|
|
require.NoError(t, err)
|
|
assert.YAMLEq(t, string(yamlExpected), string(yamlFound))
|
|
})
|
|
}
|
|
}
|