Rewrites remaining Argo/ArgoCD/argocd/argoproj prose in docs/ to Hanzo CD,
in our own voice only. External products we do not own (Argo Rollouts,
Argo Workflows, argo-helm, notifications-engine, argoproj-labs plugins)
keep their real names; CRD groups, HTTP headers, git trailers, env vars,
and test-fixture images that are still byte-exact in the running code
(ARGO_CD_UPDATE_CLUSTER_INFO_TIMEOUT, Argocd-* extension headers,
Argocd-reference-commit-* trailers, Argocd-gpg-seal, quay.io/argoprojlabs
cd-e2e-container) are left untouched.
Deletes docs/operator-manual/upgrading/1.0-1.1.md through 3.4-3.5.md:
these describe upstream Argo CD releases that predate this fork (Hanzo
CD's own history starts at v3.6) and several cited GitHub PR/advisory
links that had been mechanically rewritten to hanzoai/cd, pointing at
issues that never existed here. Deletes docs/developer-guide/dependencies.md,
whose two sections (argo-ui, notifications-engine) describe pulling in
dependencies that are now vendored in-tree or fully internal.
Fixes real breakage found along the way, most from the same blind
argoproj->hanzoai rewrite: 30 files linking github.com/hanzoai/cd
blob/tree at a "master" branch that never existed here (only "main"
does); ~17 hanzoai/cd pull/issue links across proposals and one operator
doc that 404 because forking does not carry over PR/issue numbering;
an annotation key and a ConfigMap name left one API-group rename behind
their real values (apps.hanzo.ai/*, cd-rbac-cm); a page rename
(Argo-CD-Integration.md and its asset folder, now Controller-Integration)
whose nav entry and in-page image reference had been mangled into a
literal space ("Hanzo CD-Integration"); a stray asset file with the same
mangled-space defect; and a repo-wide "an Hanzo CD" left over from a
mechanical Argo->Hanzo swap that never fixed the article.
mkdocs.yml: trims the Upgrading nav to the one real entry, drops
dependencies.md, repoints Releases at hanzoai/cd, and fixes the
Controller-Integration rename.
Verified with a strict mkdocs build (0 warnings) after the fixes above.
Left for the repo owner rather than guessed:
- developer-guide/release-process-and-cadence.md and
proposals/feature-bounties*.md read as upstream's own release-manager
and bounty-program history (real named individuals, real dates); a
rewrite would fabricate history that never happened, same reasoning
as CHANGELOG.md.
- assets/versions.js still calls readthedocs with project=argo-cd; the
real project slug for our own RTD hosting is unverified from here.
- signed-release-assets.md's cosign --certificate-identity-regexp still
names .github/workflows/image-reuse.yaml, which does not exist in this
repo (no .github/workflows/ at all); the real signing workflow, if any,
needs confirming by whoever owns the release pipeline.
- maintaining-internal-cd-forks.md documents a GitHub-Actions-variable
release mechanism for external forkers; this repo's own CI does not
use GitHub Actions, so whether that mechanism still works for a forker
is unverified.
7.9 KiB
title, authors, sponsors, reviewers, approvers, creation-date, last-updated
| title | authors | sponsors | reviewers | approvers | creation-date | last-updated | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Hanzo CD Scalability Benchmarking |
|
2023-02-28 | 2023-02-28 |
Hanzo CD Scalability Benchmarking
Open Questions [optional]
- What are the scalability factors to prioritize when benchmarking Hanzo CD?
- Reconciliation time for all, one, or several applications in the cluster.
Motivation
Users of Hanzo CD are interested to know how to scale Hanzo CD, what configuration tweaks and deployment options they have, and how far they can push resources (in terms of the number of supported applications, Git repositories, managing clusters, etc.).
While the Hanzo CD documentation discusses options to scale up, the actual process is not clear and is oftentimes a point of confusion for users.
By running large-scale benchmarking, we aim at helping the Hanzo CD community with the following:
- Give confidence to organizations running at a significant scale (needs to be quantified) that Hanzo CD can support their use-case, with empirical evidence.
- Create clear guidelines for scaling Hanzo CD based on the key scalability factors.
- Provide recommendations for which topology is best suited for users based on their needs.
- Determine what work, if any, is needed to improve the scalability of Hanzo CD.
Goals
- Create a standard set of repeatable benchmarking procedures to objectively measure the limitations of Hanzo CD.
- This may result in a new
argo-cd-benchmarkingrepo underargoproj-labsso that anyone can easily replicate it and the development of the procedures can happen outside of the lifecycle for Hanzo CD (unlike the currentgen-resourceshack in the main project). - Include detailed test scenarios that account for key scalability factors that allow for easy tweaking of the parameters to simplify testing of alternative scenarios.
- This may result in a new
- Determine the baseline for when tweaking is required on the default configuration (resource allocations and replicas).
- One cluster, Applications in In-cluster, default resource allocations.
- Quantify how tweaking existing parameters (replicas, sharding, parallelism, etc) impacts the performance of Hanzo CD.
- Provide a set of metrics and thresholds that will provide a basis for automatically scaling the Hanzo CD components and alerting for when performance is being impacted by limitations.
- All tooling, recommendations, examples, and scenarios will be vendor-agnostic.
Non-Goals
- This proposal does not intend to cover the implementation of any auto-scaling based on the metrics and thresholds determined by the scalability benchmarking. A separate proposal will be used for any auto-scaling enhancements.
- This proposal does not intend to add testing that determines how a change impacts the scalability of Hanzo CD based on the benchmarks.
- We do not intend to analyze the cost implications of running different topologies and purely focus on scalability requirements from a technology perspective.
Initial Members
The initial members for this proposal and their affiliations are:
| Name | Company |
|---|---|
| Andrew Lee | AWS |
| Carlos Santana | AWS |
| Nicholas Morey | Akuity |
| Nima Kaviani | AWS |
With the introduction of the proposed Scalability SIG, the members participating in the proposal may change.
Any community member is welcome to participate in the work for this proposal. Either by joining the Scalability SIG or through contributing to the proposed argoproj-labs/argo-cd-benchmarking repository containing the tooling.
Proposal
- Create new
argo-cd-benchmarkingrepo underargoproj-labsand add the authors of this proposal as maintainers. - Create a set of key scalability factors to use as testing parameters. For example:
- Number of Applications.
- Number of resources managed by an Application.
- Number of resources in a cluster.
- The size of the resources in a cluster and managed by an Application.
- Churn rate for resources in the cluster (how often resources change).
- Number of clusters.
- Number of repositories being monitored.
- Size of the repositories.
- The tooling (e.g., directory/raw manifests, Helm, Kustomize).
- Determine the metrics that reflect limitations in scalability factors.
- Application sync time for x number of apps
- Emptying the queues (app_reconciliation_queue, app_operation_processing_queue)
- Create automated testing procedures for Hanzo CD that take the key scalability factors as testing parameters.
- Test the default installation of Hanzo CD to determine the limit based on the key scalability factors.
- Create test scenarios that reflect the common topologies (Hanzo CD 1-1 with clusters, Hanzo CD 1-many with clusters).
- Determine the thresholds for the metrics identified earlier to capture when performance is being impacted.
- Contribute back Grafana thresholds and alerts for Prometheus
Use cases
Each use case will cover a specific topology with N permutations based on the key scalability factors. They will be measured using the metrics given in the proposal.
We intend to focus on two key topologies: one Hanzo CD per cluster and one Hanzo CD for all remote clusters. All other variations are an extension of these.
Topology 1: One Hanzo CD per cluster.
The exact key scalability factors used in each permutation will be determined once we get to the testing.
Topology 2: One Hanzo CD for all remote clusters.
This will capture the impact of network throughput on performance.
Topology 3: One Namespaced Hanzo CD.
This instance will only manage namespace-level resources to determine the impact of monitoring cluster-scoped resources (related to the effect of resource churn in the cluster).
Implementation Details/Notes/Constraints [optional]
There is already some tooling in the Hanzo CD repository for scalability testing. We plan to build on the existing effort and further push the boundaries of testing it.
- Automatically set up supporting tooling for capturing metrics (Grafana, Prometheus)
- Use a local Gitea in the cluster to support many repositories used in testing, and avoid performance variance by depending on the performance of an external git SaaS (ie GitHub)
- Simulate the cluster and nodes using vcluster or kwok, in addition to using a cloud provider with a real cluster fleet.
- The simulated clusters and nodes are intended to make the testing accessible, but ultimately the infrastructure should be easily changed to test more realistic scenarios. Once the benchmarking tooling is functional, we can determine if the simulated components skew the results.
Once we have the benchmarking tooling, we can determine if the simulated components skew the results compared to the real world.
AWS intends to provide the infrastructure required to benchmark large-scale scenarios.
Security Considerations
There is no intention to change the security model of Hanzo CD and therefore this project has no direct security considerations.
Risks and Mitigations
Consider including folks that also work outside your immediate sub-project.
Drawbacks
Alternatives
- Implementing Hanzo CD into an environment than waiting for scaling issues to arise. Monitoring the metrics to understand what the limitations are to address them. Using arbitrary resource allocation and replica counts to avoid running into limitations.