mirror of
https://github.com/hanzoai/cd.git
synced 2026-10-30 14:56:45 +00:00
zeekay
88d492e081
Drops the Argo/ArgoCD prefix from our own const, type and field names (ArgoCDConfigMapName -> ConfigMapName, ArgoCDSettings -> Settings, ArgoCDServer -> Server, HeaderArgoCD* -> HeaderCD*, the argocd-manager RBAC names, the CLI-facing Env* aliases, and the three separately scoped ArgoCDNamespace test/CLI defaults) and reflows the surrounding comments and log/help text from Argo CD to Hanzo CD. Runtime string values are untouched (still hanzocd-*, argo-cd-cli, argo-cd, etc.) — renaming those is a live ConfigMap/Secret/service-name and OAuth-client-ID change that has to land with the manifests and Hanzo IAM/dex registration together, not silently inside a naming pass. argoproj.io, other real upstream API groups, GitHub issue/PR citations, and external URLs are untouched throughout. Verified with go build ./... and go vet ./... (both clean); go test ./util/... ./controller/... ./server/... has the identical 26/26 pre-existing failing packages before and after (root cause: an unrelated redis-removal regression, not this change — see report).
206 lines
6.4 KiB
Go
206 lines
6.4 KiB
Go
package e2e
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
repositorypkg "github.com/hanzoai/cd/pkg/apiclient/repository"
|
|
"github.com/hanzoai/cd/pkg/apis/application/v1alpha1"
|
|
"github.com/hanzoai/cd/test/e2e/fixture"
|
|
"github.com/hanzoai/cd/test/e2e/fixture/app"
|
|
"github.com/hanzoai/cd/test/e2e/fixture/repos"
|
|
"github.com/hanzoai/cd/util/errors"
|
|
utilio "github.com/hanzoai/cd/util/io"
|
|
)
|
|
|
|
func TestAddRemovePublicRepo(t *testing.T) {
|
|
app.Given(t).And(func() {
|
|
repoURL := fixture.RepoURL(fixture.RepoURLTypeFile)
|
|
_, err := fixture.RunCli("repo", "add", repoURL)
|
|
require.NoError(t, err)
|
|
|
|
conn, repoClient, err := fixture.CDClientset.NewRepoClient()
|
|
require.NoError(t, err)
|
|
defer utilio.Close(conn)
|
|
|
|
repo, err := repoClient.ListRepositories(t.Context(), &repositorypkg.RepoQuery{})
|
|
|
|
require.NoError(t, err)
|
|
exists := false
|
|
for i := range repo.Items {
|
|
if repo.Items[i].Repo == repoURL {
|
|
exists = true
|
|
break
|
|
}
|
|
}
|
|
assert.True(t, exists)
|
|
|
|
_, err = fixture.RunCli("repo", "rm", repoURL)
|
|
require.NoError(t, err)
|
|
|
|
repo, err = repoClient.ListRepositories(t.Context(), &repositorypkg.RepoQuery{})
|
|
require.NoError(t, err)
|
|
exists = false
|
|
for i := range repo.Items {
|
|
if repo.Items[i].Repo == repoURL {
|
|
exists = true
|
|
break
|
|
}
|
|
}
|
|
assert.False(t, exists)
|
|
})
|
|
}
|
|
|
|
func TestGetRepoWithInheritedCreds(t *testing.T) {
|
|
app.Given(t).And(func() {
|
|
// create repo credentials
|
|
errors.NewHandler(t).FailOnErr(fixture.RunCli("repocreds", "add", fixture.RepoURL(fixture.RepoURLTypeHTTPSOrg), "--github-app-id", fixture.GithubAppID, "--github-app-installation-id", fixture.GithubAppInstallationID, "--github-app-private-key-path", repos.CertKeyPath(t)))
|
|
|
|
repoURL := fixture.RepoURL(fixture.RepoURLTypeHTTPS)
|
|
|
|
// Hack: First we need to create repo with valid credentials
|
|
errors.NewHandler(t).FailOnErr(fixture.RunCli("repo", "add", repoURL, "--username", fixture.GitUsername, "--password", fixture.GitPassword, "--insecure-skip-server-verification"))
|
|
|
|
// Then, we remove username/password so that the repo inherits the credentials from our repocreds
|
|
conn, repoClient, err := fixture.CDClientset.NewRepoClient()
|
|
require.NoError(t, err)
|
|
defer utilio.Close(conn)
|
|
|
|
_, err = repoClient.UpdateRepository(t.Context(), &repositorypkg.RepoUpdateRequest{
|
|
Repo: &v1alpha1.Repository{
|
|
Repo: repoURL,
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
// CLI output should indicate that repo has inherited credentials
|
|
out, err := fixture.RunCli("repo", "get", repoURL)
|
|
require.NoError(t, err)
|
|
assert.Contains(t, out, "inherited")
|
|
|
|
_, err = fixture.RunCli("repo", "rm", repoURL)
|
|
require.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func TestUpsertExistingRepo(t *testing.T) {
|
|
app.Given(t).And(func() {
|
|
repoURL := fixture.RepoURL(fixture.RepoURLTypeFile)
|
|
_, err := fixture.RunCli("repo", "add", repoURL)
|
|
require.NoError(t, err)
|
|
|
|
_, err = fixture.RunCli("repo", "add", repoURL, "--username", fixture.GitUsername, "--password", fixture.GitPassword)
|
|
require.Error(t, err)
|
|
|
|
_, err = fixture.RunCli("repo", "add", repoURL, "--upsert", "--username", fixture.GitUsername, "--password", fixture.GitPassword)
|
|
require.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func TestAddRemoveHelmRepo(t *testing.T) {
|
|
app.Given(t).CustomCACertAdded().And(func() {
|
|
_, err := fixture.RunCli("repo", "add", fixture.RepoURL(fixture.RepoURLTypeHelm),
|
|
"--name", "testrepo",
|
|
"--type", "helm",
|
|
"--username", fixture.GitUsername,
|
|
"--password", fixture.GitPassword,
|
|
"--tls-client-cert-path", repos.CertPath(t),
|
|
"--tls-client-cert-key-path", repos.CertKeyPath(t))
|
|
require.NoError(t, err)
|
|
|
|
conn, repoClient, err := fixture.CDClientset.NewRepoClient()
|
|
require.NoError(t, err)
|
|
defer utilio.Close(conn)
|
|
|
|
repo, err := repoClient.ListRepositories(t.Context(), &repositorypkg.RepoQuery{})
|
|
|
|
require.NoError(t, err)
|
|
exists := false
|
|
for i := range repo.Items {
|
|
if repo.Items[i].Repo == fixture.RepoURL(fixture.RepoURLTypeHelm) {
|
|
exists = true
|
|
break
|
|
}
|
|
}
|
|
assert.True(t, exists)
|
|
|
|
_, err = fixture.RunCli("repo", "rm", fixture.RepoURL(fixture.RepoURLTypeHelm))
|
|
require.NoError(t, err)
|
|
|
|
repo, err = repoClient.ListRepositories(t.Context(), &repositorypkg.RepoQuery{})
|
|
require.NoError(t, err)
|
|
exists = false
|
|
for i := range repo.Items {
|
|
if repo.Items[i].Repo == fixture.RepoURL(fixture.RepoURLTypeHelm) {
|
|
exists = true
|
|
break
|
|
}
|
|
}
|
|
assert.False(t, exists)
|
|
})
|
|
}
|
|
|
|
func TestAddHelmRepoInsecureSkipVerify(t *testing.T) {
|
|
app.Given(t).And(func() {
|
|
_, err := fixture.RunCli("repo", "add", fixture.RepoURL(fixture.RepoURLTypeHelm),
|
|
"--name", "testrepo",
|
|
"--type", "helm",
|
|
"--username", fixture.GitUsername,
|
|
"--password", fixture.GitPassword,
|
|
"--insecure-skip-server-verification",
|
|
"--tls-client-cert-path", repos.CertPath(t),
|
|
"--tls-client-cert-key-path", repos.CertKeyPath(t))
|
|
|
|
require.NoError(t, err)
|
|
|
|
conn, repoClient, err := fixture.CDClientset.NewRepoClient()
|
|
require.NoError(t, err)
|
|
|
|
defer utilio.Close(conn)
|
|
|
|
repo, err := repoClient.ListRepositories(t.Context(), &repositorypkg.RepoQuery{})
|
|
|
|
require.NoError(t, err)
|
|
|
|
exists := false
|
|
for i := range repo.Items {
|
|
if repo.Items[i].Repo == fixture.RepoURL(fixture.RepoURLTypeHelm) {
|
|
exists = true
|
|
break
|
|
}
|
|
}
|
|
assert.True(t, exists)
|
|
})
|
|
}
|
|
|
|
func TestFailOnPrivateRepoCreationWithPasswordAndBearerToken(t *testing.T) {
|
|
app.Given(t).And(func() {
|
|
repoURL := fixture.RepoURL(fixture.RepoURLTypeFile)
|
|
_, err := fixture.RunCli("repo", "add", repoURL, "--password", fixture.GitPassword, "--bearer-token", fixture.GitBearerToken)
|
|
require.ErrorContains(t, err, "only --bearer-token or --password is allowed, not both")
|
|
})
|
|
}
|
|
|
|
func TestFailOnCreatePrivateNonHTTPSRepoWithBearerToken(t *testing.T) {
|
|
app.Given(t).And(func() {
|
|
repoURL := fixture.RepoURL(fixture.RepoURLTypeFile)
|
|
_, err := fixture.RunCli("repo", "add", repoURL, "--bearer-token", fixture.GitBearerToken)
|
|
require.ErrorContains(t, err, "--bearer-token is only supported for HTTPS repositories")
|
|
})
|
|
}
|
|
|
|
func TestFailOnCreatePrivateNonGitRepoWithBearerToken(t *testing.T) {
|
|
app.Given(t).And(func() {
|
|
repoURL := fixture.RepoURL(fixture.RepoURLTypeHelm)
|
|
_, err := fixture.RunCli("repo", "add", repoURL, "--bearer-token", fixture.GitBearerToken,
|
|
"--insecure-skip-server-verification",
|
|
"--tls-client-cert-path", repos.CertPath(t),
|
|
"--tls-client-cert-key-path", repos.CertKeyPath(t),
|
|
"--name", "testrepo",
|
|
"--type", "helm")
|
|
require.ErrorContains(t, err, "--bearer-token is only supported for Git repositories")
|
|
})
|
|
}
|