mirror of
https://github.com/hanzoai/chat.git
synced 2026-09-30 20:51:17 +00:00
Three defects that met at the same place: a new visitor's first message failed,
and nothing on screen said why.
1. A gateway 402 rendered as "Something went wrong on our side".
Measured live: signed-in user, model `enso`, real message. The stored message
was `{"type":"error","error":"An error occurred while processing the request:
402 invalid API key"}` — prose. `Messages/Content/Error.tsx` dispatches on a
CODE, so a paywall read as an outage to someone holding a credit card.
The status was never lost upstream (langchain re-throws the OpenAI client's
`APIError` untouched for a 402, so `err.status === 402` is right there); it was
thrown away by the carriers. `server/utils/refusal.js` is now the ONE place
that names a failure — the thrower's code wins, else the status names it — and
both carriers use it: the agent run's error content part
(`controllers/agents/client.js`) and `handleAbortError`, which used to pass a
message through only when it happened to contain the substring `"type"`.
`middleware/error.js#sendResponse` no longer answers every failure with 500.
This is the rule `routes/ask.js#relayStatus` already applies to the answer
engine, and the shape `controllers/agents/request.js` already answers with.
Client side, `errorKey` now also reads an OpenAI-shaped nested body
(`{error:{code}}`), and `insufficient_quota` renders the add-credit action
instead of upstream's "set up your own API key" — there is no key to set on
hanzo.chat; the money lives at billing.hanzo.ai. The generic fallback stays
for failures that genuinely name nothing.
2. The mode selector opened on Search, which is sign-in gated.
Search relays to cloud `/v1/ask` and needs a real principal, so an anonymous
visitor's FIRST message was a 401 rendered as an inline error. Chat is the
guest-scoped preview, and when even that is refused its submit path opens the
login gate. It is also what the chips already say — `chat` is listed first.
3. The guest mint 429'd after a handful of page loads, then failed silently.
The client DISCARDED a live guest bearer on every page load and minted a fresh
one, so `guestTokenLimiter` was measuring page views rather than mint-spam —
and behind Cloudflare one CF-Connecting-IP can be a whole office. The token
already carries its own lifetime, so it is now reused for it (sessionStorage,
not localStorage: a bearer must not outlive the visit on a shared browser). A
visit costs one mint per expiry window instead of one per paint; the ceiling
itself is unchanged, because the number was never the fix.
And when the mint IS refused, say so. It used to pass in total silence —
`Root` fell through to the marketing page, so a 429 on an auxiliary token read
as a site with no composer and no explanation. `acquireGuest` now opens the
ONE login gate with a new reason, `unavailable`, and `Root` mounts that gate
alongside the landing. Because auth resolves before the shell paints, the gate
picks up a reason that landed while it was unmounted; reading consumes it, so
a dismissal is never undone by a remount.
Tests: api 2287 -> 2312 passing, client 1792 -> 1809 passing, 0 new failures
(pre-existing failures unchanged at 408 api / 503 client). Lint 893 -> 892
problems — one pre-existing prettier error fixed, none introduced.
Co-authored-by: Hanzo Dev <[email protected]>
306 lines
9.3 KiB
JavaScript
306 lines
9.3 KiB
JavaScript
const { logger } = require('@hanzochat/data-schemas');
|
|
const {
|
|
countTokens,
|
|
isEnabled,
|
|
sendEvent,
|
|
GenerationJobManager,
|
|
sanitizeMessageForTransmit,
|
|
} = require('@hanzochat/api');
|
|
const { isAssistantsEndpoint, ErrorTypes } = require('@hanzochat/data-provider');
|
|
const { spendTokens, spendStructuredTokens } = require('~/models/spendTokens');
|
|
const { truncateText, smartTruncateText } = require('~/app/clients/prompts');
|
|
const clearPendingReq = require('~/cache/clearPendingReq');
|
|
const { sendError } = require('~/server/middleware/error');
|
|
const { refusalText } = require('~/server/utils/refusal');
|
|
const { saveMessage, getConvo } = require('~/models');
|
|
const { abortRun } = require('./abortRun');
|
|
|
|
/**
|
|
* Spend tokens for all models from collected usage.
|
|
* This handles both sequential and parallel agent execution.
|
|
*
|
|
* IMPORTANT: After spending, this function clears the collectedUsage array
|
|
* to prevent double-spending. The array is shared with AgentClient.collectedUsage,
|
|
* so clearing it here prevents the finally block from also spending tokens.
|
|
*
|
|
* @param {Object} params
|
|
* @param {string} params.userId - User ID
|
|
* @param {string} params.conversationId - Conversation ID
|
|
* @param {Array<Object>} params.collectedUsage - Usage metadata from all models
|
|
* @param {string} [params.fallbackModel] - Fallback model name if not in usage
|
|
*/
|
|
async function spendCollectedUsage({ userId, conversationId, collectedUsage, fallbackModel }) {
|
|
if (!collectedUsage || collectedUsage.length === 0) {
|
|
return;
|
|
}
|
|
|
|
const spendPromises = [];
|
|
|
|
for (const usage of collectedUsage) {
|
|
if (!usage) {
|
|
continue;
|
|
}
|
|
|
|
// Support both OpenAI format (input_token_details) and Anthropic format (cache_*_input_tokens)
|
|
const cache_creation =
|
|
Number(usage.input_token_details?.cache_creation) ||
|
|
Number(usage.cache_creation_input_tokens) ||
|
|
0;
|
|
const cache_read =
|
|
Number(usage.input_token_details?.cache_read) || Number(usage.cache_read_input_tokens) || 0;
|
|
|
|
const txMetadata = {
|
|
context: 'abort',
|
|
conversationId,
|
|
user: userId,
|
|
model: usage.model ?? fallbackModel,
|
|
};
|
|
|
|
if (cache_creation > 0 || cache_read > 0) {
|
|
spendPromises.push(
|
|
spendStructuredTokens(txMetadata, {
|
|
promptTokens: {
|
|
input: usage.input_tokens,
|
|
write: cache_creation,
|
|
read: cache_read,
|
|
},
|
|
completionTokens: usage.output_tokens,
|
|
}).catch((err) => {
|
|
logger.error('[abortMiddleware] Error spending structured tokens for abort', err);
|
|
}),
|
|
);
|
|
continue;
|
|
}
|
|
|
|
spendPromises.push(
|
|
spendTokens(txMetadata, {
|
|
promptTokens: usage.input_tokens,
|
|
completionTokens: usage.output_tokens,
|
|
}).catch((err) => {
|
|
logger.error('[abortMiddleware] Error spending tokens for abort', err);
|
|
}),
|
|
);
|
|
}
|
|
|
|
// Wait for all token spending to complete
|
|
await Promise.all(spendPromises);
|
|
|
|
// Clear the array to prevent double-spending from the AgentClient finally block.
|
|
// The collectedUsage array is shared by reference with AgentClient.collectedUsage,
|
|
// so clearing it here ensures recordCollectedUsage() sees an empty array and returns early.
|
|
collectedUsage.length = 0;
|
|
}
|
|
|
|
/**
|
|
* Abort an active message generation.
|
|
* Uses GenerationJobManager for all agent requests.
|
|
* Since streamId === conversationId, we can directly abort by conversationId.
|
|
*/
|
|
async function abortMessage(req, res) {
|
|
const { abortKey, endpoint } = req.body;
|
|
|
|
if (isAssistantsEndpoint(endpoint)) {
|
|
return await abortRun(req, res);
|
|
}
|
|
|
|
const conversationId = abortKey?.split(':')?.[0] ?? req.user.id;
|
|
const userId = req.user.id;
|
|
|
|
// Use GenerationJobManager to abort the job (streamId === conversationId)
|
|
const abortResult = await GenerationJobManager.abortJob(conversationId);
|
|
|
|
if (!abortResult.success) {
|
|
if (!res.headersSent) {
|
|
return res.status(204).send({ message: 'Request not found' });
|
|
}
|
|
return;
|
|
}
|
|
|
|
const { jobData, content, text, collectedUsage } = abortResult;
|
|
|
|
const completionTokens = await countTokens(text);
|
|
const promptTokens = jobData?.promptTokens ?? 0;
|
|
|
|
const responseMessage = {
|
|
messageId: jobData?.responseMessageId,
|
|
parentMessageId: jobData?.userMessage?.messageId,
|
|
conversationId: jobData?.conversationId,
|
|
content,
|
|
text,
|
|
sender: jobData?.sender ?? 'AI',
|
|
finish_reason: 'incomplete',
|
|
endpoint: jobData?.endpoint,
|
|
iconURL: jobData?.iconURL,
|
|
model: jobData?.model,
|
|
unfinished: false,
|
|
error: false,
|
|
isCreatedByUser: false,
|
|
tokenCount: completionTokens,
|
|
};
|
|
|
|
// Spend tokens for ALL models from collectedUsage (handles parallel agents/addedConvo)
|
|
if (collectedUsage && collectedUsage.length > 0) {
|
|
await spendCollectedUsage({
|
|
userId,
|
|
conversationId: jobData?.conversationId,
|
|
collectedUsage,
|
|
fallbackModel: jobData?.model,
|
|
});
|
|
} else {
|
|
// Fallback: no collected usage, use text-based token counting for primary model only
|
|
await spendTokens(
|
|
{ ...responseMessage, context: 'incomplete', user: userId },
|
|
{ promptTokens, completionTokens },
|
|
);
|
|
}
|
|
|
|
await saveMessage(
|
|
req,
|
|
{ ...responseMessage, user: userId },
|
|
{ context: 'api/server/middleware/abortMiddleware.js' },
|
|
);
|
|
|
|
// Get conversation for title
|
|
const conversation = await getConvo(userId, conversationId);
|
|
|
|
const finalEvent = {
|
|
title: conversation && !conversation.title ? null : conversation?.title || 'New Chat',
|
|
final: true,
|
|
conversation,
|
|
requestMessage: jobData?.userMessage
|
|
? sanitizeMessageForTransmit({
|
|
messageId: jobData.userMessage.messageId,
|
|
parentMessageId: jobData.userMessage.parentMessageId,
|
|
conversationId: jobData.userMessage.conversationId,
|
|
text: jobData.userMessage.text,
|
|
isCreatedByUser: true,
|
|
})
|
|
: null,
|
|
responseMessage,
|
|
};
|
|
|
|
logger.debug(
|
|
`[abortMessage] ID: ${userId} | ${req.user.email} | Aborted request: ${conversationId}`,
|
|
);
|
|
|
|
if (res.headersSent) {
|
|
return sendEvent(res, finalEvent);
|
|
}
|
|
|
|
res.setHeader('Content-Type', 'application/json');
|
|
res.send(JSON.stringify(finalEvent));
|
|
}
|
|
|
|
const handleAbort = function () {
|
|
return async function (req, res) {
|
|
try {
|
|
if (isEnabled(process.env.LIMIT_CONCURRENT_MESSAGES)) {
|
|
await clearPendingReq({ userId: req.user.id });
|
|
}
|
|
return await abortMessage(req, res);
|
|
} catch (err) {
|
|
logger.error('[abortMessage] handleAbort error', err);
|
|
}
|
|
};
|
|
};
|
|
|
|
/**
|
|
* Handle abort errors during generation.
|
|
* @param {ServerResponse} res
|
|
* @param {ServerRequest} req
|
|
* @param {Error | unknown} error
|
|
* @param {Partial<TMessage> & { partialText?: string }} data
|
|
* @returns {Promise<void>}
|
|
*/
|
|
const handleAbortError = async (res, req, error, data) => {
|
|
if (error?.message?.includes('base64')) {
|
|
logger.error('[handleAbortError] Error in base64 encoding', {
|
|
...error,
|
|
stack: smartTruncateText(error?.stack, 1000),
|
|
message: truncateText(error.message, 350),
|
|
});
|
|
} else {
|
|
logger.error('[handleAbortError] AI response error; aborting request:', error);
|
|
}
|
|
const { sender, conversationId, messageId, parentMessageId, userMessageId, partialText } = data;
|
|
|
|
if (error.stack && error.stack.includes('google')) {
|
|
logger.warn(
|
|
`AI Response error for conversation ${conversationId} likely caused by Google censor/filter`,
|
|
);
|
|
}
|
|
|
|
/**
|
|
* The refusal keeps its STATUS and CODE. This used to pass a message through
|
|
* only when it happened to contain the substring `"type"` and otherwise throw
|
|
* the reason away, so an upstream 402 — a paywall — was stored as a sentence
|
|
* with nothing machine-readable in it and rendered as a generic failure.
|
|
* `server/utils/refusal.js` is the one place that decides what a failure is
|
|
* called; an unnamed one still gets the sentence below.
|
|
*/
|
|
let errorText = refusalText(
|
|
error,
|
|
'An error occurred while processing your request. Please contact the Admin.',
|
|
);
|
|
|
|
if (error?.type === ErrorTypes.INVALID_REQUEST) {
|
|
errorText = `{"type":"${ErrorTypes.INVALID_REQUEST}"}`;
|
|
}
|
|
|
|
if (error?.message?.includes("does not support 'system'")) {
|
|
errorText = `{"type":"${ErrorTypes.NO_SYSTEM_MESSAGES}"}`;
|
|
}
|
|
|
|
/**
|
|
* @param {string} partialText
|
|
* @returns {Promise<void>}
|
|
*/
|
|
const respondWithError = async (partialText) => {
|
|
const endpointOption = req.body?.endpointOption;
|
|
let options = {
|
|
sender,
|
|
messageId,
|
|
conversationId,
|
|
parentMessageId,
|
|
text: errorText,
|
|
user: req.user.id,
|
|
spec: endpointOption?.spec,
|
|
iconURL: endpointOption?.iconURL,
|
|
modelLabel: endpointOption?.modelLabel,
|
|
shouldSaveMessage: userMessageId != null,
|
|
model: endpointOption?.modelOptions?.model || req.body?.model,
|
|
};
|
|
|
|
if (req.body?.agent_id) {
|
|
options.agent_id = req.body.agent_id;
|
|
}
|
|
|
|
if (partialText) {
|
|
options = {
|
|
...options,
|
|
error: false,
|
|
unfinished: true,
|
|
text: partialText,
|
|
};
|
|
}
|
|
|
|
await sendError(req, res, options);
|
|
};
|
|
|
|
if (partialText && partialText.length > 5) {
|
|
try {
|
|
return await abortMessage(req, res);
|
|
} catch (err) {
|
|
logger.error('[handleAbortError] error while trying to abort message', err);
|
|
return respondWithError(partialText);
|
|
}
|
|
} else {
|
|
return respondWithError();
|
|
}
|
|
};
|
|
|
|
module.exports = {
|
|
handleAbort,
|
|
handleAbortError,
|
|
};
|