10 Commits

Include renames

Author	SHA1	Message	Date
zeekay	88d3bee3d7	integrations described slack/install twice, so thirteen apps could not build ... apps/integrations carried two openapi.Describe calls for GET /v1/integrations/slack/install, written by different hands into different init() funcs. Describe panics on a duplicate — correctly, because two descriptions of one operation means one of them renders and nobody can tell which — and that panic fires at init, so it took down every app that links integrations: ads, automations, campaign, catalogsync, channels, cloudflare, company, content, destinations, git, guide, integrations and sync all failed to describe. The earlier one survives. It was already the superset: it has the attribution constraint (Slack refuses a slack.com URL in that field, so the click has to route through an address of ours to be counted) AND the tenant point (public, no principal, binds no org, because minting an org for an anonymous click is the one thing that would break isolation). The later one had a single fact the first did not — 503 where the app is unconfigured, rather than a consent URL with an empty client_id that Slack renders as its own dead end — so that sentence moved across before the duplicate went. The floor drops for the merge's own deletion too: /v1/billing/gpu/charge and /v1/billing/gpu/eligibility are gone because GPU is metered like any other resource now, and the bespoke prepay path with it. Checked rather than assumed — a -1 that is not a multiple of two is not a TRACE/OPTIONS removal, and an unexplained shrink is exactly what the ratchet is there to make someone look at. 1762 paths, 2480 operations, 185 products. Every one carries an operationId and a summary; 51 still want a long description and 49 of those are hanzoai/ai, whose prose belongs on its controllers, in that repo.	2026-08-06 03:21:23 -07:00
hanzo-dev	3b50091c77	mcp: the catalogue is a query — delete the 116 committed tool files ... The fleet's agent door answered from plugin/<app>/mcp.json: the tool array each app's binary projected when it was BUILT, embedded by plugin/embed.go and handed to zip as Plugin.Tools. 116 files, 49,865 lines, and a second source for a fact every child already knows. A second source can only be stale or accidentally correct. This one was stale in the way no gate in this repository could see: o11y's 353 missing ops live in github.com/hanzoai/o11y, so a go.mod bump in ANOTHER repo invalidated an artifact in this one with nothing in the diff to say so. Regenerating it more often is not the fix — a generator on a hook is still two sources with a race between them, and the trigger is in a different repository. (593aa309 did regenerate it, which is why the file reads 365 today. The next cross-repo bump silently un-fixes it.) So the host asks. POST /v1/mcp is the HOST's own handler now (zip's is Disabled, so exactly one handler holds the address). A tools/list forwards the CALLER's own message to every composed subsystem's own /mcp over its private ZAP socket, in parallel, and unions the replies — zip.App.Start resolves a cold child on the same single-flighted path a prefix request takes, so the first list pays one start per app and nothing after it does. A tools/call goes to the app that listed the name, verbatim; the child's own registry decides whether the tool exists. A SUBSYSTEM THAT DOES NOT ANSWER IS NAMED, in result._meta["hanzo.ai/unavailable"], because a silently-short list and a stale file are the same defect: the caller cannot tell an app that serves nothing from one that did not answer. Measured on the built binaries — host + real o11y child, kms pointed at a dead address: tools=364, unavailable=[{kms, connection refused}] 364 and not 365 because o11y projects get_v1_o11y_logs twice; the door serves the first and logs the collision. THAT DUPLICATE IS WHY cmd/cloud's tests were red on main — zip refused the Load ("tool is already served by plugin o11y"), a boot failure. One name still has one owner; it is no longer fatal to the fleet. Also gone with the mechanism they configured: manifest.App.Open and zip's one-open-plugin rule. The host forwards the caller's own request to EVERY subsystem now, so each answers for this caller out of its own rows, and being asked per caller is no longer a privilege one app holds. The release gate moved with the door. Car 3 compared the live tool count against `jq -s length` over the committed files — both sides were the same bytes, so it proved only that the image carried its own tree, and it passed while o11y's catalogue held 12 of 365. It asks the better question now: did every subsystem answer. A broken deployment used to match the files exactly. plugin/<app>/openapi.json SURVIVES, for the one reason the catalogue could not: the weave carries each subsystem's prose, and that prose is lifted from the app's SOURCE at describe time (openapi.Synopsis). A running child has no comment to read and would answer with its deployment's brand blurb, which the weave would publish as the description of every product tag. Deleting that half waits on the synopsis becoming a declared value. Tests are against RUNNING subsystems (fleet/mcp_test.go): real zip children on real ZAP sockets, exact sets, bodies never status codes. Mutation-checked three ways — unmount a child, silence the outage report, ask only the first app — all three go red. Co-authored-by: Hanzo Dev <dev@hanzo.ai>	2026-08-02 14:22:10 -07:00
hanzo-dev	f403c603f1	cloud: the composition root's verb is Listen, because that is what it does ... Serve and Listen were two names for one act. zip's App already calls it Listen — `app.Listen(zapAddr, httpAddr)` — and this function's whole job is to build that app and hand it its addresses, so calling it Serve made the entry point disagree with the thing it enters. One verb, all the way down: a plugin's main says cloud.Listen, cloud says app.Listen, and nothing has to be translated in a reader's head on the way through. 117 composition roots move with it. ServePlane is untouched — it names a different act (bind one app's own socket for the internal plane), and collapsing it into this would be the opposite of the point. Also fixes apps/iam's TestMain, which had gone red on every store test: credz.Boot's last resort is cek.EnsureDevKey, and that DECLINES on a codec-linked build by design — a build that can really encrypt must be handed a real key, not invent one. So the throwaway goes in through the same door a deployment uses, and only when nothing else supplied one. Six failures back to the one pre-existing ratchet (iam serves 97 untyped ops against a budget of 88). Co-authored-by: Hanzo Dev <dev@hanzo.ai>	2026-08-02 09:53:56 -07:00
antje	c6402fab84	api: a wallet proposes transactions, not safe-tx ... POST /v1/wallets/:id/safe-tx -> POST /v1/wallets/:id/transactions. Two faults in one name. `tx` is an abbreviation of the noun, and `safe` was already said: custody is a property of the WALLET, the route reads it off the wallet (`safeCustody` answers, any other custody is a 400), and the caller never chooses it. What the route creates is a transaction on that wallet, so the collection it posts into is `transactions` — beside the /:id/keys and /:id/sign this surface already spells out. The Safe protocol's own vocabulary does NOT move. SafeTx, SafeTxResult and the `safeTxHash` field are Gnosis Safe's EIP-712 names — the hash a Safe contract verifies on-chain is called safeTxHash by the contract, not by us — so renaming them would be renaming somebody else's contract. Only our address changes; ops.proposeSafeTx follows it to proposeTransaction so the handler and the route read the same, and the private safeclient.proposeSafeTx (which speaks to the ring, not to our callers) keeps its name. Regenerated: apps/wallets/zipdoc_gen.go, plugin/wallets/{openapi,mcp}.json, and openapi.yaml woven from the subsets.	2026-07-31 17:08:24 -07:00
hanzo-dev	668c63ac33	docs: lead every money/identity app doc with the product, not the plumbing ... The first sentence of an app's package doc is not internal prose. It projects verbatim into three places a paying customer reads — the CLI group help line, the OpenAPI tag description, and the MCP tool prose — so a sentence that opens "mounts the ... surface", "is the ... plane", or names a /v1 path describes the implementation to someone who asked what they bought. Rewrites the opener of 32 app packages across billing/money and identity/security to state what the customer gets, and reflows the displaced detail into sentence two. Nothing is deleted: every path, mount note, store shape and tenancy invariant that was in sentence one is still in the doc, one sentence lower, where an engineer reading the package still finds it. billing money door -> your org's balance, what it has spent, the cards it pays with books "at /v1/books" -> chart of accounts, ledger, bank reconciliation, the reports o11y "ONE owner of the observability plane" -> your logs, metrics and traces usage "the usage plane at /v1/usage" -> what your org ran and what it cost principal "ONE place the data plane turns a request into an org" -> the guarantee that one org never reads another's data iam is left alone: "Hanzo's identity provider: users, organizations, applications, and the OIDC/OAuth2 endpoints every Hanzo service authenticates against" already leads with the product. Six of the 32 (finance, payout, metering, money, idv, principal) back no plugin and so project nowhere; they are rewritten anyway, because the reason the rule exists does not depend on which reader arrives. Regenerated openapi.yaml + the 23 plugin subsets from source. The diff is the description line and nothing else — no route moved. apps/metering also drops a stale claim to live in the commerce repo; it lives here. Co-authored-by: Hanzo Dev <dev@hanzo.ai>	2026-07-30 22:44:46 -07:00
hanzo-dev	c0d7b3f969	openapi: a product tag says what the product is, in its owning package's words ... The document has always known a product's NAME mechanically — the first path segment after /v1/ — and never what the product IS. A caller reading the tag list, an agent reading the MCP door, a CLI printing `hanzo <product> --help` got 144 bare nouns. There is exactly one place that sentence is already written and already reviewed: the package doc of the package that implements the app. So this reads it rather than asking anyone to write it twice. openapi/synopsis.go Synopsis(plugin/<app>) -> the owning package's synopsis. describe.go stamps it into that app's own subset as info.description. openapi/weave.go lifts the tag prose off the subsets it already reads. ONE computation, at the one moment an app describes itself. The weave does not look the mapping up a second time in a second process — it reads the value the app that knows it already wrote down, which is why Weave stays a pure function of its parts. The owner comes from the app's own composition root: plugin/<app>/main.go imports exactly the package it mounts. Nothing else could be the source — four apps are not named after their package (audit->auditlog, evals->eval, plugins->plugin, zero-trust->zt) and one package backs two apps (account, account-bridge), so a name-derived guess is right 107 times and silently wrong 5. An app whose subsystem is another MODULE imports no package here and gets nothing, which is the honest answer. And the comment taken is the one that OPENS "Package …", not go/doc's first-file-in-filename-order fallback. Packages that open their alphabetically-first file with a note about that FILE and state the real package doc in <name>.go would otherwise publish "actions.go — the two GitOps write actions" as the deploy product's description. A misfiled sentence reads exactly like a real one; an absent one does not. 109 of 112 apps have a package doc; 85 of the 144 product tags gain a description. The three without are metrics, authz and licensing, whose subsystem is another module — there is no package here to read. The tag NAME is never conditional on a description: the list stays a function of the document's operations, so nothing enumerating products loses a product because nobody wrote a sentence. The fleet identity remains the fallback for a subset whose package has no doc, and the weave treats a part carrying it as having said nothing. THE LIFTED PROSE LOSES THE HANDLER'S OWN NAME, which is the other half of the same problem. A Go doc comment must open with the identifier it documents, and that identifier is Go's, not the document's: "GetSQL returns one database" reached the OpenAPI description, its summary, the MCP tool description an agent reads, and the CLI help line — naming a function no caller can see. zip drops an exact leading match of the handler's own name from v1.18.13 (main is on v1.18.14, whose lift is byte-identical), and nothing had regenerated against it: 35 packages carried prose the pinned zip can no longer produce. They regenerate here. Three test assertions quoted the leaked identifier and now quote the projection. Every generated artifact is regenerated FROM SOURCE (make -f mk/fleet.mk surface-check, green: 1017 paths). Nothing this commit does moves the wire: of openapi.yaml's 16,439 non-prose leaf facts, 0 changed. The 4 lost and 94 gained are all one thing — surface main already decided and never republished: /v1/insights/e removed and /v1/event given its declared body (6fc2d88c), the six project-scoped git smart-HTTP paths (811ff080), and the sessions' `terminal` property (afdda829). The three bare-root git paths reach no app, so they join router_test.go's unreachable ledger, recorded on the first regeneration that published them. Co-authored-by: Hanzo Dev <dev@hanzo.ai>	2026-07-30 21:33:38 -07:00
hanzo-dev	e247e255cf	mcp: ONE door — three hand-rolled registries collapse into the typed-op projection ... Typing a route bought OpenAPI prose, an SDK method and a CLI command, and NOTHING on the public MCP surface. zip has projected every typed op into an MCP tool since v1.18.6 and cloud never called it: manifest routed /v1/mcp to apps/tools, which hand-rolled its own tools/list + tools/call over a route-table scrape, and apps/automations hand-rolled a THIRD catalogue. Three registries for one concept, and the one the public reached exposed none of the 549 typed ops. THE DOOR IS THE HOST'S. cmd/cloud sets zip.MCPConfig{Path:"/v1/mcp"} and hands each plugin its own catalogue at Load. The host is the only process that CAN own it: MCPTools() is in-process, so a plugin cannot enumerate a lazy sibling, and a plugin-hosted door costs its own wake on the first list. Measured: POST /v1/mcp beats ai's "/v1" remainder by specificity, not registration order. THE LIST IS A BUILD ARTIFACT, so tools/list costs ZERO wakes. It has to be: 112 plugins mount LAZILY, and an MCP client calls tools/list constantly — a door that fanned out over ZAP to ask would destroy the one invariant that makes 112 services affordable. The answer is already fixed at build time, by the same typed-op registry that emits openapi.json, so `<app> describe <dir>` now writes BOTH projections from ONE mount at ONE instant: openapi.json and mcp.json. They cannot be generated apart, so a tool cannot exist without its op or carry a stale schema. The leaf plugin/embed.go go:embeds them (cmd/cloud goes 344 → 345 packages, still zero from apps/). Measured live with the WHOLE fleet mounted: 549 tools listed, child count 4 → 4 (the four eager apps, untouched). tools/call is the ONLY trigger and starts exactly one child — p.target(), the same single-flighted lazy path a prefix request takes — then forwards the SAME message to that plugin's own /mcp over ZAP on its 0700 unix socket. Never HTTP. The child's registry answers, so the host can only NAME a tool, never invoke one the child did not declare. Measured live: get_v1_pricing woke 1 child and returned the pricing catalog; get_v1_company answered its own handler's "X-Org-Id required" through the plugin's full cloud.Serve identity chain. DELETED, not left dark: apps/tools/builtin.go (223 lines) — the "full-cloud-control" route→tool scrape. Structurally dead since the monolith died: in the tools CHILD, GetRoutes() sees only tools' own ~13 routes, and its schemas were opaque {query,body} objects a model cannot fill. The new door is what it meant to be, with real schemas. apps/tools/http.go's mcp/mcpToolList/mcpToolCall/rpcResult/rpcError + the route. apps/automations/mcp.go's mcp/mcpTools/mcpResultObj/mcpErrorObj + its route. GET /v1/mcp — a Source view that is GET /v1/tools?source=mcp by its own comment. Principal.credential + credentialHeaders — replay state only builtin.go read. KEPT, because it is a different capability: apps/tools' EXTERNAL MCP server registry (records, KMS-sealed secrets, SSRF-validated dialer, tools/list fan-out), now owning /v1/mcp/servers alone. Its tools, org skills, agents, functions and connector actions are ROWS, not code, so no build-time catalogue can hold them — they are reached through the typed POST /v1/tools/call, which is itself a tool on the door. Nothing lost: connectorToolProvider already published every connector action into that one registry. THE GATE. mk/fleet.mk surface-check (which .hanzo/workflows/cicd.yml → hanzo.yml app-contract actually invokes) regenerates every app FROM SOURCE and fails on `git status --porcelain -- openapi.yaml plugin/` — mcp.json is under plugin/, so it was covered the moment it landed there. PROVEN TO FIRE: adding one typed op to apps/guide without regenerating turned it red on BOTH plugin/guide/mcp.json and plugin/guide/openapi.json; reverted, green. Four more, all cheap: no App row may claim /v1/mcp (fiber MERGES byte-identical patterns, so a Load there would shadow the door silently); no served path may END in /mcp; no Go source outside cmd/cloud may name an /mcp path unless it is a named foreign engine (apps/tasks' own surface, which is not a projection of our ops); every catalogue tool must be an operationId of its own app, unique fleet-wide, with a NON-EMPTY description — the last one because a nameless tool is a silent failure a model pays context for. 549 tools across 36 apps, 349KB on the wire. zip v1.18.11 → v1.18.12. Capability check, precisely: the 17 executable connector actions the deleted automations door listed are NOT tool names on the fleet door, because they are per-tenant rows — connectorToolProvider publishes every one of them into the ONE registry from the same `registry` map that door read, so they are reached through tools_call with the same activation, price, meter and audit. Nothing is lost; one hop is added. Same for org skills, agents, functions and external MCP servers. One door this gate structurally cannot claim: /v1/tasks/mcp is hanzoai/tasks' own engine surface behind cloud's identity gate, mounted on a raw net/http mux so it is in no subset at all. It is a foreign engine's tools, not a projection of ours, so it is NAMED in foreignDoors with the reason rather than deleted. Co-authored-by: Hanzo Dev <dev@hanzo.ai>	2026-07-30 10:11:38 -07:00
hanzo-dev	ea4be9109d	type: 35 ops across wallets, webhooks, ads, channels and code — six plugins that published nothing ... The work list was the ARTIFACT, not a grep: every operation in plugin/{wallets,webhooks,account-bridge,ads,channels,code}/openapi.json carrying neither a description nor a summary — 44 of them, six plugins at 100% undescribed, which is exactly the set that projects to NOTHING: no prose, no MCP tool, no CLI command, no typed SDK method. 35 are now typed ops. Per plugin: wallets 8/8, webhooks 8/8, code 7/7, ads 6 of 7, channels 6 of 7, account-bridge 0 of 7. Each converted package carries untypedByDesign + TestEveryRouteIsTypedOrNamed + TestEveryTypedOpIsDescribed reading the LIVE router, whose two ledgers must SUM to the served surface — so a route added untyped here goes red and a stale reason goes red too. THE NINE REFUSALS, each wire-bound and each MEASURED: * account-bridge's 7 are TWO registrations, and they were already a closed refusal one package over: verbatim per-tenant forwards on a greedy wildcard (apps/account/account.go routesBridge), held by apps/account/typed_wire_test.go. Nothing to convert. * POST /v1/ads/campaigns/{id}/launch is deliberately BODY-TOLERANT: it discards the Bind error, so a malformed body launches on the stored account at 200, where op.invoke's unconditional decode 400s. TestLaunchStillIgnoresAMalformedBody. * POST /v1/channels/{channel}/send has a package-local 1 MiB body cap a typed op never sees, AND DisallowUnknownFields, which refuses a spoofed identity field loudly where jsonenc.Unmarshal drops it silently. TestSendKeepsItsCapAndItsStrictness. WIRE PRESERVED, and the three places that took care: * POST /v1/code/ask reads ?q= first and lets a non-empty body `query` WIN — the opposite of zip's body/query/path order. One field per source (json:"-" url:"q" beside json:"query" url:"-") reproduces it rather than inverting it; all four combinations asserted. * ?since= on /v1/channels/inbox 400s on a non-integer, and setScalar silently zeroes one — so it stays a STRING. Where the handler DEFAULTS instead (?limit= on ads, webhooks, code) an int is wire-identical. * every body-only field carries url:"-": zip's binder fills an In from the query too, and ?custody=, ?prune=1, ?url= and ?dmPolicy= would each have redirected a write the body never asked for. Four TestTheQueryStringCannotRedirectAWrite. LATENT DEFECTS, all fixed: 1. five packages had NO //go:generate zipdoc directive — which is why 44 operations published nothing: the prose had nowhere to be lifted to. 2. GET|POST /v1/webhooks/ published a TRAILING SLASH (failure mode #9) for a collection every caller addresses without one. Artifact fixed, wire unmoved — both spellings still reach the handler. 3. apps/code's test harness RECONSTRUCTED its seven routes by hand, so nothing it asserted was evidence about the served surface. routes() is a function now. 4. none of the five installed a cloud.Bridge of its own, relying on Serve's app-wide install that no package test harness runs — the org path was untested. 5. two one-name/two-shape collisions the weave would have refused on entry: wallets' Account (books') and ads' Campaign (marketing's). Both unpublished names yielded — WalletAccount, AdCampaign, no wire movement. ONE DELTA, recorded not glossed: webhooks' 401 had two messages; principal.OrgFrom folds both halves into one answer, so the typed ops answer one 401 naming both. Status, shape and ordering unchanged. apps/{wallets,code,channels}/... enter allowedRequestUses with their reasons: the audit actor and the server-minted project scope (wallets), the billing payer and project (code), the org-admin mutation gate (channels). None is a tenant key. Co-authored-by: Hanzo Dev <dev@hanzo.ai>	2026-07-30 10:07:28 -07:00
antje	85dd3a6513	name: a thing the host loads is a Plugin ... MountSpec was a compound naming a struct after the mechanism that consumes it. The thing it describes is one of the plugins the host loads: name, price, mount. The directory is plugin/, the framework is the zip plugin framework, and every doc comment already called them plugins in prose. So: Plugin. Not App, which was the obvious first choice and is wrong twice over -- package cloud already declares an App in payloads.go, and the struct itself carries an App field for a subsystem that gates the whole binary. Either collision alone would have made the name ambiguous at every use site. Mechanical: 132 files, plus the parameter and loop variables that carried the old noun (specs, spec, sp) to the noun they actually hold.	2026-07-28 16:48:54 -07:00
hanzo-dev	2c4b045b0b	cmd/cloud + plugin/<app>: the light host is the one binary — scope credentials, forward flags, own "/" ... Restructure to the canonical layout: cmd/host → cmd/cloud (the host IS the one real binary; name it cloud), and every other cmd/<app> → plugin/<app>. `ls cmd/` is `cloud/` alone; `ls plugin/` is the 116 per-app + tool dirs. gen-app-cmds scaffolds into plugin/<app> and scans plugin/ for the bijection; the Dockerfile / Makefile / mk / hanzo.yml / weave / controlplane-containment gate all read the new paths. go build ./cmd/cloud links ~399 pkgs and zero subsystems. credz KMS-key leak (#51 follow-up): zip builds each child's env as append(os.Environ(), Plugin.Env...), so a host that keeps CLOUD_KMS_MASTER_KEY_REF hands the root key to EVERY child — the Root posture credz exists to prevent, and now the default entrypoint. cmd/cloud (stdlib credz/launch only — importing credz would drag cek→sqlite and re-fatten the host) mints the launch secret, scrubs the root key from its OWN environment, stamps each child a scoped CREDZ_TOKEN, and re-injects the root key onto the kms broker child's Env ALONE. Every generic child comes up with a token and no key and must ask the broker. Pinned by cmd/cloud/main_test.go and proven by a live dns spawn. helm flag forwarding: cmd/cloud accepts --brand/--domain/--data-dir/--iam-issuer (the args the chart passes the entrypoint) and republishes each non-empty one as its CLOUD_* env, which the per-app children read; an empty flag never clobbers a value already pinned in the environment. console at "/": nothing served the host root once mountConsole moved into the per-app cloud.Serve. Extract the console into a light webui leaf (stdlib + embed + a new strings-only brand leaf, both aliased back into package cloud so no call site changes) so cmd/cloud — the front door — owns "/" and serves the white-labelled SPA. The host stays ~399 packages and imports zero subsystems. Co-authored-by: Hanzo Dev <dev@hanzo.ai>	2026-07-28 12:37:17 -07:00