mirror of
https://github.com/hanzoai/commerce.git
synced 2026-10-30 15:08:42 +00:00
zeekay
f7aabf72f7
IsSuperAdmin folded the case of the home org and fell back to the owner claim, the org of the application that minted the token, and the money bits were granted on X-User-Owner == admin. Cloud writes X-User-Owner for an admin-org application and an admin-org person's API key as well as for a person, so either could mint money and edit the catalog here while being nobody in the rest of the same process. Every gate now reads X-User-IsAdmin, which the edge strips and writes from authz.Claims.Sudo alone; the standalone EdgeAuth decides it with that predicate over the verified token's signed membership set. X-User-IsAdmin no longer doubles as the org-admin bit, which is X-User-IsOrgAdmin. No machine is SuperAdmin. Global admin is SuperAdmin wherever it named this predicate.
42 lines
1.6 KiB
Go
42 lines
1.6 KiB
Go
// Copyright (c) 2014-present Hanzo AI, Inc.
|
|
// Licensed under MIT OR Apache-2.0. See LICENSE-MIT and LICENSE-APACHE.
|
|
|
|
package iammiddleware
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/zap-proto/zip"
|
|
)
|
|
|
|
// TestGetIAMClaims_HomeIsNotAuthority: the home org the boundary attests
|
|
// (X-User-Owner) is an anchor, not authority. Naming the reserved org there, or in
|
|
// X-Org-Id, grants nothing; only the edge's verdict does (sudo_test.go).
|
|
func TestGetIAMClaims_HomeIsNotAuthority(t *testing.T) {
|
|
app := zip.New(zip.Config{DisableStartupMessage: true})
|
|
cases := []struct {
|
|
name string
|
|
headers map[string]string
|
|
want bool
|
|
}{
|
|
{"nobody validated, X-Org-Id admin", map[string]string{"X-Org-Id": "admin"}, false},
|
|
{"nobody validated, X-Org-Id Admin", map[string]string{"X-Org-Id": "Admin"}, false},
|
|
{"home admin, no verdict", map[string]string{"X-User-Owner": "admin", "X-Org-Id": "admin"}, false},
|
|
{"home admin with the verdict, switched into a tenant", map[string]string{"X-User-Owner": "admin", "X-Org-Id": "acme", HeaderUserIsAdmin: "true"}, true},
|
|
{"home brand org, X-Org-Id admin", map[string]string{"X-User-Owner": "hanzo", "X-Org-Id": "admin"}, false},
|
|
{"org admin of its own org", map[string]string{"X-User-Owner": "acme", "X-Org-Id": "acme", HeaderUserIsOrgAdmin: "true"}, false},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
c := app.TestCtx(http.MethodPut, "/v1/commerce/plans/entries/dev")
|
|
for k, v := range tc.headers {
|
|
c.Fiber().Request().Header.Set(k, v)
|
|
}
|
|
if got := GetIAMClaims(c).IsSuperAdmin(); got != tc.want {
|
|
t.Fatalf("IsSuperAdmin()=%v want %v", got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|