Files
compute/util/string.go
zeekayandHanzo Dev bef227fdf9 converge util/string.go with hanzoai/ai, return the write error
SnakeString here disagreed with the copy in hanzoai/ai on two classes of
input: a leading underscore ("_Foo" gave "__foo" here, "_foo" there) and
non-ASCII uppercase ("Ünicode" was left uppercase here, lowercased there).
Adopt ai's spelling in both places, because a leading underscore already
separates and a column name should not carry an uppercase rune. Neither
class is reachable from either caller — the filter path is gated by
ReFieldWhiteList (^[A-Za-z0-9]+$) and all 611 struct field names across
both repos are ASCII with no leading underscore — so no column is renamed
and no query changes. string_test.go pins the full disagreement set so
the two copies cannot drift again silently.

That test also pins the acronym behaviour, which looks wrong and is not:
"OrgID" snakes to "org_i_d", not "org_id". An acronym-aware mapper
(orm's names.SnakeMapper) would rename 24 live columns across the two
repos, so the naive splitting is the schema contract, not an oversight.

WriteBytesToPath panicked on a failed write. It is a library function
with no callers here, so the panic was unreachable dead behaviour rather
than something anything relied on; it now returns the error like ai's.

Read/WriteStringToPath and ReadBytesFromPath move off deprecated ioutil
to os, with filepath.Clean on the read paths.

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-02 20:26:20 -07:00

157 lines
3.6 KiB
Go

// Copyright 2023 Hanzo Industries Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package util
import (
"errors"
"fmt"
"os"
"path/filepath"
"strconv"
"strings"
)
func IndexAt(s, sep string, n int) int {
idx := strings.Index(s[n:], sep)
if idx > -1 {
idx += n
}
return idx
}
func ParseInt(s string) int {
i, err := strconv.Atoi(s)
if err != nil {
panic(err)
}
return i
}
func ParseIntWithError(s string) (int, error) {
i, err := strconv.Atoi(s)
if err != nil {
return -1, err
}
if i < 0 {
return -1, errors.New("negative version number")
}
return i, nil
}
func ParseFloat(s string) float64 {
f, err := strconv.ParseFloat(s, 64)
if err != nil {
panic(err)
}
return f
}
func GetOwnerAndNameFromId(id string) (string, string) {
tokens := strings.Split(id, "/")
if len(tokens) != 2 {
panic(errors.New("GetOwnerAndNameFromId() error, wrong token count for ID: " + id))
}
return tokens[0], tokens[1]
}
func GetOwnerAndNameFromIdNoCheck(id string) (string, string) {
tokens := strings.SplitN(id, "/", 2)
return tokens[0], tokens[1]
}
func GetOwnerAndNameFromId3(id string) (string, string, string) {
tokens := strings.Split(id, "/")
if len(tokens) != 3 {
panic(errors.New("GetOwnerAndNameFromId3() error, wrong token count for ID: " + id))
}
return tokens[0], fmt.Sprintf("%s/%s", tokens[0], tokens[1]), tokens[2]
}
func GetOwnerAndNameFromId3New(id string) (string, string, string) {
tokens := strings.Split(id, "/")
if len(tokens) != 3 {
panic(errors.New("GetOwnerAndNameFromId3New() error, wrong token count for ID: " + id))
}
return tokens[0], tokens[1], tokens[2]
}
func GetIdFromOwnerAndName(owner string, name string) string {
return fmt.Sprintf("%s/%s", owner, name)
}
func ReadStringFromPath(path string) string {
data, err := os.ReadFile(filepath.Clean(path))
if err != nil {
panic(err)
}
return string(data)
}
func WriteStringToPath(s string, path string) {
err := os.WriteFile(path, []byte(s), 0o644)
if err != nil {
panic(err)
}
}
func ReadBytesFromPath(path string) []byte {
data, err := os.ReadFile(filepath.Clean(path))
if err != nil {
panic(err)
}
return data
}
func WriteBytesToPath(b []byte, path string) error {
return os.WriteFile(path, b, 0o644)
}
// SnakeString transform XxYy to xx_yy
//
// The output names a SQL column (see the ORDER BY and LIKE call sites in
// object/), so it is schema, not cosmetics. Two rules are load-bearing and both
// have a test in string_test.go:
//
// - Every capital gets its own separator, acronyms included: "OrgID" is
// "org_i_d", not "org_id". That is how the live columns were named.
// - A leading underscore already separates, so no second one is emitted:
// "_Foo" is "_foo", not "__foo".
func SnakeString(s string) string {
data := make([]byte, 0, len(s)*2)
j := false
num := len(s)
for i := 0; i < num; i++ {
d := s[i]
if i > 0 && d >= 'A' && d <= 'Z' && j {
data = append(data, '_')
}
if d != '_' {
j = true
}
data = append(data, d)
}
result := strings.ToLower(string(data[:]))
return strings.ReplaceAll(result, " ", "")
}