Files
compute/billing/reporter.go
zeekayandHanzo Dev f627cbdec2 billing: compute prices from one catalog, and refuses rather than bill zero
There were two price tables. The resale catalog answered /v1/machines/launch;
a hardcoded 32-entry map in billing/pricing.go answered the node-pool meter,
and it carried no GPU rows at all — GetHourlyCostCents returned 0 for every
slug it had never heard of, which is every GPU we sell. The map is deleted.
service.HourlyCents is the one resolver, reading the same catalog the quote
reads.

It refuses instead of returning zero. A slug the catalog does not carry, and a
slug the catalog prices at zero, both yield ErrPriceUnavailable — the upstream
publishes no free size, so a zero is an unresolved price, not a policy. That
distinction is the whole finding: "free by policy" and "we could not work out
what this costs" produced identical $0 invoices.

AuthorizeCompute and RecordCompute are the matching gate and debit, fail-closed
on every non-nil answer from commerce. launchMetered now composes the three
rather than restating them inline, so its Actor attribution matches the sweep's
and there is one place where the posture lives.

Prepaid only: NewMeteringClient drops TierAware, so the compute gate reads the
org's prepaid balance and not the tier-aware effective balance that folds in
promotional plan allotment. A free-tier grant is meant to buy inference, not an
H100. TierAware only affects Authorize's balance read, so the fleet-billing
lines this client also carries are untouched.

Sweeps say so when they cannot bill. service.Billable replaces four silent
early-returns with a WARN and a metric (visor.billing.sweeps_skipped), and the
two tickers stop deciding at STARTUP whether billing is possible: a pod that
booted before its KMS-synced COMMERCE_SERVICE_TOKEN landed created no billing
ticker at all and never billed anything for the life of the pod. Both are now
wired unconditionally and decide per tick, so a late credential starts billing
on the next hour.

Two counter changes worth stating: an unpriceable machine now counts as skipped
in the hourly sweep instead of slipping through uncounted, and the node-pool
sweep skips a pool created in the current clock hour because the create path
now debits it (service.CreatedInHour is the one launch-hour rule, shared).

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-06 02:40:31 -07:00

175 lines
5.1 KiB
Go

// Copyright 2025 Hanzo Industries Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package billing
import (
"bytes"
"context"
"encoding/json"
"fmt"
"net/http"
"time"
"github.com/hanzoai/visor/logs"
"github.com/hanzoai/visor/object"
"github.com/hanzoai/visor/service"
"github.com/hanzoai/visor/telemetry"
)
type MeterEvent struct {
MeterID string `json:"meterId"`
UserID string `json:"userId"`
Value int64 `json:"value"`
Timestamp string `json:"timestamp"`
Idempotency string `json:"idempotency"`
Dimensions map[string]string `json:"dimensions"`
}
type MeterEventRequest struct {
Events []MeterEvent `json:"events"`
}
type BillingReporter struct {
CommerceURL string
ServiceToken string
MeterID string
httpClient *http.Client
}
func NewBillingReporter(commerceURL, serviceToken string) *BillingReporter {
return &BillingReporter{
CommerceURL: commerceURL,
ServiceToken: serviceToken,
MeterID: "doks-node-hours",
httpClient: &http.Client{
Timeout: 30 * time.Second,
},
}
}
// ReportNodePoolUsage sends a meter event for a single node pool's hourly usage.
//
// The rate is the pool's own persisted CostPerHour, falling back to the ONE
// resale catalog (service.HourlyCents) for rows written before the pool path
// priced anything. An unresolvable rate is an ERROR, not a zero: this used to
// consult a hardcoded 32-entry droplet table with no GPU rows in it, so every
// GPU pool reported a value of 0 for every hour it ran.
func (r *BillingReporter) ReportNodePoolUsage(pool *object.NodePool) error {
if r.CommerceURL == "" || r.ServiceToken == "" {
return nil // billing not configured, skip silently
}
costPerHour := pool.CostPerHour
if costPerHour <= 0 {
resolved, err := service.HourlyCents(pool.Size)
if err != nil {
return fmt.Errorf("pool %s (%s): %w", pool.PoolID, pool.Size, err)
}
costPerHour = resolved
}
now := time.Now().UTC()
hourTimestamp := service.HourStamp(now)
value := costPerHour * int64(pool.Count)
userID := pool.OrgID
if userID == "" {
userID = pool.Owner
}
event := MeterEvent{
MeterID: r.MeterID,
UserID: userID,
Value: value,
Timestamp: now.Format(time.RFC3339),
Idempotency: fmt.Sprintf("doks-%s-%s", pool.PoolID, hourTimestamp),
Dimensions: map[string]string{
"size": pool.Size,
"cluster": pool.ClusterID,
"poolId": pool.PoolID,
"poolName": pool.Name,
"provider": pool.Provider,
"projectId": pool.ProjectID,
},
}
return r.sendMeterEvents([]MeterEvent{event})
}
func (r *BillingReporter) sendMeterEvents(events []MeterEvent) error {
reqBody := MeterEventRequest{Events: events}
bodyBytes, err := json.Marshal(reqBody)
if err != nil {
return fmt.Errorf("failed to marshal meter events: %w", err)
}
url := fmt.Sprintf("%s/api/v1/billing/meter-events", r.CommerceURL)
req, err := http.NewRequestWithContext(context.Background(), http.MethodPost, url, bytes.NewReader(bodyBytes))
if err != nil {
return fmt.Errorf("failed to create billing request: %w", err)
}
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", "Bearer "+r.ServiceToken)
resp, err := r.httpClient.Do(req)
if err != nil {
return fmt.Errorf("failed to send billing request: %w", err)
}
defer resp.Body.Close()
if resp.StatusCode >= 300 {
return fmt.Errorf("billing API returned status %d", resp.StatusCode)
}
return nil
}
// ReportAllNodePools fetches all node pools and reports usage for each.
//
// A pool created in the CURRENT clock hour is skipped: the create path already
// debited that hour (service.CreatedInHour is the one launch-hour rule, shared
// with the machine sweep), so reporting it again bills the same hour twice.
func (r *BillingReporter) ReportAllNodePools(ctx context.Context) {
if r.CommerceURL == "" || r.ServiceToken == "" {
logs.Warning("billing: pool.hourly sweep SKIPPED — commerceUrl/commerceToken unset, so running node pools are NOT being billed")
telemetry.CountBillingSkip(ctx, "pool.hourly")
return
}
pools := []*object.NodePool{}
// Query all node pools across all owners
err := object.GetAllNodePools(&pools)
if err != nil {
logs.Warning("billing: failed to get node pools: %v", err)
return
}
stamp := service.HourStamp(time.Now())
for _, pool := range pools {
if pool.State != "Active" || pool.Count == 0 {
continue
}
if service.CreatedInHour(pool.CreatedTime, stamp) {
continue
}
err := r.ReportNodePoolUsage(pool)
if err != nil {
logs.Warning("billing: failed to report usage for pool %s/%s: %v", pool.Owner, pool.Name, err)
}
}
}