mirror of
https://github.com/hanzoai/compute.git
synced 2026-10-30 14:50:41 +00:00
zeekayandHanzo Dev
70371d4941
visor required github.com/hanzoai/iam-v1 DIRECTLY (go.mod, 6 import sites)
while ALSO linking github.com/hanzoai/iam through cloud. One binary, both
implementations of the same idea.
iam-v1 is ARCHIVED. Its description says "no longer in any graph"; go list -deps
said otherwise. An archived repo cannot take a push, so it cannot take a
security fix — which disqualifies it as a dependency of a deployed service no
matter how good the code inside is.
The code inside is, in fact, the same code. iam-v1's ROOT package is a copy of
the Casdoor Go SDK that also lives, extracted and maintained, at
github.com/hanzoai/iamsdk/v2/iamsdk: 67 of 73 non-test files byte-identical
once the package clause is normalised. Same shape, same bounded context, same
semantics — a genuine duplicate, not a name collision, so it collapses.
Measured before landing this, so the swap drops nothing:
- ParseJwtToken + publicKeyFromPEM: byte-identical. Signature verification,
the JWKS-then-cert-PEM fallback, the algorithm allowlist — unchanged.
- jwks.go: byte-identical. Key fetch unchanged.
- iamsdk's User is a strict superset of iam-v1's.
- Zero exported symbols exist there and not here.
- What iam-v1 had and iamsdk lacked — Claims.Orgs and Claims.BillingAccount,
both signed and both minted by live IAM — went into iamsdk v2.2.1 first,
with tests. Nothing was dropped to make the merge fit.
- iam-v1's root errors.go sentinels are NOT ported: nothing in that module
ever returns them. (teamrole.ErrCrossOrg is a different package's live
guard, and visor never imported that subpackage.) Dead names, not guards.
No shim, no alias: the import is plain `iamsdk`, spelled once. The old
`iam "…/iam-v1"` alias is what let two lineages wear one name at the call site.
visor's own guards are untouched — GetBearerUser still fails closed on an empty
owner and still refuses a sibling brand's issuer; authz.IsAllowed is unchanged.
deps_test.go stops the archived module coming back, reading go.mod rather than
imports so a TRANSITIVE reintroduction fails too, and TestRetiredInDetects
proves the detector fires on the exact require line this commit deletes.
Gate: go build ./... + go vet ./... + go test ./... green before and after.
go list -deps ./... | grep hanzoai/iam-v1 → 1 package before, 0 after; go.sum
references → 0.
Co-authored-by: Hanzo Dev <[email protected]>
101 lines
2.9 KiB
Go
101 lines
2.9 KiB
Go
// Copyright 2024 Hanzo Industries Inc. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package routers
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/hanzoai/iamsdk/v2/iamsdk"
|
|
"github.com/zap-proto/zip"
|
|
|
|
"github.com/hanzoai/visor/conf"
|
|
"github.com/hanzoai/visor/object"
|
|
"github.com/hanzoai/visor/util"
|
|
)
|
|
|
|
type Response struct {
|
|
Status string `json:"status"`
|
|
Msg string `json:"msg"`
|
|
Data interface{} `json:"data"`
|
|
Data2 interface{} `json:"data2"`
|
|
}
|
|
|
|
// GetSessionUser resolves the caller from the forwarded IAM Bearer JWT — the ONE
|
|
// stateless identity seam. There is no cookie or server-side session: an API/console
|
|
// caller presents a short-lived Bearer, verified and brand-bound in
|
|
// object.GetBearerUser.
|
|
func GetSessionUser(c *zip.Ctx) *iamsdk.User {
|
|
return object.GetBearerUser(c.Header("Authorization"))
|
|
}
|
|
|
|
func getUsername(c *zip.Ctx) (username string) {
|
|
user := GetSessionUser(c)
|
|
if user != nil {
|
|
username = util.GetIdFromOwnerAndName(user.Owner, user.Name)
|
|
} else {
|
|
username, _ = getUsernameByClientIdSecret(c)
|
|
}
|
|
return
|
|
}
|
|
|
|
func requestDeny(c *zip.Ctx) error {
|
|
response := &Response{
|
|
Status: "error",
|
|
Msg: "Unauthorized operation",
|
|
}
|
|
return c.JSON(403, response)
|
|
}
|
|
|
|
// basicAuth parses an "Authorization: Basic <base64(id:secret)>" header, RFC
|
|
// 7617 — splitting on the FIRST colon so a secret may contain one. The ZAP
|
|
// replacement for net/http's Request.BasicAuth.
|
|
func basicAuth(c *zip.Ctx) (id, secret string, ok bool) {
|
|
const p = "Basic "
|
|
h := c.Header("Authorization")
|
|
if len(h) <= len(p) || !strings.EqualFold(h[:len(p)], p) {
|
|
return "", "", false
|
|
}
|
|
raw, err := base64.StdEncoding.DecodeString(strings.TrimSpace(h[len(p):]))
|
|
if err != nil {
|
|
return "", "", false
|
|
}
|
|
id, secret, found := strings.Cut(string(raw), ":")
|
|
if !found {
|
|
return "", "", false
|
|
}
|
|
return id, secret, true
|
|
}
|
|
|
|
func getUsernameByClientIdSecret(c *zip.Ctx) (string, error) {
|
|
clientId, clientSecret, ok := basicAuth(c)
|
|
if !ok {
|
|
clientId = c.Query("clientId")
|
|
clientSecret = c.Query("clientSecret")
|
|
}
|
|
|
|
if clientId == "" || clientSecret == "" {
|
|
return "", nil
|
|
}
|
|
|
|
applicationName := conf.GetConfigString("iamApplication")
|
|
if clientSecret != conf.GetConfigString("clientSecret") {
|
|
return "", fmt.Errorf("Incorrect client secret for application: %s", applicationName)
|
|
}
|
|
|
|
return fmt.Sprintf("app/%s", applicationName), nil
|
|
}
|