mirror of
https://github.com/hanzoai/datastore-go-mock.git
synced 2026-10-30 20:22:58 +00:00
## Why `clickhouse-go/v2` **v2.44.0** added a new method `HasData() bool` to the `driver.Rows` interface. SigNoz needs to upgrade to v2.44.0 (it fixes a connection-pool slot leak — `acquire conn timeout` — introduced in v2.43.0 via PRs #1759/#1795), but this mock's `*Rows` did not implement `HasData()`, so it no longer satisfies `driver.Rows` and breaks the build. This ports the mock into a SigNoz-owned module and adds the missing method. ## What - Rename module path `github.com/srikanthccv/ClickHouse-go-mock` → `github.com/SigNoz/clickhouse-go-mock` (incl. example imports). - Bump `github.com/ClickHouse/clickhouse-go/v2` `v2.43.0` → `v2.44.0`. - Implement `Rows.HasData()` to satisfy the v2.44.0 `driver.Rows` interface (mirrors `Next()` semantics). - Fix `non-constant format string in call to fmt.Errorf` vet errors flagged by the current Go toolchain. ## Verification - `go build ./...` ✅ - `go vet ./...` ✅ - `go test ./...` ✅
This eample shows queries in order