- `Server.cpp`: Make `checkForUsersNotInMainConfig` static (removes need for style-violating forward declaration)
- `LibSSHLogger.cpp`: Include header in `#else` branch to provide prototype for `initialize`
- `Lexer.cpp`: Include `clickhouse_lexer.h` in standalone build to provide prototypes for `extern "C"` functions
- `compressor.cpp`/`decompressor.cpp`: Make all file-local functions static
- `phdr_cache.cpp`: Add NOLINT for intentional reserved identifier `__lsan_ignore_object`
- BuzzHouse: Add `static` to `CONV_FN`/`CONV_FN_QUOTE` macros and individual functions
- Test/example files: Add `static` to helper functions across ~50 files
- Fix `double-promotion` in `compressor.cpp`, `gtest_compressionCodec.cpp`, `FuzzConfig.cpp`
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Fix clang-tidy `cppcoreguidelines-init-variables` and
`cppcoreguidelines-pro-type-member-init` warnings in compressor.cpp
and decompressor.cpp.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
E.g.
utils/self-extracting-executable/compressor.cpp:257:31: format specifies type 'ptrdiff_t' (aka 'long') but the argument has type 'off_t' (aka 'long long') [-Werror,-Wformat]
printf("Size: %td\n", info_in.st_size);
~~~ ^~~~~~~~~~~~~~~
%lld
Not sure though if it's a hard requirement to use only C.
Avoided usage of fmt::format() to keep link dependencies to a minimum.
Also not using C++20 std::format() as it's only available in Clang >=14.
