Commit Graph
506 Commits
Author SHA1 Message Date
Sergei Trifonov 026e073b0b minor improvement 2022-05-31 13:50:09 +02:00
Sergei Trifonov 7e95bf31b2 more verbose sanity checks 2022-05-31 09:26:26 +02:00
Azat KhuzhinandGitHub dc9ca3d70c Fix LOGICAL_ERROR in getMaxSourcePartsSizeForMerge during merges (#37413) 2022-05-26 14:14:58 +02:00
Vitaly BaranovandGitHub 497c70d786 Merge pull request #37269 from vitlibar/rework-access-control-notifications
Rework AccessControl's notifications.
2022-05-24 17:47:45 +02:00
Vitaly Baranov 58f4a86ec7 Rework notifications used in access management. 2022-05-21 10:15:39 +02:00
Robert SchulzeandGitHub c0d5705891 Merge pull request #37326 from ClickHouse/fix-marks-cache-size-cfg
Provide default value for mark_cache_size
2022-05-19 20:20:25 +02:00
Robert Schulze 8ca58cd5a5 Provide default value for mark_cache_size
I played around with my local config.xml file. The minimal working example is this:
<?xml version="1.0"?>
<clickhouse>
    <mark_cache_size>5368709120</mark_cache_size>
    <listen_host>localhost</listen_host>
    <tcp_port>9000</tcp_port>
    <users_config>users.xml</users_config>
    <logger><console>true</console></logger>
</clickhouse>

Not specifying mark_cache_size made the server not start up:
  2022.05.18 12:15:06.549078 [ 8728320 ] {} <Error> Application: Not found: mark_cache_size

Looking at ClickHouse's ca. 100 server configuration options +
sub-options, it seems that mark_cache_size is NOT special enough to
require explicit configuration but instead that the behavior was
unintended because no default value was provided.
2022-05-18 15:28:19 +02:00
Azat Khuzhin c8420c0dbe Remove duplication for server connections check
Signed-off-by: Azat Khuzhin <[email protected]>
2022-05-16 16:22:58 +03:00
Azat Khuzhin e503f1f22c Keep reloaded servers and currently active in one list
Signed-off-by: Azat Khuzhin <[email protected]>
2022-05-16 16:22:58 +03:00
Azat Khuzhin f15a5461be Fix server reload on port change (do not wait for current connections)
If you will execute 'SYSTEM RELOAD CONFIG' via, i.e., TCP protocol, then
reload on port change will endlessly wait for connection from which this
query had been issued, and you will see the following message in the
logs:

    2022.04.28 03:34:57.552513 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Debug> executeQuery: (from 127.0.0.1:11774) system reload config
    ...
    2022.04.28 03:34:57.710640 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Information> Application: Stopped listening for http://127.0.0.1:18123
    2022.04.28 03:34:57.798774 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Information> Application: Stopped listening for native protocol (tcp): 127.0.0.1:19000
    ...
    2022.04.28 03:34:57.901375 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Debug> Application: Server finished: http://127.0.0.1:18123
    2022.04.28 03:34:57.901455 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
    2022.04.28 03:34:58.001717 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
    2022.04.28 03:34:58.101881 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
    ...
    2022.04.28 03:35:01.707951 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000

But waiting for the current connection will never ends.

So instead of waiting directly from the query context (SYSTEM RELOAD
CONFIG) do this in background (actually not even in background, but
check on server reload and on exit).

v0: just don't wait for the servers
v2: fix use-after-free by removing dependency from server in handlers
v3: wait servers in background to avoid use-after-free of the context
Signed-off-by: Azat Khuzhin <[email protected]>
2022-05-16 16:22:58 +03:00
Robert Schulze e3cfec5b09 Merge remote-tracking branch 'origin/master' into clangtidies 2022-05-16 10:12:50 +02:00
Azat Khuzhin 5086d8de29 Reload listen_reuse_port/listen_backlog from config
Signed-off-by: Azat Khuzhin <[email protected]>
2022-05-12 17:05:39 +03:00
Sergei TrifonovandGitHub 9800d80a29 update sanity checks warning message text 2022-05-10 09:31:22 +02:00
mergify[bot]andGitHub 8ea87a3530 Merge branch 'master' into enable-memory-overcommit 2022-05-09 14:00:54 +00:00
Robert Schulze 1b81bb49b4 Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
Official docs:

  Some headers from C library were deprecated in C++ and are no longer
  welcome in C++ codebases. Some have no effect in C++. For more details
  refer to the C++ 14 Standard [depr.c.headers] section. This check
  replaces C standard library headers with their C++ alternatives and
  removes redundant ones.
2022-05-09 08:23:33 +02:00
Vitaly Baranov 69bec2f377 Users without assigned row policies can view rows now. 2022-05-07 14:50:24 +02:00
mergify[bot]andGitHub 1a92a34514 Merge branch 'master' into enable-memory-overcommit 2022-05-02 17:04:08 +00:00
Alexey Milovidov 47988db1a5 Add sanity check for log level. Fix style. 2022-04-30 13:19:25 +02:00
Alexey MilovidovandGitHub e0b2365945 Merge pull request #36472 from ClickHouse/sanity-checks-message-fix
more specific warning text about low disk space
2022-04-30 09:44:21 +03:00
Alexey MilovidovandGitHub 1ddb04b992 Merge pull request #36715 from amosbird/refactorbase
Reorganize source files so that base won't depend on Common
2022-04-30 09:40:58 +03:00
Nikolai KochetovandGitHub 5807ca47b0 Merge pull request #36425 from ClickHouse/pool-size-hot-reload
Allow to increase number of threads and tasks for background executors
2022-04-29 17:24:12 +02:00
Amos Bird 4a5e4274f0 base should not depend on Common 2022-04-29 10:26:35 +08:00
Maksim Kita 04429d85db Added user_defined_path config setting 2022-04-28 22:13:33 +02:00
mergify[bot]andGitHub 74aa65e36e Merge branch 'master' into sanity-checks-message-fix 2022-04-26 05:45:11 +00:00
mergify[bot]andGitHub 9c3605712b Merge branch 'master' into sanity-checks-message-fix 2022-04-25 17:37:55 +00:00
Azat Khuzhin 6df54611a9 Log which taskstats provider is in use
Signed-off-by: Azat Khuzhin <[email protected]>
v2: add missing __builtin_unreachable() for gcc built [1]
    [1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
(cherry picked from commit 2be022cb56)
2022-04-25 07:56:54 +03:00
Alexey MilovidovandGitHub 74bb6349c2 Revert "Strict taskstats parser" 2022-04-25 01:15:08 +03:00
Alexey MilovidovandGitHub 8af3159916 Merge pull request #36351 from azat/netlink-strict
Strict taskstats parser
2022-04-24 05:14:06 +03:00
Nikita Mikhaylov aaa7112405 Even better 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov e475849761 Style and Docs update 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov f95a63a7f0 Beautify 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov 36bdee0499 Deleted settings 2022-04-22 13:56:16 +00:00
Nikita Mikhaylov 31ccb9c1c3 Done 2022-04-22 13:56:16 +00:00
Alexey Milovidov f31cad52ab Preparation 2022-04-22 03:21:29 +02:00
Sergei Trifonov cda9160c2f fix build 2022-04-21 07:48:56 +02:00
Sergei Trifonov 69403840e2 add paths 2022-04-21 07:45:08 +02:00
Sergei Trifonov a2365c5c83 more specific warning text about low disk space 2022-04-21 07:32:34 +02:00
Azat Khuzhin 2be022cb56 Log which taskstats provider is in use
Signed-off-by: Azat Khuzhin <[email protected]>
v2: add missing __builtin_unreachable() for gcc built [1]
    [1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
2022-04-20 21:39:26 +03:00
Alexey Milovidov 58fc4e033a Remove trash 2022-04-15 22:54:08 +02:00
mergify[bot]andGitHub 078d8baf1d Merge branch 'master' into enable-memory-overcommit 2022-04-11 17:09:02 +00:00
Alexander Tokmakov 7f54e7b422 Merge branch 'master' into mvcc_prototype 2022-04-07 15:14:06 +02:00
mergify[bot]andGitHub bc882ded42 Merge branch 'master' into enable-memory-overcommit 2022-04-05 14:46:18 +00:00
Raúl Marín 8a05cf3927 DNS cache: Add option to drop elements after several consecutive failures 2022-04-05 13:00:27 +02:00
Dmitry Novik b4fed414e3 Enable memory overcommit 2022-04-04 14:28:05 +00:00
mergify[bot]andGitHub 3183b61c74 Merge branch 'master' into mvcc_prototype 2022-03-31 12:27:09 +00:00
alesapin ae3bcbb99b Fix logs space check 2022-03-31 00:22:36 +02:00
alesapin c6c0c91b39 Followup 2022-03-29 18:20:20 +02:00
Alexander Tokmakov 287d858fda Merge branch 'master' into mvcc_prototype 2022-03-29 16:24:12 +02:00
alesapin 4db85e2809 Fix build 2022-03-29 14:20:46 +02:00
alesapin ed2c461fe1 Merge branch 'master' into startup-sanity-checks 2022-03-29 14:09:20 +02:00