Commit Graph
25 Commits
Author SHA1 Message Date
Azat Khuzhin bedf208cbd Use fmt::runtime() for LOG_* for non constexpr
Here is oneliner:

    $ gg 'LOG_\(DEBUG\|TRACE\|INFO\|TEST\|WARNING\|ERROR\|FATAL\)([^,]*, [a-zA-Z]' -- :*.cpp :*.h | cut -d: -f1 | sort -u | xargs -r sed -E -i 's#(LOG_[A-Z]*)\(([^,]*), ([A-Za-z][^,)]*)#\1(\2, fmt::runtime(\3)#'

Note, that I tried to do this with coccinelle (tool for semantic
patchin), but it cannot parse C++:

    $ cat fmt.cocci
    @@
    expression log;
    expression var;
    @@

    -LOG_DEBUG(log, var)
    +LOG_DEBUG(log, fmt::runtime(var))

I've also tried to use some macros/templates magic to do this implicitly
in logger_useful.h, but I failed to do so, and apparently it is not
possible for now.

Signed-off-by: Azat Khuzhin <[email protected]>

v2: manual fixes
Signed-off-by: Azat Khuzhin <[email protected]>
2022-02-01 14:30:03 +03:00
alesapin b8c6481d4c Fix clickhouse server start when replicated access storage depend on keeper 2022-01-25 16:40:12 +03:00
Kevin Michel ffc1fca296 Start/stop servers when listen_host/*_port changes
This allows starting and stopping separately each protocol server
without restarting ClickHouse.

This also allows adding or removing `listen_host` entries, which
start and stops servers for all enabled ports.

When stopping a server, the listening socket is immediately closed
(and available for another server).

Protocols with persistent connections try to wait for any currently
running query to finish before closing the connection, but idle
connection are closed quickly (depending on how often the protocol
is polled).

An extra ProfileEvent is added, `MainConfigLoads`, it is
incremented every time the configuration is reloaded. This helps
when trying to assess whether the new configuration was applied.
2021-12-24 08:26:02 +01:00
Azat Khuzhin 57c027be0e Remove arcadia build support 2021-12-11 21:25:23 +03:00
alesapin 5f3eca4cd1 Merge branch 'master' into JackyWoo_add_4_letter_words_commands 2021-11-17 12:59:20 +03:00
Tomáš HromadaandGitHub 445b0ba7cc Expose all GlobalThreadPool config params (#31285) 2021-11-12 16:24:47 +03:00
JackyWoo a60663e33d add 4lw commands to keeper 2021-10-27 20:26:42 +08:00
alesapin 18cceedc00 Fix build and update for clickhouse-keeper 2021-10-19 17:29:49 +03:00
alesapin 6d24ca4c3a Review fixes 2021-10-18 12:13:24 +03:00
alesapin 90ff7f05fd Start keeper asynchronously if has connection to other nodes 2021-10-14 13:21:41 +03:00
Azat Khuzhin a5a2c5ef8a Move KEEPER_DEFAULT_PATH into separate header 2021-10-03 14:34:03 +03:00
Alexey Milovidov fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
alesapinandGitHub 47b995467e Merge pull request #28080 from ClickHouse/some_renames_in_keeper
Clickhouse-keeper: renames and comments
2021-08-26 10:16:21 +03:00
alesapin ea5fbbedec Fix clickhouse keeper jepsen tests 2021-08-25 19:15:56 +03:00
alesapin 95cf0634dc Clickhouse-keeper: renames and comments 2021-08-24 15:30:31 +03:00
Alexander Tokmakov 31d75c9c38 fix split build 2021-08-18 15:15:31 +03:00
Alexander Tokmakov 4d71f65082 fix build 2021-08-17 16:24:14 +03:00
Alexander Tokmakov 9e9fa043ca minor improvements, add test 2021-08-16 21:30:53 +03:00
Maksim KitaandMaksim Kita 67e9b85951 Merge ext into common 2021-06-16 23:28:41 +03:00
Azat Khuzhin c343f85b64 Do not built clickhouse-keeper w/o NuRaft
Otherwise it will fail because of unused argument and unreachable code.
2021-05-23 08:37:56 +03:00
alesapin 31181095e7 Review fixes 2021-05-18 17:08:56 +03:00
alesapin c9bef9d332 Better comments 2021-05-17 12:38:44 +03:00
alesapin 43ee9f0a3a Check for directory owner 2021-05-12 17:05:44 +03:00
alesapin 41eadf9127 Something working 2021-05-12 16:04:34 +03:00
alesapin ffb4e1af8f Some copy-paste 2021-05-12 13:39:07 +03:00