Commit Graph
7 Commits
Author SHA1 Message Date
Antonio AndelicandClaude Opus 4.6 793589c920 Fix style check and seed collision in MultiRequestGenerator
Add `// Ok` comments to `catch (...)` blocks in `Runner.cpp` that handle
exceptions via `handle_request_exception` (which logs and counts errors)
but were flagged by the `catch_all` style check.

Fix seed collision in `MultiRequestGenerator::setSeedImpl`: the inner
`RequestGetter::setSeed` distributed sub-seeds as `seed + i + 1`, which
collided with siblings assigned by the outer `RequestGetter` using the
same scheme. Use a large prime offset (500009) to separate the inner
seed namespace.

https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=98906&sha=latest&name_0=PR

Co-Authored-By: Claude Opus 4.6 <[email protected]>
2026-03-08 22:27:24 +01:00
Antonio AndelicandClaude Opus 4.6 3f7d286d68 Seed all RNGs from generator.seed for full reproducibility in keeper-bench
Previously only `CreateRequestGenerator::rng` was seeded from the
configured seed. Four other RNGs — in `NumberGetter::getNumber`,
`StringGetter::getString` (via `generateRandomString`),
`PathGetter::getPath`, and `RequestGetter::getRequestGenerator` —
used independent `thread_local pcg64(randomSeed())` instances,
making runs non-deterministic even with a fixed seed.

Replace all `thread_local` RNGs with per-instance `mutable pcg64`
members and propagate the seed through the full generator hierarchy:
`Generator` → `RequestGetter` → each `RequestGenerator` subclass →
their `PathGetter`, `StringGetter`, and `NumberGetter` members.
Each component uses a distinct sub-seed offset to avoid correlation.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
2026-03-06 13:34:11 +01:00
Antonio AndelicandClaude Opus 4.6 17344a6d17 Improve keeper-bench with pipelining, warmup, per-op stats, and reproducible seeds
- Add `pipeline_depth` and `queue_depth` settings to allow asynchronous
  in-flight requests per consumer thread, hiding round-trip latency
- Add `warmup_seconds` to discard early stats while caches warm up
- Add `generator.seed` for reproducible workloads
- Track per-operation-type stats (Create, Remove, Get, Set, List, Multi)
  in both stderr reports and JSON output
- Add `on_failure_callbacks` to clean up pending paths on failed creates
- Replace `paths_created` set with O(1) swap-and-pop vector+index structure
  for random path removal
- Fix `static` → `thread_local` for RNG instances to avoid data races
- Fix `continue_on_errors` → `continue_on_error` (match actual config key)
- Validate `remove_factor` range, zero weights, and empty path getters
- Add retry limit for unique path name generation
- Simplify `removeRecursive` and deduplicate default ACL construction
- Document all new settings in README

Co-Authored-By: Claude Opus 4.6 <[email protected]>
2026-03-06 10:32:03 +01:00
Antonio Andelic f9f786eb11 Fix remove_factor in keeper-bench 2026-02-17 15:53:46 +01:00
Nikolay Degterinsky baf8ba119a Fix tidy 2026-01-26 11:59:54 +00:00
Raúl Marín d6ac63c8d2 Style: Forbid the use of quotes for includes (partial) 2025-06-24 13:20:10 +02:00
Nikita Mikhaylov dc7bc42223 Moved some of utils to programs 2024-12-09 21:35:31 +00:00