mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
112 lines
3.6 KiB
Python
112 lines
3.6 KiB
Python
import re
|
|
|
|
|
|
class StackTraceReader(object):
|
|
@staticmethod
|
|
def get_trace_and_errors(stderr, max_lines=1000):
|
|
"""
|
|
Parse stderr to extract errors and stack traces.
|
|
Returns: (errors, trace, unknown_lines)
|
|
"""
|
|
lines = stderr.split("\n")
|
|
if len(lines) > max_lines:
|
|
print(f"Warning: stderr has more than {max_lines} lines. Truncating.")
|
|
lines = lines[-max_lines:]
|
|
|
|
lines = [line.strip() for line in lines if line.strip()]
|
|
|
|
stack_trace_pattern_if_err = re.compile(r"^\d+(?:\.\d+)*\.\s*")
|
|
stack_trace_pattern_in_log = re.compile(
|
|
r"<Fatal> BaseDaemon: \d+(?:\.\d+)*\.\s*"
|
|
)
|
|
|
|
errors_before_trace = []
|
|
errors_after_trace = []
|
|
trace = ""
|
|
unknown_lines = []
|
|
|
|
i = 0
|
|
while i < len(lines):
|
|
line = lines[i]
|
|
|
|
# Check for error patterns
|
|
if any(
|
|
keyword in line
|
|
for keyword in (
|
|
"Logical error:",
|
|
"Changed settings:",
|
|
"Received signal",
|
|
"Connection refused",
|
|
)
|
|
):
|
|
error_lines = [line]
|
|
i += 1
|
|
while i < len(lines):
|
|
if lines[i].startswith("["):
|
|
break
|
|
error_lines.append(lines[i])
|
|
i += 1
|
|
if trace:
|
|
errors_after_trace.append(error_lines)
|
|
else:
|
|
errors_before_trace.append(error_lines)
|
|
continue
|
|
|
|
# Check for stack trace pattern
|
|
if stack_trace_pattern_if_err.search(line):
|
|
while i < len(lines) and stack_trace_pattern_if_err.search(lines[i]):
|
|
match = stack_trace_pattern_if_err.search(lines[i])
|
|
trace_line = lines[i][match.end() :]
|
|
trace_line = trace_line.split("ClickHouse/")[-1]
|
|
trace += trace_line.strip() + "\n"
|
|
i += 1
|
|
continue
|
|
|
|
# Skip known log patterns
|
|
if (
|
|
stack_trace_pattern_in_log.search(line)
|
|
or any(
|
|
keyword in line
|
|
for keyword in (
|
|
"BaseDaemon: ###############",
|
|
": Stack trace",
|
|
"Integrity check of the executable skipped",
|
|
)
|
|
)
|
|
or line.rstrip().endswith("BaseDaemon:")
|
|
):
|
|
i += 1
|
|
continue
|
|
|
|
# Collect unknown lines
|
|
unknown_lines.append(line)
|
|
i += 1
|
|
|
|
for error in errors_before_trace + errors_after_trace:
|
|
for idx, line in enumerate(error):
|
|
if "<Fatal>" in line:
|
|
error[idx] = line.split("<Fatal>", 1)[1].strip()
|
|
|
|
for idx, error in enumerate(errors_before_trace):
|
|
errors_before_trace[idx] = "\n".join(error)
|
|
for idx, error in enumerate(errors_after_trace):
|
|
errors_after_trace[idx] = "\n".join(error)
|
|
return errors_before_trace, trace, errors_after_trace, unknown_lines
|
|
|
|
|
|
if __name__ == "__main__":
|
|
# test
|
|
test_file = "/tmp/stack_trace.txt"
|
|
with open(test_file, "r") as f:
|
|
stderr = f.read()
|
|
errors_before_trace, trace, errors_after_trace, unknown_lines = (
|
|
StackTraceReader.get_trace_and_errors(stderr)
|
|
)
|
|
print(errors_before_trace)
|
|
print("----")
|
|
print(trace)
|
|
print("----")
|
|
print(errors_after_trace)
|
|
print("----")
|
|
print(unknown_lines)
|