mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
126 lines
5.7 KiB
Python
126 lines
5.7 KiB
Python
import pytest
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
|
|
# This test validates that background operations can use a dedicated 'background' user profile when it's configured.
|
|
# The feature and behavior is described at #93905
|
|
# We leverage 'sleepEachRow' for mutate queries to trigger operation timeout:
|
|
# - in cases where 'default' is used - mutations are expected to fail
|
|
# - in cases where the new 'background' profile is used - mutations will succeed, as the timeout will be increased
|
|
|
|
# We spin up a node with unique configuration for each scnenario to be checked
|
|
# 1. [EXPECTED FAILURE] Default configuration only, operation timeout is 3s and implicitly applied via 'default' profile
|
|
node1 = cluster.add_instance("node1")
|
|
# 2. [EXPECTED SUCCESS] 'background' profile sets timeout to 5s and mutations are using it
|
|
node2 = cluster.add_instance("node2", user_configs=['configs/background_profile.xml'])
|
|
# 3. [EXPECTED FAILURE] Default configuration only, operation timeout is set to 0.3s and we check that mutation are using it via 'default' profile
|
|
node3 = cluster.add_instance("node3", user_configs=['configs/tightened_default_profile.xml'])
|
|
# 4. [EXPECTED SUCCESS] 'background' profile sets timeout to 0.5s and mutations are using it
|
|
node4 = cluster.add_instance("node4", user_configs=["configs/tightened_background_profile.xml"])
|
|
# 5. [EXPECTED SUCCESS] 'custom' profile is set to be used by background operations, it sets timeout to 0.5s and mutations are using it
|
|
node5 = cluster.add_instance(
|
|
"node5",
|
|
main_configs=["configs/custom_server_config.xml"],
|
|
user_configs=["configs/tightened_custom_profile.xml"]
|
|
)
|
|
# 6. [EXPECTED FAILURE] with default, then created new 'background' profile, and [EXPECTED SUCCESS] after server restart
|
|
node6 = cluster.add_instance("node6", stay_alive=True)
|
|
# 7. [EXPECTED FAILURE] when trying to ALTER a pre-configured profile on fly via SQL
|
|
node7 = cluster.add_instance("node7", user_configs=["configs/empty_background_profile.xml"])
|
|
|
|
|
|
@pytest.fixture(scope="module", autouse=True)
|
|
def started_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
def get_table_name(instance):
|
|
table_name = "test_table"
|
|
return f"{table_name}_{instance.name}"
|
|
|
|
|
|
def prepare_data(instance):
|
|
table_name = get_table_name(instance)
|
|
|
|
instance.query(f"DROP TABLE IF EXISTS {table_name} SYNC")
|
|
|
|
instance.query(f"""
|
|
CREATE TABLE IF NOT EXISTS {table_name} (
|
|
v1 UInt16
|
|
) ENGINE = MergeTree()
|
|
""")
|
|
|
|
instance.query(f"INSERT INTO {table_name} VALUES (1), (2), (3), (4)")
|
|
|
|
def assert_mutate_blocking(instance, sleep_sec_per_row, expected_failure=False):
|
|
query = f"""
|
|
ALTER TABLE {get_table_name(instance)} UPDATE v1 = (v1 + 1)
|
|
WHERE sleepEachRow({sleep_sec_per_row})==0
|
|
SETTINGS mutations_sync=1
|
|
"""
|
|
|
|
if expected_failure:
|
|
instance.query_and_get_error(query)
|
|
else:
|
|
instance.query(query)
|
|
|
|
|
|
def test_excpected_failure_with_default_profile(started_cluster):
|
|
# this case is kinda redundant, it's destined to fire if the default for <function_sleep_max_microseconds_per_block> ever changes
|
|
# and we'll have to adjust timeout expectations for this test
|
|
prepare_data(instance=node1)
|
|
assert_mutate_blocking(instance=node1, sleep_sec_per_row=1, expected_failure=True)
|
|
print("Check 1: background operation failed as expected with all defaults")
|
|
|
|
def test_background_profile_configured_with_all_defaults(started_cluster):
|
|
prepare_data(instance=node2)
|
|
assert_mutate_blocking(instance=node2, sleep_sec_per_row=1)
|
|
print("Check 2: background operation succeeds with 'background' profile minimally configured")
|
|
|
|
def test_excpected_failure_with_tightened_default_profile(started_cluster):
|
|
prepare_data(instance=node3)
|
|
assert_mutate_blocking(instance=node3, sleep_sec_per_row=0.1, expected_failure=True)
|
|
print("Check 3: background operation failed as expected with a tighter query timeout")
|
|
|
|
def test_background_profile_configured(started_cluster):
|
|
prepare_data(instance=node4)
|
|
assert_mutate_blocking(instance=node4, sleep_sec_per_row=0.1)
|
|
print("Check 4: background operation succeeds with 'background' profile configured")
|
|
|
|
def test_custom_background_profile_configured(started_cluster):
|
|
prepare_data(instance=node5)
|
|
assert_mutate_blocking(instance=node5, sleep_sec_per_row=0.1)
|
|
print("Check 5: background operation succeeds with a custom background profile configured")
|
|
|
|
def test_switching_to_background_profile_in_flight(started_cluster):
|
|
prepare_data(instance=node6)
|
|
assert_mutate_blocking(instance=node6, sleep_sec_per_row=1, expected_failure=True)
|
|
|
|
# Attempt to modify 'background' profile without having it created first should fail
|
|
node6.query_and_get_error("ALTER SETTINGS PROFILE background SETTINGS function_sleep_max_microseconds_per_block=5000000")
|
|
# Now it'll work
|
|
node6.query("CREATE SETTINGS PROFILE background")
|
|
node6.query("ALTER SETTINGS PROFILE background SETTINGS function_sleep_max_microseconds_per_block=5000000")
|
|
# But the newly created profile won't work without server restart in such case
|
|
assert_mutate_blocking(instance=node6, sleep_sec_per_row=1, expected_failure=True)
|
|
|
|
# Clean up failed mutations before restart
|
|
node6.query(f"KILL MUTATION WHERE table = '{get_table_name(node6)}'")
|
|
|
|
node6.restart_clickhouse()
|
|
# And finally it works
|
|
assert_mutate_blocking(instance=node6, sleep_sec_per_row=1)
|
|
print("Check 6: background created in flight")
|
|
|
|
def test_changing_profile_in_flight(started_cluster):
|
|
prepare_data(instance=node7)
|
|
assert_mutate_blocking(instance=node7, sleep_sec_per_row=1, expected_failure=True)
|
|
|
|
node7.query_and_get_error("ALTER SETTINGS PROFILE background SETTINGS function_sleep_max_microseconds_per_block=5000000")
|
|
|
|
print("Check 7: background can't be created in config and modified via SQL")
|