mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Sema Checherinda
d452c036cf
The runtime reload guard validated after `config().replace`, so a rejected `SYSTEM RELOAD CONFIG` had already swapped in the new configuration: `system.server_settings` would then report an unsupported legacy value even though the reload failed, and `ConfigReloader` has no rollback hook. Validate the incoming configuration before `config().replace`, so a rejected reload leaves the previous valid config untouched. The integration test now asserts `system.server_settings` still reports `new_unified_hash` after the rejected reload.
76 lines
3.0 KiB
Python
76 lines
3.0 KiB
Python
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
node = cluster.add_instance(
|
|
"node",
|
|
main_configs=["configs/dedup_version.xml"],
|
|
stay_alive=True,
|
|
)
|
|
|
|
CONFIG_PATH = "/etc/clickhouse-server/config.d/dedup_version.xml"
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def start_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_supported_version_starts(start_cluster):
|
|
# The only supported value, new_unified_hash, starts normally.
|
|
assert node.get_process_pid("clickhouse") is not None
|
|
assert node.query("SELECT 1") == "1\n"
|
|
|
|
|
|
def test_unsupported_version_aborts_startup(start_cluster):
|
|
# This build writes only the unified deduplication hash, so any other insert_deduplication_version
|
|
# must fail-close at startup with a migration message rather than silently degrading deduplication.
|
|
node.stop_clickhouse()
|
|
node.replace_in_config(CONFIG_PATH, "new_unified_hash", "compatible_double_hashes")
|
|
node.start_clickhouse(start_wait_sec=120, expected_to_fail=True)
|
|
|
|
assert node.get_process_pid("clickhouse") is None
|
|
assert node.contains_in_log(
|
|
"supports only the unified insert deduplication hash"
|
|
)
|
|
|
|
# Restore the supported value so the server (and module teardown) is healthy again.
|
|
node.replace_in_config(CONFIG_PATH, "compatible_double_hashes", "new_unified_hash")
|
|
node.start_clickhouse()
|
|
assert node.get_process_pid("clickhouse") is not None
|
|
|
|
|
|
def test_unsupported_version_rejected_on_reload(start_cluster):
|
|
# A legacy value arriving through a runtime reload must be rejected too: the guard runs in the
|
|
# config reloader, so SYSTEM RELOAD CONFIG fails and the reload is dropped, leaving the server up on
|
|
# the previous valid value rather than silently degrading to unified-only while reporting a legacy
|
|
# value. This covers the reloader path (Server.cpp), not just the initial startup load.
|
|
assert node.get_process_pid("clickhouse") is not None
|
|
|
|
node.replace_in_config(CONFIG_PATH, "new_unified_hash", "compatible_double_hashes")
|
|
error = node.query_and_get_error("SYSTEM RELOAD CONFIG")
|
|
assert "supports only the unified insert deduplication hash" in error
|
|
|
|
# Fail closed: rejecting the reload leaves the server running and healthy.
|
|
assert node.get_process_pid("clickhouse") is not None
|
|
assert node.query("SELECT 1") == "1\n"
|
|
|
|
# The rejected reload must not have mutated the live config: the guard validates the incoming
|
|
# config before config().replace, so system.server_settings must still report the previous valid
|
|
# value rather than the unsupported one from the dropped reload.
|
|
assert (
|
|
node.query(
|
|
"SELECT value FROM system.server_settings WHERE name = 'insert_deduplication_version'"
|
|
).strip()
|
|
== "new_unified_hash"
|
|
)
|
|
|
|
# Restore the supported value and confirm a valid reload still succeeds.
|
|
node.replace_in_config(CONFIG_PATH, "compatible_double_hashes", "new_unified_hash")
|
|
node.query("SYSTEM RELOAD CONFIG")
|