mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Michael KolupaevandClaude Opus 4.8
8c5f908b80
Resolve conflicts from the Keeper TTL garbage-collector feature (#100397, https://github.com/ClickHouse/ClickHouse/pull/100397), the only PR that conflicted with the Keeper RocksDB storage removal. Resolution: - Keep this branch's de-templated, RocksDB-free `KeeperStorage` / `KeeperStateMachine` while preserving the new TTL feature: `ttl` parameter on `createNode`, `ttl_paths` / `committed_ttl_nodes` bookkeeping in `removeNode`, `collectExpiredTTLPaths`, `containsTTLPath`, and `getExpiredTTLPathsForGarbageCollector` (now concrete methods, the `TSA_NO_THREAD_SAFETY_ANALYSIS` annotations retained). - `processWatches` for `Remove` now iterates `deltas` (no longer ignored). - Keep `RocksDBContainer.h` deleted (modify/delete conflict). - Port the new TTL unit tests in `gtest_coordination_storage.cpp` and `gtest_coordination_snapshot.cpp` to the single memory-storage fixture: drop the `setRocksDBDirectory` / `ChangelogDirTest rocks` setup and the `KeeperSnapshotManager<Storage>` / `KeeperStorageSnapshot<Storage>` template arguments, matching this branch's conventions. All touched Coordination translation units pass `-fsyntax-only` against the merged headers. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>