Files
datastore/base/poco/Foundation/include/Poco/BufferedBidirectionalStreamBuf.h
Sema ChecherindaandClaude Opus 4.6 2d6a02750a fix(Poco): handle short writes in BufferedBidirectionalStreamBuf and HTTPChunkedStream
BufferedBidirectionalStreamBuf::flushBuffer has the same short write bug
as BufferedStreamBuf -- apply the same loop fix.

HTTPChunkedStreamBuf::writeToDevice ignored the return value of
_session.write when sending the chunk frame, always returning length
as if everything was written. A short write silently lost data.
Same issue in close() for the final "0\r\n\r\n" chunk.

Loop _session.write in both places until the full buffer is sent.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
2026-04-16 17:19:02 +02:00

175 lines
4.8 KiB
C++

//
// BufferedBidirectionalStreamBuf.h
//
// Library: Foundation
// Package: Streams
// Module: StreamBuf
//
// Definition of template BasicBufferedBidirectionalStreamBuf and class BufferedBidirectionalStreamBuf.
//
// Copyright (c) 2005-2006, Applied Informatics Software Engineering GmbH.
// and Contributors.
//
// SPDX-License-Identifier: BSL-1.0
//
#ifndef Foundation_BufferedBidirectionalStreamBuf_INCLUDED
#define Foundation_BufferedBidirectionalStreamBuf_INCLUDED
#include <ios>
#include <iosfwd>
#include <streambuf>
#include "Poco/BufferAllocator.h"
#include "Poco/Foundation.h"
#include "Poco/StreamUtil.h"
namespace Poco
{
template <typename ch, typename tr, typename ba = BufferAllocator<ch>>
class BasicBufferedBidirectionalStreamBuf : public std::basic_streambuf<ch, tr>
/// This is an implementation of a buffered bidirectional
/// streambuf that greatly simplifies the implementation of
/// custom streambufs of various kinds.
/// Derived classes only have to override the methods
/// readFromDevice() or writeToDevice().
///
/// In contrast to BasicBufferedStreambuf, this class supports
/// simultaneous read and write access, so in addition to
/// istream and ostream this streambuf can also be used
/// for implementing an iostream.
{
protected:
typedef std::basic_streambuf<ch, tr> Base;
typedef std::basic_ios<ch, tr> IOS;
typedef ch char_type;
typedef tr char_traits;
typedef ba Allocator;
typedef typename Base::int_type int_type;
typedef typename Base::pos_type pos_type;
typedef typename Base::off_type off_type;
typedef typename IOS::openmode openmode;
public:
BasicBufferedBidirectionalStreamBuf(std::streamsize bufferSize, openmode mode)
: _bufsize(bufferSize), _pReadBuffer(Allocator::allocate(_bufsize)), _pWriteBuffer(Allocator::allocate(_bufsize)), _mode(mode)
{
resetBuffers();
}
~BasicBufferedBidirectionalStreamBuf()
{
Allocator::deallocate(_pReadBuffer, _bufsize);
Allocator::deallocate(_pWriteBuffer, _bufsize);
}
virtual int_type overflow(int_type c)
{
if (!(_mode & IOS::out))
return char_traits::eof();
if (flushBuffer() == std::streamsize(-1))
return char_traits::eof();
if (c != char_traits::eof())
{
*this->pptr() = char_traits::to_char_type(c);
this->pbump(1);
}
return c;
}
virtual int_type underflow()
{
if (!(_mode & IOS::in))
return char_traits::eof();
if (this->gptr() && (this->gptr() < this->egptr()))
return char_traits::to_int_type(*this->gptr());
int putback = int(this->gptr() - this->eback());
if (putback > 4)
putback = 4;
char_traits::move(_pReadBuffer + (4 - putback), this->gptr() - putback, putback);
int n = readFromDevice(_pReadBuffer + 4, _bufsize - 4);
if (n <= 0)
return char_traits::eof();
this->setg(_pReadBuffer + (4 - putback), _pReadBuffer + 4, _pReadBuffer + 4 + n);
// return next character
return char_traits::to_int_type(*this->gptr());
}
virtual int sync()
{
if (this->pptr() && this->pptr() > this->pbase())
{
if (flushBuffer() == -1)
return -1;
}
return 0;
}
protected:
void setMode(openmode mode) { _mode = mode; }
openmode getMode() const { return _mode; }
void resetBuffers()
{
this->setg(_pReadBuffer + 4, _pReadBuffer + 4, _pReadBuffer + 4);
this->setp(_pWriteBuffer, _pWriteBuffer + _bufsize);
}
private:
virtual int readFromDevice(char_type * /*buffer*/, std::streamsize /*length*/) { return 0; }
virtual int writeToDevice(const char_type * /*buffer*/, std::streamsize /*length*/) { return 0; }
int flushBuffer()
{
int n = int(this->pptr() - this->pbase());
int offset = 0;
while (offset < n)
{
int written = writeToDevice(this->pbase() + offset, n - offset);
if (written <= 0)
return -1;
offset += written;
}
this->pbump(-n);
return n;
}
std::streamsize _bufsize;
char_type * _pReadBuffer;
char_type * _pWriteBuffer;
openmode _mode;
BasicBufferedBidirectionalStreamBuf(const BasicBufferedBidirectionalStreamBuf &);
BasicBufferedBidirectionalStreamBuf & operator=(const BasicBufferedBidirectionalStreamBuf &);
};
//
// We provide an instantiation for char.
//
// Visual C++ needs a workaround - explicitly importing the template
// instantiation - to avoid duplicate symbols due to multiple
// instantiations in different libraries.
//
typedef BasicBufferedBidirectionalStreamBuf<char, std::char_traits<char>> BufferedBidirectionalStreamBuf;
} // namespace Poco
#endif // Foundation_BufferedBidirectionalStreamBuf_INCLUDED