mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
`HTTPConnectionPool::isStale` decided whether a pooled keep-alive connection was still usable with `poll(SELECT_READ, 0)`: readable meant stale, on the assumption that an idle keep-alive connection has no data pending. On a plain socket that holds, but on an HTTPS connection it produces a false positive. `poll` reflects the raw TCP socket, so an unread TLS post-handshake record (a session ticket or `KeyUpdate`) makes an entirely live secure connection look readable, i.e. stale, and the pool discards it and reconnects - at the cost of a fresh TLS handshake - on nearly every borrow. This ports the shared, TLS-aware helper `isSocketPeerClosed` (added in `src/IO`) from the distributed cache fix and switches `HTTPConnectionPool::isStale` to it: - for a plain socket, a single non-blocking, non-destructive `recv(..., MSG_PEEK | MSG_DONTWAIT)`: `0` means the peer sent a FIN (closed); `> 0` means bytes are on the wire (alive); `EAGAIN` / `EWOULDBLOCK` means a healthy idle connection; any other error (e.g. `ECONNRESET`) is treated as closed/broken; - for a TLS (`SecureStreamSocket`) socket, an `SSL_peek` on a temporarily non-blocking socket. A raw `MSG_PEEK` cannot tell TLS records apart - an unread `close_notify` looks the same as unread application data or a session ticket, and in TLS 1.3 the record content type is encrypted. `SSL_peek` decrypts just enough to distinguish real application data and harmless post-handshake messages (a session ticket or `KeyUpdate`), treated as alive, from a `close_notify` (`SSL_ERROR_ZERO_RETURN`) or a broken session, treated as closed, without consuming application data. A small `ssl` accessor is added to Poco's `SecureSocketImpl` / `SecureStreamSocketImpl` to reach the underlying OpenSSL `SSL` object. `gtest_socket_peer_closed` covers both paths, including a `socketpair`-backed TLS connection: an unread session ticket and pending application data read as alive; a `close_notify` and an abrupt close read as closed. The `close_notify` case also asserts that a raw `MSG_PEEK` misfires there, which is exactly why the TLS-aware path is needed. This is the public-repo counterpart, and the follow-up promised in, the distributed cache fix https://github.com/ClickHouse/clickhouse-private/pull/64217 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
328 lines
11 KiB
C++
328 lines
11 KiB
C++
//
|
|
// SecureSocketImpl.h
|
|
//
|
|
// Library: NetSSL_OpenSSL
|
|
// Package: SSLSockets
|
|
// Module: SecureSocketImpl
|
|
//
|
|
// Definition of the SecureSocketImpl class.
|
|
//
|
|
// Copyright (c) 2006-2010, Applied Informatics Software Engineering GmbH.
|
|
// and Contributors.
|
|
//
|
|
// SPDX-License-Identifier: BSL-1.0
|
|
//
|
|
|
|
|
|
#ifndef NetSSL_SecureSocketImpl_INCLUDED
|
|
#define NetSSL_SecureSocketImpl_INCLUDED
|
|
|
|
|
|
#include <openssl/bio.h>
|
|
#include <openssl/ssl.h>
|
|
|
|
#include "Poco/Net/Context.h"
|
|
#include "Poco/Net/NetSSL.h"
|
|
#include "Poco/Net/Session.h"
|
|
#include "Poco/Net/SocketImpl.h"
|
|
|
|
#include <memory>
|
|
#include <mutex>
|
|
|
|
namespace Poco
|
|
{
|
|
namespace Net
|
|
{
|
|
|
|
|
|
class HostEntry;
|
|
|
|
|
|
class NetSSL_API SecureSocketImpl
|
|
/// The SocketImpl for SecureStreamSocket.
|
|
{
|
|
public:
|
|
SecureSocketImpl(Poco::AutoPtr<SocketImpl> pSocketImpl, Context::Ptr pContext);
|
|
/// Creates the SecureSocketImpl using an already
|
|
/// connected stream socket.
|
|
|
|
virtual ~SecureSocketImpl();
|
|
/// Destroys the SecureSocketImpl.
|
|
|
|
SocketImpl * acceptConnection(SocketAddress & clientAddr);
|
|
/// Get the next completed connection from the
|
|
/// socket's completed connection queue.
|
|
///
|
|
/// If the queue is empty, waits until a connection
|
|
/// request completes.
|
|
///
|
|
/// Returns a new SSL socket for the connection
|
|
/// with the client.
|
|
///
|
|
/// The client socket's address is returned in clientAddr.
|
|
|
|
void connect(const SocketAddress & address, bool performHandshake);
|
|
/// Initializes the socket and establishes a secure connection to
|
|
/// the TCP server at the given address.
|
|
///
|
|
/// If performHandshake is true, the SSL handshake is performed immediately
|
|
/// after establishing the connection. Otherwise, the handshake is performed
|
|
/// the first time sendBytes(), receiveBytes() or completeHandshake() is called.
|
|
|
|
void connect(const SocketAddress & address, const Poco::Timespan & timeout, bool performHandshake);
|
|
/// Initializes the socket, sets the socket timeout and
|
|
/// establishes a secure connection to the TCP server at the given address.
|
|
///
|
|
/// If performHandshake is true, the SSL handshake is performed immediately
|
|
/// after establishing the connection. Otherwise, the handshake is performed
|
|
/// the first time sendBytes(), receiveBytes() or completeHandshake() is called.
|
|
|
|
void connectNB(const SocketAddress & address);
|
|
/// Initializes the socket and establishes a secure connection to
|
|
/// the TCP server at the given address. Prior to opening the
|
|
/// connection the socket is set to nonblocking mode.
|
|
|
|
void bind(const SocketAddress & address, bool reuseAddress = false, bool reusePort = false);
|
|
/// Bind a local address to the socket.
|
|
///
|
|
/// This is usually only done when establishing a server
|
|
/// socket. SSL clients should not bind a socket to a
|
|
/// specific address.
|
|
///
|
|
/// If reuseAddress is true, sets the SO_REUSEADDR
|
|
/// socket option.
|
|
|
|
void listen(int backlog = 64);
|
|
/// Puts the socket into listening state.
|
|
///
|
|
/// The socket becomes a passive socket that
|
|
/// can accept incoming connection requests.
|
|
///
|
|
/// The backlog argument specifies the maximum
|
|
/// number of connections that can be queued
|
|
/// for this socket.
|
|
|
|
void shutdown();
|
|
/// Shuts down the connection by attempting
|
|
/// an orderly SSL shutdown, then actually
|
|
/// shutting down the TCP connection.
|
|
|
|
void close();
|
|
/// Close the socket.
|
|
|
|
void abort();
|
|
/// Aborts the connection by closing the
|
|
/// underlying TCP connection. No orderly SSL shutdown
|
|
/// is performed.
|
|
|
|
int sendBytes(const void * buffer, int length, int flags = 0);
|
|
/// Sends the contents of the given buffer through
|
|
/// the socket. Any specified flags are ignored.
|
|
///
|
|
/// Returns the number of bytes sent, which may be
|
|
/// less than the number of bytes specified.
|
|
|
|
int receiveBytes(void * buffer, int length, int flags = 0);
|
|
/// Receives data from the socket and stores it
|
|
/// in buffer. Up to length bytes are received.
|
|
///
|
|
/// Returns the number of bytes received.
|
|
|
|
int available() const;
|
|
/// Returns the number of bytes available from the
|
|
/// SSL buffer for immediate reading.
|
|
|
|
int completeHandshake();
|
|
/// Completes the SSL handshake.
|
|
///
|
|
/// If the SSL connection was the result of an accept(),
|
|
/// the server-side handshake is completed, otherwise
|
|
/// a client-side handshake is performed.
|
|
|
|
poco_socket_t sockfd();
|
|
/// Returns the underlying socket descriptor.
|
|
|
|
SSL * ssl() const;
|
|
/// Returns the underlying OpenSSL SSL object, or null if the SSL handshake
|
|
/// has not been performed yet.
|
|
///
|
|
/// The object is normally guarded by the socket's mutex; a caller that uses it
|
|
/// directly must ensure the socket is not accessed concurrently.
|
|
|
|
X509 * peerCertificate() const;
|
|
/// Returns the peer's certificate.
|
|
|
|
Context::Ptr context() const;
|
|
/// Returns the SSL context used for this socket.
|
|
|
|
void verifyPeerCertificate();
|
|
/// Performs post-connect (or post-accept) peer certificate validation,
|
|
/// using the peer host name set with setPeerHostName(), or the peer's
|
|
/// IP address string if no peer host name has been set.
|
|
|
|
void verifyPeerCertificate(const std::string & hostName);
|
|
/// Performs post-connect (or post-accept) peer certificate validation
|
|
/// using the given peer host name.
|
|
|
|
void setPeerHostName(const std::string & hostName);
|
|
/// Sets the peer host name for certificate validation purposes.
|
|
|
|
const std::string & getPeerHostName() const;
|
|
/// Returns the peer host name.
|
|
|
|
Session::Ptr currentSession();
|
|
/// Returns the SSL session of the current connection,
|
|
/// for reuse in a future connection (if session caching
|
|
/// is enabled).
|
|
///
|
|
/// If no connection is established, returns null.
|
|
|
|
void useSession(Session::Ptr pSession);
|
|
/// Sets the SSL session to use for the next
|
|
/// connection. Setting a previously saved Session
|
|
/// object is necessary to enable session caching.
|
|
///
|
|
/// To remove the currently set session, a null pointer
|
|
/// can be given.
|
|
///
|
|
/// Must be called before connect() to be effective.
|
|
|
|
bool sessionWasReused();
|
|
/// Returns true iff a reused session was negotiated during
|
|
/// the handshake.
|
|
|
|
virtual void setBlocking(bool flag);
|
|
/// Sets the socket in blocking mode if flag is true,
|
|
/// disables blocking mode if flag is false.
|
|
|
|
virtual bool getBlocking() const;
|
|
/// Returns the blocking mode of the socket.
|
|
/// This method will only work if the blocking modes of
|
|
/// the socket are changed via the setBlocking method!
|
|
|
|
|
|
void setBioMethod(const BIO_METHOD * method);
|
|
/// Optionally inject a custom BIO_METHOD for the SSL transport BIO.
|
|
/// Has no effect once the SSL handshake has been initiated (i.e. once
|
|
/// any I/O has happened). If never called, `BIO_s_socket()` is used.
|
|
|
|
struct RecursiveMutex
|
|
{
|
|
virtual ~RecursiveMutex() = default;
|
|
virtual void lock() = 0;
|
|
virtual void unlock() = 0;
|
|
};
|
|
|
|
void setMutex(std::unique_ptr<RecursiveMutex> mutex);
|
|
/// Replace the lock guarding SSL operations.
|
|
|
|
|
|
protected:
|
|
void acceptSSL();
|
|
/// Assume per-object mutex is locked.
|
|
/// Performs a server-side SSL handshake and certificate verification.
|
|
|
|
void connectSSL(bool performHandshake);
|
|
/// Performs a client-side SSL handshake and establishes a secure
|
|
/// connection over an already existing TCP connection.
|
|
|
|
long verifyPeerCertificateImpl(const std::string & hostName);
|
|
/// Performs post-connect (or post-accept) peer certificate validation.
|
|
|
|
static bool isLocalHost(const std::string & hostName);
|
|
/// Returns true iff the given host name is the local host
|
|
/// (either "localhost" or "127.0.0.1").
|
|
|
|
bool mustRetry(int rc, Poco::Timespan & remaining_time);
|
|
/// Returns true if the last operation should be retried,
|
|
/// otherwise false.
|
|
///
|
|
/// In case of an SSL_ERROR_WANT_READ error, and if the socket is
|
|
/// blocking, waits for the underlying socket to become readable.
|
|
///
|
|
/// In case of an SSL_ERROR_WANT_WRITE error, and if the socket is
|
|
/// blocking, waits for the underlying socket to become writable.
|
|
///
|
|
/// Can also throw a Poco::TimeoutException if the socket does
|
|
/// not become readable or writable within the sockets
|
|
/// receive or send timeout.
|
|
|
|
int handleError(int rc);
|
|
/// Handles an SSL error by throwing an appropriate exception.
|
|
|
|
void reset();
|
|
/// Prepares the socket for re-use.
|
|
///
|
|
/// After closing and resetting a socket, the socket can
|
|
/// be used for a new connection.
|
|
///
|
|
/// Note that simply closing a socket is not sufficient
|
|
/// to be able to re-use it again.
|
|
|
|
private:
|
|
SecureSocketImpl(const SecureSocketImpl &);
|
|
SecureSocketImpl & operator=(const SecureSocketImpl &);
|
|
|
|
const BIO_METHOD * getBioMethod() const;
|
|
/// Returns the BIO_METHOD to use for the SSL transport BIO.
|
|
/// Falls back to `BIO_s_socket()` when no custom method was set via `setBioMethod`.
|
|
|
|
struct StdRecursiveMutex final : RecursiveMutex
|
|
{
|
|
void lock() override { _m.lock(); }
|
|
void unlock() override { _m.unlock(); }
|
|
std::recursive_mutex _m;
|
|
};
|
|
|
|
using ScopedLock = std::lock_guard<RecursiveMutex>;
|
|
|
|
mutable std::unique_ptr<RecursiveMutex> _mutex{std::make_unique<StdRecursiveMutex>()};
|
|
SSL * _pSSL; // GUARDED_BY _mutex
|
|
Poco::AutoPtr<SocketImpl> _pSocket;
|
|
Context::Ptr _pContext;
|
|
bool _needHandshake;
|
|
std::string _peerHostName;
|
|
Session::Ptr _pSession;
|
|
const BIO_METHOD * _bioMethod = nullptr;
|
|
/// Contract: when set, store the `SocketImpl *` in the BIO's data.
|
|
|
|
friend class SecureStreamSocketImpl;
|
|
|
|
Poco::Timespan getMaxTimeoutOrLimit();
|
|
//// Return max(send, receive) if non zero, otherwise maximum timeout
|
|
};
|
|
|
|
|
|
//
|
|
// inlines
|
|
//
|
|
inline poco_socket_t SecureSocketImpl::sockfd()
|
|
{
|
|
return _pSocket->sockfd();
|
|
}
|
|
|
|
|
|
inline SSL * SecureSocketImpl::ssl() const
|
|
{
|
|
return _pSSL;
|
|
}
|
|
|
|
|
|
inline Context::Ptr SecureSocketImpl::context() const
|
|
{
|
|
return _pContext;
|
|
}
|
|
|
|
|
|
inline const std::string & SecureSocketImpl::getPeerHostName() const
|
|
{
|
|
return _peerHostName;
|
|
}
|
|
|
|
|
|
}
|
|
} // namespace Poco::Net
|
|
|
|
|
|
#endif // NetSSL_SecureSocketImpl_INCLUDED
|